Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Apr 2023 12:48:19 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Li Ningke <lnk_01@hust.edu.cn>
Cc:     hust-os-kernel-patches@googlegroups.com,
        Dongliang Mu <dzm91@hust.edu.cn>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: davinci: Remove dead code in `davinci_spi_probe()`
Message-ID: <d29c4b3e-9e82-4ea9-9f0c-a8e2c7637eb9@sirena.org.uk>
References: <20230423032446.34347-1-lnk_01@hust.edu.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="x6j9QIhvVoXDS8bt"
Content-Disposition: inline
In-Reply-To: <20230423032446.34347-1-lnk_01@hust.edu.cn>
Precedence: bulk


--x6j9QIhvVoXDS8bt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 23, 2023 at 03:24:46AM +0000, Li Ningke wrote:
> Smatch complains that
> drivers/spi/spi-davinci.c:915 davinci_spi_probe() warn:
> platform_get_irq() does not return zero
>=20
> There is no need to check whether the return value is zero as
> `platform_get_irq()` only returns non-zero IRQ number on success
> or negative error number on failure, removing them to solve this
> problem.

Is that check valid?  0 was a valid interrupt for some architectures...

--x6j9QIhvVoXDS8bt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRGbIIACgkQJNaLcl1U
h9Casgf+KIwtYlodKe8H8PSdPE/oTgeLmc+0elLcipRwbHokM+HJMWUu8NDqdte0
wppWJ/gdFfBVF0PXYHaIxqlHI0hXUiyRaZ2udzF0ZCwPSkiSMFtMmIsiFH1ZRqwh
ns0h9ebnmdP+Rz4P7OIyiJeYIzYEzFWk2syPSEGoWMAy1+DZ6mET/oScMYYbMYNz
SMAJlE397/Wb8sh/OQ9/m3ANc9HV1CnK0CYEI+m6fOj4k6dNmb8urjmPRV+J+zmR
2X7kCCXu75ZOPm8aYaq5bOllmay4kQDu4cdOnO/1u83CF2iFDeqCz393e4eBmW0j
xQmhFfE5cSr+1ZKVZJmmADHt+OBI4w==
=9lLB
-----END PGP SIGNATURE-----

--x6j9QIhvVoXDS8bt--