Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Apr 2023 12:54:48 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Yingsha Xu <ysxu@hust.edu.cn>
Cc:     Serge Semin <fancer.lancer@gmail.com>,
        hust-os-kernel-patches@googlegroups.com, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: remove return value check of debugfs_create_dir()
Message-ID: <eb3c6aa6-6820-4e94-8eb0-5abd3b627fcc@sirena.org.uk>
References: <20230423061155.2540-1-ysxu@hust.edu.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vvx6pjyUAG9u5a+8"
Content-Disposition: inline
In-Reply-To: <20230423061155.2540-1-ysxu@hust.edu.cn>
Precedence: bulk


--vvx6pjyUAG9u5a+8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 23, 2023 at 02:11:54PM +0800, Yingsha Xu wrote:
> Smatch complains that:
> dw_spi_debugfs_init() warn: 'dws->debugfs' is an error pointer
>  or valid
>=20
> Debugfs checks are generally not supposed to be checked for errors
> and it is not necessary here.
>=20
> Just delete the dead code.

This is very much a question of taste with a range of use cases
available.

--vvx6pjyUAG9u5a+8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRGbggACgkQJNaLcl1U
h9B6Ugf/b159bWCAqJBwfw5277rkoMI9WDLRnmgIo3Vxh3dP0+K8N9LdFjsSsKiD
HxQbnaIFTfMq/t9lzF0scd4xu/hGS/S/4QiljaA7xki1ZRVQ1/RPxU1GJb+eJd5c
vMrP2ldgqWKTU4k6SEnzUx4UgyQJvPwx9doFyq1hGdfbClJl8I3gw6SROP/bIt1I
3lXhpNMr2OHofwiWSwsa7La2SHrnvb29sl+me0xyw3hpg5YF5KEVc7EIDyvfCOPb
N/PV8QHCz9gGdiFp9qTTD+19FAHVe7iLbqkQ9luKWh0yFMMZpVKdSQbq6XjO96Ac
Pc46PT48sZnKk3Ciiy6JLytfTonFIw==
=dz1r
-----END PGP SIGNATURE-----

--vvx6pjyUAG9u5a+8--