Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp5486570rwr; Mon, 24 Apr 2023 05:07:24 -0700 (PDT) X-Google-Smtp-Source: AKy350aW9H4XP4I4s3uDWSixFw/qpJ4ZgcwLQcSBuSw/tW/4TDKFR8oIB9WGbs4/kLCdKGBccD3U X-Received: by 2002:a17:903:4093:b0:1a4:f295:32fa with SMTP id z19-20020a170903409300b001a4f29532famr11436172plc.15.1682338043630; Mon, 24 Apr 2023 05:07:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682338043; cv=none; d=google.com; s=arc-20160816; b=wWz9Og8qL2WovX2bhMkR6xxMFxLEFHSYadg7HtelvNpNkHNqhDUxXEwPs9ijHSAZcs Vz3ToUdtGiA9e2jm7LLQmBG61C5rW7f1j1z/T+aUPqXiiQ4JPRVE7Cli6Hh1hEmbgPZO 1L/5BzlY9CJ4Tdpg262RB8xGPe0tPQ+Z7xvUaXSOpP/+gftR5lXxRcr2WzQ98c26tn0S hdoduILVZLDzrmePCUu4+VCc+fV7wLsHF0uDfMZibBGOke4Ep0pvUs6gD6UMEj3DIOsx jsl1q9oorEa7h0AJja6s91o3HknSFPlHBQ+lzPb8Q6xtJrRARkmzyTZVFR65wCZKZqwd B3dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=I2E6bsA4GSej+ovVD3xRo8aYuAiPwVPdjepeG6qyxiI=; b=dE3jGFWSENxjUI7zn70uFbo3kWqUqMA0EL6aYQV8g6N25f5I7CAfw2mGhbuwCkhveg d0czm8pY7JcOXZXhR8tdLSC8A3NZ9oMW7q+9knEfNBmVlAXLAV9HNrPT+Zb/WZSmPmuh 6LIe51nN8W7ZW1Fo+nTbTsrTK/iB0OH8M/ARG495PJurwRuEY5aPtyagNqCEv6VX4Bos whTEueC4cz8dRJhcyYMgpMFdWxYd1R8VxiYFqrsu+C3/YPKCQtXXUmLz7vzNtQzUdDdw zMOO6+xu/Meu8bTvzQavJ/nAnLhwBVl6H1GWPr7nCbt9+e/SJK3lqklDsfzcHCmNTod6 o+GQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IbtiuAY+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z13-20020a1709027e8d00b0019a78d4c761si10870409pla.93.2023.04.24.05.07.11; Mon, 24 Apr 2023 05:07:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IbtiuAY+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231748AbjDXL5J (ORCPT + 99 others); Mon, 24 Apr 2023 07:57:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231730AbjDXL5F (ORCPT ); Mon, 24 Apr 2023 07:57:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B5CB46A4 for ; Mon, 24 Apr 2023 04:57:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 07D4F620FD for ; Mon, 24 Apr 2023 11:57:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFDE7C43443; Mon, 24 Apr 2023 11:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682337423; bh=I2E6bsA4GSej+ovVD3xRo8aYuAiPwVPdjepeG6qyxiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IbtiuAY+jHtvjd6G+C4oXzfROYDxKZH53g82RZk7dMWoMYU45FsEiZz5yfdFs6fb7 3aSf2dkS+3PiXoBNcEzmajEQWCWnrlRb7aiAhs7ghuVSITwoJkzaM5uZaL9Nl1BO8r IHuVcZR6wsYd5JfA9Hm68GtjxZVoPVIpJUyTgqoDPGpLSTagkndKkxdgBRxuQ5A8LK GPi/iNa3s1Ut3xTRHy9FpITRlbJglXlTv7VqRNoiVvJTUYZ78knO9eyIheySQQ8A/G q61EhVMG1A/3xNDaNq1fQqnWIFpiFNRO3TUITMRy6EZ45To9FEqhhlDhpPVsSYEzQF fTbkUB/PI4shw== Date: Mon, 24 Apr 2023 12:56:58 +0100 From: Mark Brown To: Yuchen Yang Cc: Liam Girdwood , Stephen Boyd , hust-os-kernel-patches@googlegroups.com, Dongliang Mu , Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: regulator: core: remove return value check of `rdev->debugfs` Message-ID: <1ea2bb36-af47-4651-8f37-b72736ca0367@sirena.org.uk> References: <20230424025738.34950-1-u202114568@hust.edu.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="W/Ez3a5pkBrDa1Ia" Content-Disposition: inline In-Reply-To: <20230424025738.34950-1-u202114568@hust.edu.cn> X-Cookie: A rolling disk gathers no MOS. X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --W/Ez3a5pkBrDa1Ia Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 24, 2023 at 10:57:37AM +0800, Yuchen Yang wrote: > Smatch complains that: > rdev_init_debugfs() warn: 'rdev->debugfs' is an error pointer or valid >=20 > According to the documentation of the debugfs_create_dir() function,=20 > there is no need to check the return value of this function. > Just delete the dead code. Please stop sending these patches. --W/Ez3a5pkBrDa1Ia Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRGbokACgkQJNaLcl1U h9ASzQf+NpZeyskBotd5pfBm3Yj2NP65xRbsRbQwd7xwiExZ4QMPtTZR3OnsizW2 z25qC4HlqaSKXSWzZieY3nrsoHU1NMM0aKsSrphVx8LKqZH6l+Ud2ZFHm6OFIGYF 59FZuosf+XaC3VnX5th04LFIqpXMNw+PrflvwfszTnk+zTp5sRTgy5fXsVjt2xDd BPHWZHBIkPPyMkHuUrhykUQObSrWCD2mz6GNKMf2ngyi7hZQCkGrPUO1az1K5Zs4 rqQLnRwCVJbGmgKWjAuNxO15xsDBPrpc6ckMMicbMCnXzOufm8FCFEWpYzIV3Fj9 I3geNDdoNxssVS3JiCNZSxdhjRQUNA== =4rZs -----END PGP SIGNATURE----- --W/Ez3a5pkBrDa1Ia--