Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4b1dcfd3-a82c-5165-7c0a-1767f97273e6@hust.edu.cn>
Date:   Mon, 24 Apr 2023 20:17:09 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: [PATCH] drivers: regulator: core: remove return value check of
 `rdev->debugfs`
To:     Mark Brown <broonie@kernel.org>,
        Yuchen Yang <u202114568@hust.edu.cn>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        hust-os-kernel-patches@googlegroups.com,
        Liam Girdwood <lrg@slimlogic.co.uk>,
        linux-kernel@vger.kernel.org
References: <20230424025738.34950-1-u202114568@hust.edu.cn>
 <1ea2bb36-af47-4651-8f37-b72736ca0367@sirena.org.uk>
From:   Dongliang Mu <dzm91@hust.edu.cn>
In-Reply-To: <1ea2bb36-af47-4651-8f37-b72736ca0367@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/4/24 19:56, Mark Brown wrote:
> On Mon, Apr 24, 2023 at 10:57:37AM +0800, Yuchen Yang wrote:
>> Smatch complains that:
>> rdev_init_debugfs() warn: 'rdev->debugfs' is an error pointer or valid
>>
>> According to the documentation of the debugfs_create_dir() function,
>> there is no need to check the return value of this function.
>> Just delete the dead code.
> Please stop sending these patches.

No problem. We will disable this Smatch checker in our daily use.

Thanks for your feedback.