Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Apr 2023 15:26:31 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Hans Schultz <netdev@kapio-technology.com>
Cc:     netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Ido Schimmel <idosch@nvidia.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Ivan Vecera <ivecera@redhat.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net] net: bridge: switchdev: don't notify FDB entries
 with "master dynamic"
Message-ID: <20230424122631.d7kwfwmlwvqjo3pz@skbuf>
References: <20230418155902.898627-1-vladimir.oltean@nxp.com>
 <875y9nt27g.fsf@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <875y9nt27g.fsf@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?f2HCd5LTtF/4xvyics0tUIkRscaNrCS9Ho4dVsKCsvmDwWXGMRZOzo1gVKkB?=
 =?us-ascii?Q?ZS+Np347MLAI0s1ZLNJ0mSA7UqFkhk9Lg9x4C0bczwe7MhhhnaIWJ2eNgAbW?=
 =?us-ascii?Q?FUi/CoBjOVFil30VAo2aCGm6EeyjqXDcaKcDT+ZtKyUW9upPqlxRwYNFpxCF?=
 =?us-ascii?Q?6SFGx/grpcul3HTS1sUGa9R+ex90PO/U/o7oQQtuF4Jmr5neawvMMytmzSSw?=
 =?us-ascii?Q?RkWLXas8UZbxgB5QTDS4mMpPqMLwYxQnRpjhoYusTvZwsLxdHEJtJOZUfFJZ?=
 =?us-ascii?Q?zgTNC3G/NbEQMmFtpBTEkqvOP/2x//kyNLQuZoRMlINLlzzqo6XdwmhGTDqY?=
 =?us-ascii?Q?ozQcTzU16iI9Kc7KtNwc4NrvhddeDR5HuXqzhajCIV0HUCnK4YOprpgO7h2Q?=
 =?us-ascii?Q?5KhD5CaoRCLXYIH8aMjEsLza2gesKyFwOOO7AC9b5Njek9M7vJ6hhEy2qLh5?=
 =?us-ascii?Q?zsHEXMZV3EkOdULoaUWpEyLwcvImbB2okFDCUqAKQAhujdjLqxSIz9zWANfu?=
 =?us-ascii?Q?vrygS88vPsiIs986V7PLlAs6o40yETcGaK5tfcQ8x9Ujr6MJYxuMmPOIoQC3?=
 =?us-ascii?Q?sMvSyGnwp4vWUnoj+PGVOLRRwVc+VDGbdchzdBKw799oD1YUvCTbBOdLb33H?=
 =?us-ascii?Q?+K3fdyigdEYbgbmxTKsWB80sXqWq0s5V3QMYGDLYirWC7XT8KNFheX89i4tC?=
 =?us-ascii?Q?+xxkea855PKZsIaJJeVCA015JPHBqozXBA3j6WSUU5d6s/kUw16dvsBmk2mq?=
 =?us-ascii?Q?9yZkDYL96iPURYNiTPduYwfrQsTkbD1zfn9fZBvdbUXGApZUx97HJqgkRHhJ?=
 =?us-ascii?Q?0jvCdrtFShOCbppiaQVvcWIwgW/mw+wfMj7dwUz1DApm/qSufTvPBfMjk7J3?=
 =?us-ascii?Q?Lqpz56qv3TrI8KQL8yyP6gfIBpKE9mY3uXCS2els/CgdcJjuMCNL8nNJ2jME?=
 =?us-ascii?Q?VeAW/vEJocOApUmSLzusPOFxV9XW4RRAI8LaYrUPL/a/LdJmzf1qojJUB7Re?=
 =?us-ascii?Q?gfy9GbY/vcMUlg0GuxofcUI2laJPza+Mm9eQfOw8ejX5kE0m012k8KYUhIDr?=
 =?us-ascii?Q?lI2IP241Gth7wr6UFbOVwvrwD7Cm+awH3xFHfADDdBGjln/pbccP0DP9/Cci?=
 =?us-ascii?Q?PeUGWJW/DLhcmRUG23LgYOQWR3gpUCqj+2e/YKfpDICa6SuPGMS3MALHRm7U?=
 =?us-ascii?Q?nIcSdfOvUAYDSyLnexm7gKVCEnuLA7CYQ+es4wUZQLjqgOqdc6lCwiamCjOe?=
 =?us-ascii?Q?Vd0QM/rZBu3Kdl8rTBS051/PXpYHmcADkXd011C+mM/JnwIAJeoAg9WrTfua?=
 =?us-ascii?Q?hiqTtfgYQabRJFWu7BLLPswEVlmmQFcNPMGph7jifKSXs4HLR7pVAZ6Hl6B0?=
 =?us-ascii?Q?K+I0d/fZtPGZqcC/ZrFuOHQ5Z0Mpi0NtwGPDVoJkrfTy7+A9ddj/DdOLTs+B?=
 =?us-ascii?Q?Of7RL2VsVxfQ6F6zpbxaGSX4itZgxUtr7O+4fhby2BH6cPcunC95Bwnl+SvK?=
 =?us-ascii?Q?qaiipKLs3OgWWSXxNO1rF51CntH/qZ25c37vlKwyTpzhE46H0FO1Dta3YORz?=
 =?us-ascii?Q?35uQi49wtMj3foyr38Fyh84z3srPdj/0OBd26c02x2lCEDpKj32JrytY181s?=
 =?us-ascii?Q?6A=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 882edc58-a67d-46d9-fc10-08db44bf2488
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6454.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2023 12:26:39.7461
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2ywN5bp9fgALwm0jowJLPHoqNBdfgN7r6Dnb07UO5jgd0q8NEpHSq0brmmhUwhzOB/7cMqM33BJu790AZMA+ww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7898
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Apr 23, 2023 at 10:47:15AM +0200, Hans Schultz wrote:
> I do not understand this patch. It seems to me that it basically blocks
> any future use of dynamic fdb entries from userspace towards drivers.
> 
> I would have expected that something would be done in the DSA layer,
> where (switchcore) drivers would be able to set some flags to indicate
> which features are supported by the driver, including non-static
> fdb entries. But as the placement here is earlier in the datapath from
> userspace towards drivers it's not possible to do any such thing in the
> DSA layer wrt non-static fdb entries.

As explained too many times already in the thread here:
https://patchwork.kernel.org/project/netdevbpf/patch/20230318141010.513424-3-netdev@kapio-technology.com/
the plan is:

| Just like commit 6ab4c3117aec ("net: bridge: don't notify switchdev for
| local FDB addresses"), we could deny that for stable kernels, and add
| the correct interpretation of the flag in net-next.

Obviously we have not reached the end of that plan, and net-next is closed now.