Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Apr 2023 14:00:14 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Peter Enderborg <peter.enderborg@sony.com>,
        Yingsha Xu <ysxu@hust.edu.cn>,
        Serge Semin <fancer.lancer@gmail.com>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: remove return value check of debugfs_create_dir()
Message-ID: <55ab40bb-8b3e-496d-bf45-6c4ebd01e43f@sirena.org.uk>
References: <20230423061155.2540-1-ysxu@hust.edu.cn>
 <eb3c6aa6-6820-4e94-8eb0-5abd3b627fcc@sirena.org.uk>
 <368e31ae-31b5-839f-72e3-20a27239cb0b@sony.com>
 <a4706089-399b-4663-9ac8-216f12ebe7ca@sirena.org.uk>
 <2023042421-landowner-magnitude-a38c@gregkh>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="twwtZg5AgNt9nx7z"
Content-Disposition: inline
In-Reply-To: <2023042421-landowner-magnitude-a38c@gregkh>
Precedence: bulk


--twwtZg5AgNt9nx7z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 24, 2023 at 02:53:12PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 24, 2023 at 01:32:14PM +0100, Mark Brown wrote:

> > There's issues with partially created debugfs structures getting in the
> > way of people trying to debug things, just completely ignoring all
> > errors can create confusion as the diagnostic information people believe
> > is being shown to them ends up being partial or mistructured without any
> > indication that this has happened.

> How do you end up with partially created debugfs structures?

The ones I've seen have been name collisions caused by for example the
debugfs structure created being flatter than the device model structure,
though obviously something unanticipated could come up.

--twwtZg5AgNt9nx7z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRGfV0ACgkQJNaLcl1U
h9DJYwf/TTBIVw0o1yEbPfrrayohucG1g5k1JQliO/VyIp3MQJEDupEfsczMrWZL
Y8oMnHjC0xlOy658EasXHArP8E3+efPZleYlNPESJJ9hW+Xj/rRPYdxJDdpwzE6l
s/lUCVOAe6azDuusWVocOyPrFuT5qeTgkvYYTV12RTxkapIUx2rT9Oed+h46ONWG
j4sQrbbLgaWsWUI+I7/XMB8HLKS1lGNE3GrJtF5UDdxX4HlplyCHzn+x5lOOtklV
oa27Cq9BSef9PkMvc4eGcDu89Esgm3dv44/n6HBnEug3hm/Xdwvd4DFJg77YCPZb
yQCfYq9MBCIYkzZl+0l8++MyGhRjuw==
=YueL
-----END PGP SIGNATURE-----

--twwtZg5AgNt9nx7z--