Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Apr 2023 15:01:15 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Gencen Gan <gangecen@hust.edu.cn>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        hust-os-kernel-patches@googlegroups.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] net: amd: Fix link leak when verifying config failed
Message-ID: <ZEZ9m4Q7qO0UTx1B@corigine.com>
References: <20230424104643.182296-1-gangecen@hust.edu.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230424104643.182296-1-gangecen@hust.edu.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bc5bGmE7b9SNdqZxZeJHoWbD9WiACUi5VLmxcMyakPmOMHVcdkPoUQ0sbLog?=
 =?us-ascii?Q?U+3CGOyjjQ6KS6woOiwWWhrsXd1i+Z5iZNIp/2ZneE1JVyit9+RaaDHE/qTl?=
 =?us-ascii?Q?tNifAKcTo8mkoOsrSsgHUdprfzF0OLZboEYnX+bPahk2YAJKaNj8YPjSGi3w?=
 =?us-ascii?Q?DXvPmxsii6GTnOZ30xP0AaTUJNr2dZdFs/KEjW2W+we+hp0v44ANZ8uiEJQ1?=
 =?us-ascii?Q?AUVh1Qik/JheFdvbwopnY026QM/s/or1HJY9IlPRistXH5OAB51QdMApifyb?=
 =?us-ascii?Q?9bwPM0Qv/RSz9K6Qq2vRagYOfELXRKBsM3CIqp7IUmdZH/XQFFCBn5R4r+aE?=
 =?us-ascii?Q?xu2zSrXsD+qR+HW3PM2C9TJdq3X5Eh5JMEq1U+BCTCgeO/3wRmAw80SLnfON?=
 =?us-ascii?Q?DvFZPjTsVFlg4B1gJrqWHCdw5BaSyTw551tS9ZzdOkzf6h7CRhaDyerYK8Un?=
 =?us-ascii?Q?1FfbYBGQNTVADTrpjiqve5ytW3VlgN50gXy7dpkkVhuNeHIZEjBFatVOLcOL?=
 =?us-ascii?Q?8EVJhGOVSnaSu6alam42SAOtCvTF/LoHkYsTszMxzOsImQXLp1nWHGGmzz+8?=
 =?us-ascii?Q?njHXFk7UUYDXeFzGFH7Nt3S+kOfBxdKuvXoKtWy+Vev1lZ5iuJhXisvS2rfl?=
 =?us-ascii?Q?PnwLp9BdChWU1NR6ucbxTA/BZczIie90wRcyO3DpKsvYFd8wUQ/agHhrE4Wc?=
 =?us-ascii?Q?cKNzJCzqx1bWEMgT/F1T+mB3p/IQsG4aqivxg4y0D/rseFLqG61fe2666eb9?=
 =?us-ascii?Q?VWOXbxzE8PUfxWCsGJ1B1h+UvZuRNHIL5EZnj5VGyuimuCN5AbE80+mV3T0y?=
 =?us-ascii?Q?bxRK0RqJ91WsD4vtSiTJrDi89GJhXNqeiYYYwB1UTIDmajNJSKTaGKgor2ar?=
 =?us-ascii?Q?t1WynTbDjK8Tc/1veNGcwIX/3dCWIWbElI88w7zNdPt6vd5rFhUx0r/83RFi?=
 =?us-ascii?Q?Z7myjIfRZwM0WPyAcYMRubaaa/byCutZWBojx+2RmxZaRGGA+xufA0cmzmIy?=
 =?us-ascii?Q?LGvw9VRacTCnD7KNnrSOCc43iQEqNjyGNbyF1C2e8YCY9xGHhJXexci6uUhC?=
 =?us-ascii?Q?iSuZznlwMrf94ijUoWf3z/qq1kkSBVSP8bcyNKUn2OB8i6dImtm0sD9Z7vbA?=
 =?us-ascii?Q?C3/E79VPGah9YmKjnZEj8j6Ks4jdbnI6wxBJcQfS5+8P0NxBrlsaxDI9PyE7?=
 =?us-ascii?Q?H5Ds8U8xjoMRG5HSRYIsR/REaT8U0UXV3zuFhbhG/iKTy+FU2MjpFQgRd5Sn?=
 =?us-ascii?Q?rat4jMZYuvE+/zjjLD5AjNG1m3Isk1JaIS4gvlcwcQb4TU1fzayua2B/IkAi?=
 =?us-ascii?Q?RHOzecSGyi4gZwHPa6kwYwXoKYgsVlv96OI0gfeiudnzHNGCExxpbNez8/7M?=
 =?us-ascii?Q?XPVZ00W/s19588r28r3n48R8BuzPHs8X+bOl1mx5R5l1jVCL14KaX1aCXUeX?=
 =?us-ascii?Q?EsnTgmdUZ1RQMkWtkKW+CR8Qlj79RukA1+fKPR/PkRZNg7TImUXrGkVu+6Bf?=
 =?us-ascii?Q?aLRBFdV/mMVHMhljc4l2gMwMKbqVlPxWj4u6BO4mdDJNdLpNil0jOy9khOOC?=
 =?us-ascii?Q?yfcH/tmLl5fsdxg+yvF1UczUKQUG8PaUgzUgDnvbGoNoGh2XG/f7VPXQ2HoV?=
 =?us-ascii?Q?+ZyfHQMtO7Ysqqf+oySPxFVwLp4rrXWmFx1X54N2kSRviHheSp9i1+2lzgwU?=
 =?us-ascii?Q?/2SNNw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 609d9b2f-2785-4e77-9137-08db44c40087
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2023 13:01:21.9302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2gkRpOWGruNR5EbHJRW/J/Cp6zBUaHxssoXzR2c4zIwJwp4F3BHgcppg1yjOOAvsieR47ptSu7CMa8cwmhTF7XATeyekneSMhSYtDaKptfE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5753
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 24, 2023 at 06:46:43PM +0800, Gencen Gan wrote:
> After failing to verify configuration, it returns directly without
> releasing link, which may cause memory leak.
> 
> Paolo Abeni thinks that the whole code of this driver is quite 
> "suboptimal" and looks unmainatained since at least ~15y, so he 
> suggests that we could simply remove the whole driver, please 
> take it into consideration.
> 
> Simon Horman suggests that the fix label should be set to 
> "Linux-2.6.12-rc2" considering that the problem has existed
> since the driver was introduced and the commit above doesn't
> seem to exist in net/net-next.
> 
> Fixes: 99c3b0265649 ("Linux-2.6.12-rc2")

Unless I'm mistaken, this should be:

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

> Signed-off-by: Gan Gecen <gangecen@hust.edu.cn>
> Reviewed-by: Paolo Abeni <pabeni@redhat.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>

I think that tags such as Reviewed-by need to be given explicitly.
And as the above two Reviewed-by tags were not, so it is a bit
odd for them to appear above.

> ---
> v3->v4: modify the 'Fixes:' tag to make it more accurate.
>  drivers/net/ethernet/amd/nmclan_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c
> index 823a329a921f..0dd391c84c13 100644
> --- a/drivers/net/ethernet/amd/nmclan_cs.c
> +++ b/drivers/net/ethernet/amd/nmclan_cs.c
> @@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link)
>      } else {
>        pr_notice("mace id not found: %x %x should be 0x40 0x?9\n",
>  		sig[0], sig[1]);
> -      return -ENODEV;
> +      goto failed;
>      }
>    }
>  
> -- 
> 2.34.1
>