Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Apr 2023 16:03:21 +0300
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Suhui <suhui@nfschina.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm: remove unnecessary (void*) conversions
Message-ID: <ZEZ+GUsvaqWg6A3W@kuha.fi.intel.com>
References: <20230424041940.132866-1-suhui@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230424041940.132866-1-suhui@nfschina.com>
Precedence: bulk

On Mon, Apr 24, 2023 at 12:19:40PM +0800, Suhui wrote:
> No need cast (void*) to (struct fusb302_chip *) or (struct tcpm_port *).
> 
> Signed-off-by: Suhui <suhui@nfschina.com>

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tcpm/fusb302.c | 2 +-
>  drivers/usb/typec/tcpm/tcpm.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 1ffce00d94b4..4b7b8f6af3ca 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -190,7 +190,7 @@ static void fusb302_log(struct fusb302_chip *chip, const char *fmt, ...)
>  
>  static int fusb302_debug_show(struct seq_file *s, void *v)
>  {
> -	struct fusb302_chip *chip = (struct fusb302_chip *)s->private;
> +	struct fusb302_chip *chip = s->private;
>  	int tail;
>  
>  	mutex_lock(&chip->logbuffer_lock);
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 1ee774c263f0..ab3a54662ed9 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -737,7 +737,7 @@ static void tcpm_log_source_caps(struct tcpm_port *port)
>  
>  static int tcpm_debug_show(struct seq_file *s, void *v)
>  {
> -	struct tcpm_port *port = (struct tcpm_port *)s->private;
> +	struct tcpm_port *port = s->private;
>  	int tail;
>  
>  	mutex_lock(&port->logbuffer_lock);
> -- 
> 2.30.2

-- 
heikki