Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757034AbXI2JbV (ORCPT ); Sat, 29 Sep 2007 05:31:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752694AbXI2JbP (ORCPT ); Sat, 29 Sep 2007 05:31:15 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:33138 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752054AbXI2JbO (ORCPT ); Sat, 29 Sep 2007 05:31:14 -0400 Date: Sat, 29 Sep 2007 10:31:12 +0100 From: Christoph Hellwig To: Christoph Hellwig Cc: Andreas Gruenbacher , jblunck@suse.de, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, tiwai@suse.de Subject: Re: [patch 09/10] Use struct path in fs_struct Message-ID: <20070929093112.GA28808@infradead.org> Mail-Followup-To: Christoph Hellwig , Christoph Hellwig , Andreas Gruenbacher , jblunck@suse.de, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, tiwai@suse.de References: <20070927141200.820970144@X40.localnet> <20070927141229.008500593@X40.localnet> <20070928184214.GI14269@lst.de> <200709282239.49088.agruen@suse.de> <20070929092426.GA25343@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070929092426.GA25343@lst.de> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 28 On Sat, Sep 29, 2007 at 11:24:26AM +0200, Christoph Hellwig wrote: > On Fri, Sep 28, 2007 at 10:39:48PM +0200, Andreas Gruenbacher wrote: > > On Friday 28 September 2007 20:42, Christoph Hellwig wrote: > > > __d_path should probably switch to taking a struct path * aswell. > > > > Indeed, it now easily can. Here we go... > > > > > > One less parameter to __d_path > > > > All callers to __d_path pass the dentry and vfsmount of a struct > > path to __d_path. Pass the struct path directly, instead. > > Looks good. If you have some sparse time left the dentry and vfsmnt > arguments of __d_path and d_path should probably be switched over > to a struct path aswell. For about half of the callers that works > out easily because they have a struct file, and some need some > reshuffling (e.g. /proc/ symlink code or the dcookies that want to > store a struct path aswell) And thinking about it the function should also grow a better name, say print_path. And if you really touch it moving the kerneldoc comment to d_path from __d_path would also be very useful. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/