Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5a820cf9aae169e18635a8c867835817a50892b0.camel@sipsolutions.net>
Subject: Re: [PATCH v1 0/3] kunit: Deferred action helpers
From:   Benjamin Berg <benjamin@sipsolutions.net>
To:     David Gow <davidgow@google.com>,
        Matti Vaittinen <mazziesaccount@gmail.com>,
        Maxime Ripard <maxime@cerno.tech>,
        Brendan Higgins <brendan.higgins@linux.dev>,
        Stephen Boyd <sboyd@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Daniel Latypov <dlatypov@google.com>,
        Rae Moar <rmoar@google.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Jonathan Cameron <jic23@kernel.org>,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        kunit-dev@googlegroups.com
Date:   Mon, 24 Apr 2023 16:02:29 +0200
In-Reply-To: <54b49d4ddf371d0581f3b795f50f7f6673557a96.camel@sipsolutions.net>
References: <20230421084226.2278282-1-davidgow@google.com>
         <54b49d4ddf371d0581f3b795f50f7f6673557a96.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

Hi David,

On Mon, 2023-04-24 at 14:32 +0200, Benjamin Berg wrote:
> On Fri, 2023-04-21 at 16:42 +0800, 'David Gow' via KUnit Development wrot=
e:
> > This is v1 of the KUnit deferred actions API, which implements an
> > equivalent of devm_add_action[1] on top of KUnit managed resources. Thi=
s
> > provides a simple way of scheduling a function to run when the test
> > terminates (whether successfully, or with an error). It's therefore ver=
y
> > useful for freeing resources, or otherwise cleaning up.
> >=20
> > The notable changes since RFCv2[2] are:
> > - Got rid of the 'cancellation token' concept. It was overcomplicated,
> > =C2=A0 and we can add it back if we need to.
> > - kunit_add_action() therefore now returns 0 on success, and an error
> > =C2=A0 otherwise (like devm_add_action()). Though you may wish to use:
> > - Added kunit_add_action_or_reset(), which will call the deferred
> > =C2=A0 function if an error occurs. (See devm_add_action_or_reset()). T=
his
> > =C2=A0 also returns an error on failure, which can be asserted safely.
> > - Got rid of the function pointer typedef. Personally, I liked it, but
> > =C2=A0 it's more typedef-y than most kernel code.
> > - Got rid of the 'internal_gfp' argument: all internal state is now
> > =C2=A0 allocated with GFP_KERNEL. The main KUnit resource API can be us=
ed
> > =C2=A0 instead if this doesn't work for your use-case.
> >=20
> > I'd love to hear any further thoughts!
>=20
> I am happy with it as-is.

Oh, wait. Nothing big, but I just noticed that the new API functions
seem to not yet be exported using EXPORT_SYMBOL_GPL.

Benjamin

> Reviewed-By: Benjamin Berg <benjamin.berg@intel.com>
>=20
> >=20
> > Cheers,
> > -- David
> >=20
> > [1]:
> > https://docs.kernel.org/driver-api/basics.html#c.devm_add_action
> > [2]:
> > https://patchwork.kernel.org/project/linux-kselftest/list/?series=3D735=
720
> >=20
> >=20
> > David Gow (3):
> > =C2=A0 kunit: Add kunit_add_action() to defer a call until test exit
> > =C2=A0 kunit: executor_test: Use kunit_add_action()
> > =C2=A0 kunit: kmalloc_array: Use kunit_add_action()
> >=20
> > =C2=A0include/kunit/resource.h=C2=A0 | 76 +++++++++++++++++++++++++++++=
++
> > =C2=A0include/kunit/test.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 10 ++++-
> > =C2=A0lib/kunit/executor_test.c | 11 ++---
> > =C2=A0lib/kunit/kunit-test.c=C2=A0=C2=A0=C2=A0 | 88
> > +++++++++++++++++++++++++++++++++++-
> > =C2=A0lib/kunit/resource.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 95
> > +++++++++++++++++++++++++++++++++++++++
> > =C2=A0lib/kunit/test.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 | 48 ++++----------------
> > =C2=A06 files changed, 279 insertions(+), 49 deletions(-)
> >=20
> > --=20
> > 2.40.0.634.g4ca3ef3211-goog
> >=20
>=20