Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp5651486rwr; Mon, 24 Apr 2023 07:13:41 -0700 (PDT) X-Google-Smtp-Source: AKy350bDm/tyZtG/GE/pV8IGs/11r+y/3mqDhQjMCw5OZt+dLHyAzcrkpaH8FEf6hofTmAZlVrRq X-Received: by 2002:a05:6a20:2d0a:b0:ee:d553:5cee with SMTP id g10-20020a056a202d0a00b000eed5535ceemr15437447pzl.16.1682345621267; Mon, 24 Apr 2023 07:13:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682345621; cv=none; d=google.com; s=arc-20160816; b=1Ax4MbhMNjC1ICHiqMePGnIfNt7t2D9Vx+HVN/x1ErqAY9zTDliHIO/2yIXN1g/Win ZbhdFw3Od4/Z+VXv7cq4VEebHH1kdVLI/71YvSM2sH3oK9hcENkJNuda4RmNxACpyE1Z cQSa/ZP7K2ZpqT8NzQXVM+md3Cw9bxdplnymhBhHOZpQufWgOfbXtyHqWfaUiNaZqU2j p8J46vOIRe8JoAPGq5p4f+s1LdmtOtJpjzDYrX1uGwyb4T1YtzYTD7OnpjkaYUJmwqbt rV0f4xf7o5dmHH/b/3rupOS91vNUmlEyNnov+ltIGYgp0uiDCHicnef0q3U2W/1FtAJ2 Pshg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=7uMzSQcvofb9ZK7sDFI4FXlhrVcrNNEsLBbZDQpU+t8=; b=nt0gCbMI+2nURrwrm4LY/6LIFF8Dy8m8nF63d1DWbR8XQa1JrPMpQUZJX6L+9/SMPG yZCgCObiH7lwc6D7QpQ7SCENY/30dE6xggSXdXh/y2JwBcRhg4OmFFMH6aOnbuaPiZhq RjKYduYpPYsyx3ogNlCjn5r5CFGHCKuaQMLVov5j95B1Ypjo8yFG+UEFXkpjAvqp8xNK pmvLg2EV1XY6MBirVPIJw2CXD+80p/hxppv2d1hnSVwofQ1C5OmE6eCopQIhn0gUef1P uJ76KNveWplwBVZ4S22TCPby/x0vOQTMKmR4wuPGD3pes3+Tok6257sSjRgS6F0dBcZm MIZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=hiAhfsKJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u15-20020a65670f000000b0051ba204e005si11191541pgf.199.2023.04.24.07.13.24; Mon, 24 Apr 2023 07:13:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=hiAhfsKJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231917AbjDXOJF (ORCPT + 99 others); Mon, 24 Apr 2023 10:09:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231756AbjDXOJC (ORCPT ); Mon, 24 Apr 2023 10:09:02 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C0217A97; Mon, 24 Apr 2023 07:08:56 -0700 (PDT) X-UUID: 8966bd36e2a911eda9a90f0bb45854f4-20230424 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=7uMzSQcvofb9ZK7sDFI4FXlhrVcrNNEsLBbZDQpU+t8=; b=hiAhfsKJGsm/AeF5o3VDoOmNqhabX9qgjhBbyfTG0Z6zoYwTz29i0gC/i921nrCX+j24aELCD/dRXJ3WcWlAq62tblagB8cZuMOj6DSW0Kwd6zpPohfJTBHXx4r7vsbH6a+CC5knLBpxtwwTo+cLqiCKtw5lXZs0P5dCW6hPj1w=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.22,REQID:9c60406d-1b53-4939-9b01-2b46b404d1a2,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:90 X-CID-INFO: VERSION:1.1.22,REQID:9c60406d-1b53-4939-9b01-2b46b404d1a2,IP:0,URL :0,TC:0,Content:-5,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Spam_GS981B3D,ACTIO N:quarantine,TS:90 X-CID-META: VersionHash:120426c,CLOUDID:6421f9eb-db6f-41fe-8b83-13fe7ed1ef52,B ulkID:2304242208520YGRKXGC,BulkQuantity:0,Recheck:0,SF:29|28|17|19|48|38,T C:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 ,OSI:0,OSA:0,AV:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-UUID: 8966bd36e2a911eda9a90f0bb45854f4-20230424 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1278148508; Mon, 24 Apr 2023 22:08:50 +0800 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Mon, 24 Apr 2023 22:08:49 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Mon, 24 Apr 2023 22:08:49 +0800 From: Po-Wen Kao To: , , , , Alim Akhtar , Avri Altman , Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , Matthias Brugger , AngeloGioacchino Del Regno CC: , , , , , , , , , , , Subject: [PATCH v5 1/3] scsi: ufs: core: Fix mcq tag calcualtion Date: Mon, 24 Apr 2023 22:08:33 +0800 Message-ID: <20230424140839.22358-2-powen.kao@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20230424140839.22358-1-powen.kao@mediatek.com> References: <20230424140839.22358-1-powen.kao@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Transfer command descriptor is allocated in ufshcd_memory_alloc() and referenced by transfer request descriptor with stride size sizeof_utp_transfer_cmd_desc() instead of sizeof(struct utp_transfer_cmd_desc). Consequently, computing tag by address offset should also refer to the same stride. Signed-off-by: Po-Wen Kao Reviewed-by: Bart Van Assche Reviewed-by: Manivannan Sadhasivam Reviewed-by: Stanley Chu Reviewed-by: Ziqi Chen --- drivers/ufs/core/ufs-mcq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c index 31df052fbc41..3a27fa4b0024 100644 --- a/drivers/ufs/core/ufs-mcq.c +++ b/drivers/ufs/core/ufs-mcq.c @@ -265,7 +265,7 @@ static int ufshcd_mcq_get_tag(struct ufs_hba *hba, addr = (le64_to_cpu(cqe->command_desc_base_addr) & CQE_UCD_BA) - hba->ucdl_dma_addr; - return div_u64(addr, sizeof(struct utp_transfer_cmd_desc)); + return div_u64(addr, sizeof_utp_transfer_cmd_desc(hba)); } static void ufshcd_mcq_process_cqe(struct ufs_hba *hba, -- 2.18.0