Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <aabe7488-29b8-895b-38b8-67e5a7d1dd35@roeck-us.net>
Date:   Mon, 24 Apr 2023 07:57:00 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH RESEND v3 0/3] Add support for ESM
Content-Language: en-US
To:     Neha Malcom Francis <n-francis@ti.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        jdelvare@suse.com, linux-hwmon@vger.kernel.org
Cc:     nm@ti.com, vigneshr@ti.com, u-kumar1@ti.com, kristo@kernel.org
References: <20230424105011.70674-1-n-francis@ti.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20230424105011.70674-1-n-francis@ti.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/24/23 03:50, Neha Malcom Francis wrote:
> Resending as no major changes, commit subject change only.
> 

Maybe you consider changing the subject of the bindings from "misc"
to "hwmon" as not being a major change, but it made me aware that you
are trying to sneak bindings which in my opinion don't belong there
into the hwmon bindings directory. This is not a hardware monitoring
device, it doesn't have anything to do with hardware monitoring, and the
bindings do not belong into bindings/hwmon/.

Maybe you can convince the devicetree maintainers to accept the bindings
into the suggested location, but that will be over my objection.

Guenter


> ESM (Error Signaling Module) is a fundamental IP responsible for
> handling safety events. The driver currently present in U-Boot is
> responsible for configuring ESM. This patch series adds dt-binding and
> nodes for J721E and J7200. This goes towards end goal of having DTB sync
> with that of U-Boot as well as ensuring completeness of hardware
> description in devicetree.
> 
> Neha Malcom Francis (3):
>    dt-bindings: hwmon: esm: Add ESM support for TI K3 devices
>    arm64: dts: ti: k3-j721e: Add ESM support
>    arm64: dts: ti: k3-j7200: Add ESM support
> 
>   .../bindings/hwmon/ti,j721e-esm.yaml          | 53 +++++++++++++++++++
>   arch/arm64/boot/dts/ti/k3-j7200-main.dtsi     |  6 +++
>   arch/arm64/boot/dts/ti/k3-j7200.dtsi          |  1 +
>   arch/arm64/boot/dts/ti/k3-j721e.dtsi          |  1 +
>   4 files changed, 61 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/hwmon/ti,j721e-esm.yaml
>