Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Apr 2023 11:43:11 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonathan Cameron <jic23@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH 5.10 v4 4/5] counter: 104-quad-8: Fix race condition
 between FLAG and CNTR reads
Message-ID: <ZEajjyUDN9z8FXYP@fedora>
References: <20230423232047.12589-1-william.gray@linaro.org>
 <20230423232047.12589-4-william.gray@linaro.org>
 <2023042454-cahoots-rotten-f3f7@gregkh>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="BcBXM3mkZPra247M"
Content-Disposition: inline
In-Reply-To: <2023042454-cahoots-rotten-f3f7@gregkh>
Precedence: bulk


--BcBXM3mkZPra247M
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 24, 2023 at 08:33:18AM +0200, Greg Kroah-Hartman wrote:
> On Sun, Apr 23, 2023 at 07:20:46PM -0400, William Breathitt Gray wrote:
> > commit 4aa3b75c74603c3374877d5fd18ad9cc3a9a62ed upstream.
> >=20
> > The Counter (CNTR) register is 24 bits wide, but we can have an
> > effective 25-bit count value by setting bit 24 to the XOR of the Borrow
> > flag and Carry flag. The flags can be read from the FLAG register, but a
> > race condition exists: the Borrow flag and Carry flag are instantaneous
> > and could change by the time the count value is read from the CNTR
> > register.
> >=20
> > Since the race condition could result in an incorrect 25-bit count
> > value, remove support for 25-bit count values from this driver.
> >=20
> > Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 10=
4-QUAD-8")
> > Cc: <stable@vger.kernel.org> # 5.10.x
> > Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
> > ---
> >  drivers/counter/104-quad-8.c | 18 +++---------------
> >  1 file changed, 3 insertions(+), 15 deletions(-)
>=20
> This patch breaks the build:
>=20
>   CC [M]  drivers/counter/104-quad-8.o
> drivers/counter/104-quad-8.c: In function =E2=80=98quad8_read_raw=E2=80=
=99:
> drivers/counter/104-quad-8.c:117:34: error: =E2=80=98QUAD8_FLAG_BT=E2=80=
=99 undeclared (first use in this function); did you mean =E2=80=98QUAD8_FL=
AG_E=E2=80=99?
>   117 |                 borrow =3D flags & QUAD8_FLAG_BT;
>       |                                  ^~~~~~~~~~~~~
>       |                                  QUAD8_FLAG_E
> drivers/counter/104-quad-8.c:117:34: note: each undeclared identifier is =
reported only once for each function it appears in
> drivers/counter/104-quad-8.c:118:36: error: =E2=80=98QUAD8_FLAG_CT=E2=80=
=99 undeclared (first use in this function); did you mean =E2=80=98QUAD8_FL=
AG_E=E2=80=99?
>   118 |                 carry =3D !!(flags & QUAD8_FLAG_CT);
>       |                                    ^~~~~~~~~~~~~
>       |                                    QUAD8_FLAG_E
>=20
>=20

Ah, the 5.4 and 5.10 patches are missing the IIO changes from the 4.19
patch. I'll adjust and resubmit these two patches.

William Breathitt Gray

--BcBXM3mkZPra247M
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZEajjwAKCRC1SFbKvhIj
K4QzAQDAlZG4LRjGl4P3p6a+rXLGeBAsv7SfStWTU+de+505hgD8CkvoHgUUJYA5
QGrxZFt6xOarz/9S70ib0HzfgJFVjQ0=
=DY7f
-----END PGP SIGNATURE-----

--BcBXM3mkZPra247M--