Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Apr 2023 16:54:40 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Nikita Shubin <nikita.shubin@maquefel.me>
Cc:     Arnd Bergmann <arnd@kernel.org>, Linus Walleij <linusw@kernel.org>,
        Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 16/43] dt-bindings: spi: Add DT bindings ep93xx spi
Message-ID: <8f02b54d-00c5-4328-9e14-ef77097eaabe@sirena.org.uk>
References: <20230424123522.18302-1-nikita.shubin@maquefel.me>
 <20230424123522.18302-17-nikita.shubin@maquefel.me>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qqO6L1/B8uJqiHh5"
Content-Disposition: inline
In-Reply-To: <20230424123522.18302-17-nikita.shubin@maquefel.me>
Precedence: bulk


--qqO6L1/B8uJqiHh5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 24, 2023 at 03:34:32PM +0300, Nikita Shubin wrote:

> +maintainers:
> +  - Mark Brown <broonie@kernel.org>

This needs to be someone who actually knows about and works on the
device.

> +  use_dma:
> +    type: boolean
> +    items:
> +      - description: Flag indicating that the SPI should use dma

There don't seem to be any DMA properties here, and why would this not
just be done by making them optional rather than having a separate
specific property?

--qqO6L1/B8uJqiHh5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRGpj8ACgkQJNaLcl1U
h9AJmgf+KXQLmqdIYxw937OjV3lA3I+LWg+c5T7eV9/GTC08qMz1dWlkvIAy3C9l
Zf3T7Y8WCHTQIJcAHz/DablFp9op7PMnBk3YMxEH32qr4+JcDyGB4uhloIsj2puf
qc7xycstyS+GhCGHoo9y1FCElIF3xi2XqE//Yg22s4rKnkxabo+ddWDXdT9QlT1D
+CPsKO6yR/b3l6q4N6R6C/I8aXKLwa+muRwek7lETtgvXwPdD4CCe31rT7eCp+GA
KlZWNJ5Kc61LRt+ngTYI92IwwuAXyqWlm5Q9NmMW2PDBmpybWNZmIftxQoJ+gNwf
JS8iUhhQSOSW8DmsoK+oa+RZiorSZg==
=+SnN
-----END PGP SIGNATURE-----

--qqO6L1/B8uJqiHh5--