Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Apr 2023 16:52:25 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Dongliang Mu <dzm91@hust.edu.cn>
Cc:     Li Ningke <lnk_01@hust.edu.cn>,
        hust-os-kernel-patches@googlegroups.com, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: davinci: Remove dead code in `davinci_spi_probe()`
Message-ID: <ed846afc-7155-4998-9a8d-e9d9e8aaf8e2@sirena.org.uk>
References: <20230423032446.34347-1-lnk_01@hust.edu.cn>
 <d29c4b3e-9e82-4ea9-9f0c-a8e2c7637eb9@sirena.org.uk>
 <46299274-d827-279f-cadf-020e93296c13@hust.edu.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tBkIGv79VjVWVg47"
Content-Disposition: inline
In-Reply-To: <46299274-d827-279f-cadf-020e93296c13@hust.edu.cn>
Precedence: bulk


--tBkIGv79VjVWVg47
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 24, 2023 at 08:03:42PM +0800, Dongliang Mu wrote:
> On 2023/4/24 19:48, Mark Brown wrote:

> > Is that check valid?  0 was a valid interrupt for some architectures...

> We just follow the comments of platform_get_irq().

> =A0* Gets an IRQ for a platform device and prints an error message if fin=
ding
> the
> =A0* IRQ fails. Device drivers should check the return value for errors s=
o as
> to
> =A0* not pass a negative integer value to the request_irq() APIs.

I'm not sure that's universally true yet, though there were some moves
to try to get us there.  arm, where this driver is used, was one of the
platforms with 0 as a valid interrupt.

--tBkIGv79VjVWVg47
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRGpbgACgkQJNaLcl1U
h9BKrgf+MzmPQXRI03PbIw/AXJvnq1pmzIhIqF5rxj/MER/k5heQHCXrGVbDSFe0
28ryYegDEM4MUaL3wvTwyNljKdYnovTPzPCxJDXw3lHkDaK8nL9FwC8feNDdvdXH
EmX3xl2huufP+3Gv7ssOcc+QgF3DOd9tPOzQqbm6SvsxnLvTQ/pBWqxeC93R1A5Q
p4PAMpfCUBOQNJ3Qk2DrHCJqZRmLnRUbsh5+8NtC0d6jWsIw3+DCWaEi8JzCT0jc
bvXyR1be46iPOe4MHNPKuW8DMeZN7r2y/u1Si5id9Euz9l8Lk/KLn32CNCdPaQ6U
bBiRLF7fGgKwJmsyckpcqeN9adQXWw==
=Z5Cj
-----END PGP SIGNATURE-----

--tBkIGv79VjVWVg47--