Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <695a4474-9a46-a9ee-2ec5-04dbcb68ca0c@gmail.com>
Date:   Mon, 24 Apr 2023 20:37:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v5 0/4] Remove unused rf_set_sens variable
To:     Yogesh Hegde <yogi.kernel@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <cover.1682358035.git.yogi.kernel@gmail.com>
Content-Language: en-US
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <cover.1682358035.git.yogi.kernel@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/24/23 20:03, Yogesh Hegde wrote:
> The rf_set_sens variable is declared but never set, so it is always NULL.
> Cleanup the unused rf_set_sens variable. Remove functions
> _rtl92e_wx_get_sens and _rtl92e_wx_set_sens which always returned
> error code after removal of rf_set_sens variable.
> Cleanup unused max_sens and sens variable.
> The patches are required to be applied in sequence.
> 
> Changes in v5:
>      1. Rebased onto latest staging-testing branch per feedback from
>         philipp.g.hortmann@gmail.com
> 
> Changes in v4:
>      1. Split changes into patch series per feedback from
>         gregkh@linuxfoundation.org
> 
> Changes in v3:
>      1. Fixed description to fit within 75 chars
>      2. Added suggested tags
>      per feedback from philipp.g.hortmann@gmail.com
> 
> Changes in v2:
>      1. Removed function definition rf_set_sens
>      2. Removed usage of variable priv->rf_set_sens
>      3. Removed functions _rtl92e_wx_get_sens and _rtl92e_wx_set_sens
>      4. Cleaned up the variables sens and max_sens used in these functions
> 
> Changes in v1:
>      1. Fix comparison to NULL of variable rf_set_sens
> 
> Yogesh Hegde (4):
>    staging: rtl8192e: Remove unused rf_set_sens variable
>    staging: rtl8192e: Remove unused _rtl92e_wx_get_sens function
>    staging: rtl8192e: Remove unused _rtl92e_wx_set_sens function
>    staging: rtl8192e: Remove unused sens and max_sens from r8192_priv
>      struct
> 
>   drivers/staging/rtl8192e/rtl8192e/rtl_core.h |  3 --
>   drivers/staging/rtl8192e/rtl8192e/rtl_wx.c   | 45 --------------------
>   2 files changed, 48 deletions(-)
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>