Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0a9c2b8c-1c90-da11-1852-ff29550a7950@amd.com>
Date:   Mon, 24 Apr 2023 16:13:12 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] drm/amd/display: Fix a test CalculatePrefetchSchedule()
Content-Language: en-US
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Pavle Kotarac <Pavle.Kotarac@amd.com>,
        Nevenko Stupar <Nevenko.Stupar@amd.com>,
        Aric Cyr <aric.cyr@amd.com>
Cc:     dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org
References: <13ab79d7a6c7ec6292c803ce1e52c8ac12af320f.1681767298.git.christophe.jaillet@wanadoo.fr>
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <13ab79d7a6c7ec6292c803ce1e52c8ac12af320f.1681767298.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXJNa083T2RhOEQxR1dTMVZQeU5XcHBTcld4ZTI1WERYMkh4bDZTTFBOd0JS?=
 =?utf-8?B?bEhSVFpuRjRxRmFaRlp1c1haZ3hZTkxFaUU1R3lPRUIrQmpvM2JrK2Y5ZGl2?=
 =?utf-8?B?aW54akF1d2xYaVoyZWRUNGExRUJiSkhKajJ2VVNlOVZ2bFNyL2ZmeGpScTVK?=
 =?utf-8?B?SzBnZGR3WllDVFFHNFh4UUVmQkRicjNNNTJjWmowRDFRMWxBRFBHbmFlRFJm?=
 =?utf-8?B?b0VvRStudzVNVDFXeTlSeWdCcUdhUUJDdTNvM1B6cHBlb294S3BhNjM2eVRX?=
 =?utf-8?B?a3p3UUlseTlkYU11RmFxNmdrcFdFdE9EbWpYNXZhdGFaVU92eUd3U09QTnVJ?=
 =?utf-8?B?Kzl2Y1RzV0xPMHZ3QXVFU1A3dm5lNit1TzJia3hJS0VHSXR1ZTdseTdpVVZo?=
 =?utf-8?B?QStBelVKV1F2RHJyUGkxLy9UaWRuR3ptdTFhMWVjbnJhM29qZ3RHdk96MlRN?=
 =?utf-8?B?eHIxRzZ3NmxNeTYxQlE4WDlPWXNSOTlzWDB6WEZmem9PTXpuUWdlOGxZcENj?=
 =?utf-8?B?eE1EVWtDcTNzTHQ0S2hDc0pGaE9qSjlwUnIyelFGUkF5Sk5wU2pmdlN4T2Nq?=
 =?utf-8?B?QzBlbmRieExvTXdwK0lCYU8zQUt3cWZkSUxDYllQa0FPRDZJcmNWQXptOXdQ?=
 =?utf-8?B?YkEyTTV4dFV4N25GekEzRzFQZHBLV29sMmlZMWcwM1VCVE5FRE5ONER6TS9p?=
 =?utf-8?B?R1dRbzErbnJOcnU2MTRyR09IbStNZXdRQmZZN0s0Z1BvQlZYTnFQdFdzMDdL?=
 =?utf-8?B?alBpTFNna21raVNVMzZFZnRmZER0NFJUTzVoeCtuS2xpY09RekZKK0lncDlN?=
 =?utf-8?B?aFpFeDVUYnNkVng4MER4UU93S0hsYkk0TmlFUG1VMW8wTGdDTWVNVGIwbmRI?=
 =?utf-8?B?V0FsSlhsSnhlOUc0VHNFQmQzYUVub1JXY3U3WmNOcHEya21BWlM1ZEhLNnVv?=
 =?utf-8?B?OVdZQlhqcVl1TnZqT2hBZkk3d1lBWkZOcXd0bnI4WGg1OGx1M3U0MXlrdVo2?=
 =?utf-8?B?NFVTODhUT0tBQlZWM2twY1hkSkllYUJFMjF5K010VkdmMFJXRnVFR1lRWUps?=
 =?utf-8?B?WmtXaGE3L2YvUHJwbUhnUnJTQkFoVzNQSkI1MEhjS3EybEhBbXE4N1dNTCtk?=
 =?utf-8?B?QkJpbEVMdUpQd0M5bkZwWmFsT3I2YUVwRGgwUVRVWEtHdDRrNjJ1N0JhU1dt?=
 =?utf-8?B?ZFhHMG1ldjdZVzFGNWJMaFFTVnlCdkJUU1hYNVVHNlpPdWZuWXozT1dsTGIz?=
 =?utf-8?B?Mzc1aW5HOStUT3VraVBuekFCSXJ6cnZOZWVYcnQ4Y1hxdThrTklHaVVuaWNZ?=
 =?utf-8?B?bkZkb0hHd1I5N1VIVGhyMFNHNzM1d096bU4wbmtoZGovdEMrQm44K1BDN2VI?=
 =?utf-8?B?a3BXS1lZd2FUODZ1cEtvNGRiMGZRRHhiKzdBckhwNTVvSldkMENCYzNWUmh5?=
 =?utf-8?B?ZHdIZHdFQlNoc21LaFB4OWEyQ0hkZHk4Sks1OXV3THVTQlFsWWN2UmswaXlp?=
 =?utf-8?B?ek5CWjVNQ2hpY2crVTRoekZ1aXZlWlFDNkc1WnZCQkFkWDZNZHFxMTNCNkRq?=
 =?utf-8?B?MXFib1grbFRTb0s2Uy9ESDVFZnphZkkzUFd2T285VlNTWlJLVWZJWXYxUy8r?=
 =?utf-8?B?L1d0UUdUS1dFb2x5c3JCc1IxYyszVmpBcVloaXdUY21zMWxXY2J0OWVBRFZN?=
 =?utf-8?B?QVJKNUdIUW9ad0xmTEE3VW5WdFM0d0haaTZkY010OGg5N2Z2RG9CVWl4eGNP?=
 =?utf-8?B?cDRzV0RpYmVLNzFTTGJjbTh2VXA2R0N1QjJOd09HL08xbkZmZzBwL2NQS1Nk?=
 =?utf-8?B?VEZKa3FOdUQ2Wlhza2t3T1ZVL2tRV3lBalNVQTk4a1hkWVdPeFJWbGxGd1Br?=
 =?utf-8?B?eUh0T0Y5ZXVUckZSKytCMW5QdmpzOEJNTTZ1Nm1sZjZaSjRnMVF4bXVxN2NR?=
 =?utf-8?B?NjVhSVZzTHMwTzBEN2F3RjJ1NERPSE5FS3NCNS95ZWxyaDUwdHROcXdBUUd6?=
 =?utf-8?B?M2cwWlhMTm01eTliZVJ3MjVZaE5UZkcvYms5eko1OEg1T2ptMlB5SlJaOEto?=
 =?utf-8?B?TUdITlBzd3UxQmQ5Y01OK1FOdmVIRStBVzM5SFFrRU5CRHF0Nllpd2VraDZj?=
 =?utf-8?Q?6rmDe4PfSsBm1SODCVI6zUPVk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56e9a946-d85f-406b-bc4b-08db450021c9
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2023 20:11:47.4682
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tPcOlI2R7GARgrxAR040m9KVVtgcKMQIjuoLhzIUzq7kHrUqNXPNqRmNU9BvWMv6sTtmDZUNEIwKtH0bKKsSAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7072
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/17/23 17:35, Christophe JAILLET wrote:
> It is likely Height was expected here, instead of Width.
> 
> Test the correct variable.
> 
> Fixes: 17529ea2acfa ("drm/amd/display: Optimizations for DML math")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c b/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c
> index b7c2844d0cbe..f294f2f8c75b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c
> @@ -810,7 +810,7 @@ static bool CalculatePrefetchSchedule(
>   			*swath_width_chroma_ub = dml_ceil(SwathWidthY / 2 - 1, myPipe->BlockWidth256BytesC) + myPipe->BlockWidth256BytesC;
>   	} else {
>   		*swath_width_luma_ub = dml_ceil(SwathWidthY - 1, myPipe->BlockHeight256BytesY) + myPipe->BlockHeight256BytesY;
> -		if (myPipe->BlockWidth256BytesC > 0)
> +		if (myPipe->BlockHeight256BytesC > 0)
>   			*swath_width_chroma_ub = dml_ceil(SwathWidthY / 2 - 1, myPipe->BlockHeight256BytesC) + myPipe->BlockHeight256BytesC;
>   	}
>   
-- 
Hamza