Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230420165454.9517-1-jorge.lopez2@hp.com> <20230420165454.9517-2-jorge.lopez2@hp.com>
 <dc902d52-7186-4095-9be9-60c728a24f05@t-8ch.de> <CAOOmCE-N9yMn7Cvr9bK5TpAwpv7_Lam1huWRrYaFzXVtf4v_aA@mail.gmail.com>
 <80c448f8-f043-460a-908f-e87e6b8215dc@t-8ch.de>
In-Reply-To: <80c448f8-f043-460a-908f-e87e6b8215dc@t-8ch.de>
From:   Jorge Lopez <jorgealtxwork@gmail.com>
Date:   Mon, 24 Apr 2023 16:35:16 -0500
Message-ID: <CAOOmCE8jYZ=dt9r47Vo3LPb0c8DOhK31-998S9ZCp0nPN3jcvg@mail.gmail.com>
Subject: Re: [PATCH v11 01/14] HP BIOSCFG driver - Documentation
To:     =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <thomas@t-8ch.de>
Cc:     hdegoede@redhat.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Thomas,

On Mon, Apr 24, 2023 at 3:52=E2=80=AFPM Thomas Wei=C3=9Fschuh <thomas@t-8ch=
.de> wrote:
>
> Hi Jorge,
>
> On 2023-04-24 11:11:41-0500, Jorge Lopez wrote:
> > On Sat, Apr 22, 2023 at 3:51=E2=80=AFPM Thomas Wei=C3=9Fschuh <thomas@t=
-8ch.de> wrote:
> > >
> > > On 2023-04-20 11:54:41-0500, Jorge Lopez wrote:
> > > > Based on the latest platform-drivers-x86.git/for-next
> > > > ---
> > > >  .../testing/sysfs-class-firmware-attributes   | 98 +++++++++++++++=
+++-
> > > >  1 file changed, 96 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/Documentation/ABI/testing/sysfs-class-firmware-attribu=
tes b/Documentation/ABI/testing/sysfs-class-firmware-attributes
> > > > index 4cdba3477176..73d7b8fbc0b2 100644
> > > > --- a/Documentation/ABI/testing/sysfs-class-firmware-attributes
> > > > +++ b/Documentation/ABI/testing/sysfs-class-firmware-attributes
> > > > @@ -22,6 +22,12 @@ Description:
> > > >                       - integer: a range of numerical values
> > > >                       - string
> > > >
> > > > +             HP specific types
> > > > +             -----------------
> > > > +                     - ordered-list - a set of ordered list valid =
values
> > > > +                     - sure-start - report audit logs read from BI=
OS
> > >
> > > In the treevie you sent the Sure_Start attribute does not have
> > > a "current_value".
> > > This indicated that it's not actually a firmware attribute but just s=
ome
> > > standalone sysfs attribute.
> > >
> > > In this case it should not be documented here, but handled the same w=
ay
> > > as the SPM stuff.
> >
> > I will update the documentation as indicated.
>
> This will also need changes to the code.
> Only the audit log stuff is needed then.

Ok.  Sure_Start will only report two entries; audit_log_entries and
audit_log_entry_count.
Other entries such display_name, type and display_name_language will be rem=
oved