Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp6170954rwr; Mon, 24 Apr 2023 15:07:52 -0700 (PDT) X-Google-Smtp-Source: AKy350YgvOL5hpjQuumlc8gba0W60CSn2IEUX7wapYru26vI+Izedrd33wS9/DZN+LN7MKPcz/B1 X-Received: by 2002:a17:90a:c381:b0:23f:3f9c:7878 with SMTP id h1-20020a17090ac38100b0023f3f9c7878mr14027336pjt.2.1682374072607; Mon, 24 Apr 2023 15:07:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682374072; cv=none; d=google.com; s=arc-20160816; b=HQNFVKbjJDuQaHIzv0GK7lH8HucSdh+9cZGO1gjc3H9tJuicFvYFWhDpFag8C3Hmn4 t2rzieGnZyAlmT+rRmsF853Ehc2i/Yj59SBynn9Dakyu6d0bOTwLluWA8Mc82DeetXQJ Il+rD4zs6mUHLcAx+VxxZv9XFGpACYaeABk+Qsc1Br7iDzDtohr3Cbr8TFbjfPOSEOw1 gxbG569meZ7dk/HsYN3CM036A4CtEi6kVeWUQgobH4z7fJTFDefZ4bVVaJlujOMn7vxO g6PAJCzyFElrFTAORQgn1lNsRDznWERLvDTgxK3kt8yQfqHi4j9nBjwn8lkG4muy4fd4 f02w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=wHrpnt0jCYeXvbapotDCi3Lhc3GhFee6Db5xBHC/Vcs=; b=OaK3lIzDlkpmPIHt9AYNDSwtieAm/+xIINERVY77uiQeKbTegAZqVQB9+8lF/aU5Fm V2GXb+UjNyoGLlSVWilRwy9T2AadE1dowbcDWuuetE3A5mCjmVt4d8cAE0uQPdr8+thv 1U0O9csLEItYv4suLx24+utGGrSYtzaMirDqofknAg1hBIIV796jtDQCfbS2QKnV5lmY zZu/SNpL70lcqbI9RK992bioHwXBP7GIIaImWeu4yyGhRX3ePoaj/sWqDxSwwa9Eao5E tqHkSzylX6VsJxOQoFY8na+jZkc1oI4u3xjnYUGSZptXv4llIMcDeGjfvDWxyn5IejX+ Mu3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XxFxtTA1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l7-20020a170903244700b0019b7766afdfsi8672726pls.626.2023.04.24.15.07.29; Mon, 24 Apr 2023 15:07:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XxFxtTA1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233119AbjDXWF7 (ORCPT + 99 others); Mon, 24 Apr 2023 18:05:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231134AbjDXWF5 (ORCPT ); Mon, 24 Apr 2023 18:05:57 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 289331B9; Mon, 24 Apr 2023 15:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682373956; x=1713909956; h=from:subject:date:message-id:mime-version: content-transfer-encoding:to:cc; bh=C8DZu5U/wSsVYc+CLUrWxHLYcsvk8ZOLg8rYgW7chsg=; b=XxFxtTA1MqpjtILnH/ot2pc1MyxWPoniYkDxtc/uCJRxuDmLLNzSCa4d xGBW9a+v0UJMUmfUhqLn1p9uD0Tvhd4gVgSbGgqaaqVWTH4cgo0Zc+5/O 3obGuJufeao2Vux7f1HOdyCQT80pG3/aP8UGu1adaTTYS81TQzZ68OSEG Ok2u9OOutP8Phx6EaugDnaUDQ2xJ2KXWtwJp3eC4qMgGGQIejkv1eOwPR DO/OB2nUIJHgD5K4fuCM6/LOMWMEcEaxdpzv0w0RtngU8Mbsw7mkQ+uad fv9NOAZdpMjRbierHcUzmHTegY80rkTcd5hySEDINhW4Rs/mDXcbtMOB5 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="335473627" X-IronPort-AV: E=Sophos;i="5.99,223,1677571200"; d="scan'208";a="335473627" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 15:05:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="939500105" X-IronPort-AV: E=Sophos;i="5.99,223,1677571200"; d="scan'208";a="939500105" Received: from lab-ah.igk.intel.com ([10.102.138.202]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 15:05:49 -0700 From: Andrzej Hajda Subject: [PATCH v8 0/7] drm/i915: use ref_tracker library for tracking wakerefs Date: Tue, 25 Apr 2023 00:05:38 +0200 Message-Id: <20230224-track_gt-v8-0-4b6517e61be6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIADL9RmQC/3XOTW7DIBAF4KtErEsLGAPpqveoogqGIUatfwTEa hX57oWsKqtevtF88+ZOMqaImbye7iThGnOcpxrM04nAYKcr0uhrJoKJjgkhaUkWPj+uhXLXeWuc t+A1qevOZqQu2QmGBm5LLgnt+OLTSEtc2sqSMMTvR9v7peYh5jKnn0f5ytv0n56VU0brSLCzCuB BvcWp4NczzCNpR1Z5BGWFUkk01kk4W7eH/RHsK9TaoVFBgNFiD9URVO1VD0YxHjwTYQ/1EdQVch 6Y6XoDHOEv3LbtF8y48qenAQAA To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Eric Dumazet Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Chris Wilson , netdev@vger.kernel.org, Jakub Kicinski , Dmitry Vyukov , "David S. Miller" , Andi Shyti , Andrzej Hajda X-Mailer: b4 0.11.1 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is revived patchset improving ref_tracker library and converting i915 internal tracker to ref_tracker. The old thread ended without consensus about small kernel allocations, which are performed under spinlock. I have tried to solve the problem by splitting the calls, but it results in complicated API, so I went back to original solution. If there are better solutions I am glad to discuss them. Meanwhile I send original patchset with addressed remaining comments. To: Jani Nikula To: Joonas Lahtinen To: Rodrigo Vivi To: Tvrtko Ursulin To: David Airlie To: Daniel Vetter To: Eric Dumazet Cc: linux-kernel@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: Chris Wilson Cc: netdev@vger.kernel.org Cc: Jakub Kicinski Cc: Dmitry Vyukov Cc: "David S. Miller" Cc: Andi Shyti Cc: Das, Nirmoy Signed-off-by: Andrzej Hajda --- Changes in v8: - addressed comments from Eric, Zhou and CI, thanks, - added ref_tracker_dir_init name argument to all callers in one patch - moved intel_wakeref_tracker_show to *.c - s/intel_wakeref_tracker_show/intel_ref_tracker_show/ - removed 'default n' from Kconfig - changed strlcpy to strscpy, - removed assignement from if condition, - removed long lines from patch description - added tags - Link to v7: https://lore.kernel.org/r/20230224-track_gt-v7-0-11f08358c1ec@intel.com Changes in v7: - removed 8th patch (hold wakeref), as it was already merged - added tags (thx Andi) - Link to v6: https://lore.kernel.org/r/20230224-track_gt-v6-0-0dc8601fd02f@intel.com Changes in v6: - rebased to solve minor conflict and allow CI testing - Link to v5: https://lore.kernel.org/r/20230224-track_gt-v5-0-77be86f2c872@intel.com Changes in v5 (thx Andi for review): - use *_locked convention instead of __*, - improved commit messages, - re-worked i915 patches, squashed separation and conversion patches, - added tags, - Link to v4: https://lore.kernel.org/r/20230224-track_gt-v4-0-464e8ab4c9ab@intel.com Changes in v4: - split "Separate wakeref tracking" to smaller parts - fixed typos, - Link to v1-v3: https://patchwork.freedesktop.org/series/100327/ --- Andrzej Hajda (7): lib/ref_tracker: add unlocked leak print helper lib/ref_tracker: improve printing stats lib/ref_tracker: add printing to memory buffer lib/ref_tracker: remove warnings in case of allocation failure drm/i915: Correct type of wakeref variable drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library drm/i915: Track gt pm wakerefs drivers/gpu/drm/i915/Kconfig.debug | 18 ++ drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 7 +- .../drm/i915/gem/selftests/i915_gem_coherency.c | 10 +- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 14 +- drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 13 +- drivers/gpu/drm/i915/gt/intel_breadcrumbs_types.h | 3 +- drivers/gpu/drm/i915/gt/intel_context.h | 4 +- drivers/gpu/drm/i915/gt/intel_context_types.h | 2 + drivers/gpu/drm/i915/gt/intel_engine_pm.c | 7 +- drivers/gpu/drm/i915/gt/intel_engine_types.h | 2 + .../gpu/drm/i915/gt/intel_execlists_submission.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 12 +- drivers/gpu/drm/i915/gt/intel_gt_pm.h | 38 +++- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 +- drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 20 +- drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 5 +- drivers/gpu/drm/i915/gt/selftest_reset.c | 10 +- drivers/gpu/drm/i915/gt/selftest_rps.c | 17 +- drivers/gpu/drm/i915/gt/selftest_slpc.c | 5 +- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 12 +- drivers/gpu/drm/i915/i915_driver.c | 2 +- drivers/gpu/drm/i915/i915_pmu.c | 16 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 221 ++------------------- drivers/gpu/drm/i915/intel_runtime_pm.h | 11 +- drivers/gpu/drm/i915/intel_wakeref.c | 35 +++- drivers/gpu/drm/i915/intel_wakeref.h | 73 ++++++- include/linux/ref_tracker.h | 25 ++- lib/ref_tracker.c | 179 ++++++++++++++--- lib/test_ref_tracker.c | 2 +- net/core/dev.c | 2 +- net/core/net_namespace.c | 4 +- 32 files changed, 445 insertions(+), 332 deletions(-) --- base-commit: 4d0066a1c0763d50b6fb017e27d12b081ce21b57 change-id: 20230224-track_gt-1b3da8bdacd7 Best regards, -- Andrzej Hajda