Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0ee62e42-2a9d-789c-86ad-8f92b08b31ac@arm.com>
Date:   Mon, 24 Apr 2023 23:26:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: [PATCH] coresight: core: Add coresight name support
To:     Jinlong Mao <quic_jinlmao@quicinc.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Rob Herring <robh@kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>
Cc:     coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        Tingwei Zhang <quic_tingweiz@quicinc.com>,
        Yuanfang Zhang <quic_yuanfang@quicinc.com>,
        Tao Zhang <quic_taozha@quicinc.com>,
        Hao Zhang <quic_hazha@quicinc.com>
References: <20230208110716.18321-1-quic_jinlmao@quicinc.com>
 <3c105c79-f523-653e-5154-7ba641e51a96@arm.com>
 <180a66b1-6996-c705-5d8a-0a69ce0353d7@quicinc.com>
 <b7abee2a-99ca-26d6-5850-60ee19d9c0e9@quicinc.com>
 <619818ad-71cb-6c07-bcae-ea9398f08878@arm.com>
 <6b976d2b-3c78-96e4-bf35-3ef88828a9dd@quicinc.com>
 <f5a1d873-8aa0-ea11-28df-8857fc256862@arm.com>
 <a9d4e5d1-0e1f-13b5-cf3a-464e61594990@quicinc.com>
From:   Suzuki K Poulose <suzuki.poulose@arm.com>
In-Reply-To: <a9d4e5d1-0e1f-13b5-cf3a-464e61594990@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 24/04/2023 14:42, Jinlong Mao wrote:
> On 3/17/2023 10:25 PM, Suzuki K Poulose wrote:
> 
>> On 17/03/2023 05:34, Jinlong Mao wrote:
>>>
>>> On 3/13/2023 5:16 PM, Suzuki K Poulose wrote:
>>>> Cc: Rob
>>>>
>>>> On 01/03/2023 15:11, Jinlong Mao wrote:
>>>>> Hi Suzuki,
>>>>>
>>>>> On 2/9/2023 10:16 AM, Jinlong Mao wrote:
>>>>>>
>>>>>> On 2/8/2023 10:26 PM, Suzuki K Poulose wrote:
>>>>>>> On 08/02/2023 11:07, Mao Jinlong wrote:
>>>>>>>> Apart from STM and ETM sources, there will be more sources added to
>>>>>>>> coresight components. For example, there are over 10 TPDM sources.
>>>>>>>> Add coresight name support for custom names which will be
>>>>>>>> easy to identify the source.
>>>>>>>>
>>>>>>>
>>>>>>> As we have previously discussed, please don't make this a generic
>>>>>>> code change. If your device has a "specifici" name, use that for
>>>>>>> allocating in the driver and leave the core code alone.
>>>>>>>
>>>>>>> Suzuki
>>>>>>>
>>>>>> Hi Suzuki,
>>>>>>
>>>>>> Not only for TPDMs. There could be dozens of CTI devices.
>>>>>> It is hard for user to know which CTI device it is with current 
>>>>>> names.
>>>>>>
>>>>>> Thanks
>>>>>> Jinlong Mao
>>>>>
>>>>> The coresight name support is applicable to CTI and TPDM devices.
>>>>> This is a generic change for the source which has dozens of devices.
>>>>
>>>> I took a look at the CTI situation and I agree that the situation
>>>> is a bit tricky. The CTI could be connected to multiple devices,
>>>> some of them may not be even CoreSight devices. Given there could
>>>> be numerous of them, we need some way to make the "devices" naming
>>>> a bit more intuitive.
>>>>
>>>> Before we go ahead and add something specific to coresight, I would
>>>> like to see if there is a generic property. Ideally, the "labels"
>>>> in the DTS sources would have been an ideal choice, but can't
>>>> see how that is available in the FDT.
>>>>
>>>> Suzuki
>>> Hi Suzuki,
>>>
>>> Shall we use the full_name of device_node struct as coresight 
>>> component's name ?
>>>
>>>    struct device_node {
>>>      const char *name;
>>>      phandle phandle;
>>> *    const char *full_name;
>>>
>>> *For component below, the full_name will be "coresight-tpdm-ipcc".
>>> *
>>> **coresight-tpdm-ipcc* {
>>
>> Does that go against the convention of naming the DT nodes ?
>> I am not sure. Also, we would need a way to solve this for ACPI too.
>>
>> Suzuki
> Hi Suzuki,
> 
> Does ACPI device also use "coresight_alloc_device_name" to get the 
> device's name ?

All driver code is common for both DT & ACPI. The only difference is
the coresight_get_platform_data() which uses DT vs ACPI information
and populates the platform_data.  See coresight-platform.c.

Suzuki