Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Jeff Layton" <jlayton@kernel.org>
Cc:     "Alexander Viro" <viro@zeniv.linux.org.uk>,
        "Christian Brauner" <brauner@kernel.org>,
        "Darrick J. Wong" <djwong@kernel.org>,
        "Hugh Dickins" <hughd@google.com>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        "Dave Chinner" <david@fromorbit.com>,
        "Chuck Lever" <chuck.lever@oracle.com>, "Jan Kara" <jack@suse.cz>,
        "Amir Goldstein" <amir73il@gmail.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-mm@kvack.org,
        linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 1/3] fs: add infrastructure for multigrain inode i_m/ctime
In-reply-to: <404a9a8066b0735c9f355214d4eadf0d975b3188.camel@kernel.org>
References: <20230424151104.175456-1-jlayton@kernel.org>,
 <20230424151104.175456-2-jlayton@kernel.org>,
 <168237287734.24821.11016713590413362200@noble.neil.brown.name>,
 <404a9a8066b0735c9f355214d4eadf0d975b3188.camel@kernel.org>
Date:   Tue, 25 Apr 2023 08:40:19 +1000
Message-id: <168237601955.24821.11999779095797667429@noble.neil.brown.name>
Precedence: bulk

On Tue, 25 Apr 2023, Jeff Layton wrote:
> On Tue, 2023-04-25 at 07:47 +1000, NeilBrown wrote:
> > On Tue, 25 Apr 2023, Jeff Layton wrote:
> > > +	/*
> > > +	 * Warn if someone sets SB_MULTIGRAIN_TS, but doesn't turn down the ts
> > > +	 * granularity.
> > > +	 */
> > > +	return (sb->s_flags & SB_MULTIGRAIN_TS) &&
> > > +		!WARN_ON_ONCE(sb->s_time_gran == 1);
> > 
> >  Maybe 
> > 		!WARN_ON_ONCE(sb->s_time_gran & SB_MULTIGRAIN_TS);
> >  ??
> > 
> 
> I'm not sure I understand what you mean here.

That's fair, as what I wrote didn't make any sense.
I meant to write:

 		!WARN_ON_ONCE(sb->s_time_gran & I_CTIME_QUERIED);

to make it explicit that s_time_gran must leave space for
I_CTIME_QUERIED to be set (as you write below).  Specifically that
s_time_gran mustn't be odd. 
  
>                                                We want to check whether
> SB_MULTIGRAIN_TS is set in the flags, and that s_time_gran > 1. The
> latter is required so that we have space for the I_CTIME_QUERIED flag.
> 
> If SB_MULTIGRAIN_TS is set, but the s_time_gran is too low, we want to
> throw a warning (since something is clearly wrong).
> 

NeilBrown