Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c428d3a4466b1a608e3e8b2434e8d5d9.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230421-clk-v1-1-bb503f2f2cf3@outlook.com>
References: <20230421-clk-v1-1-bb503f2f2cf3@outlook.com>
Subject: Re: [PATCH] clk: use ULONG_MAX as the initial value for the iteration in clk_mux_determine_rate_flags()
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        Yang Xiwen <forbidden405@outlook.com>
To:     Michael Turquette <mturquette@baylibre.com>,
        Yang Xiwen via B4 Relay 
        <devnull+forbidden405.outlook.com@kernel.org>,
        forbidden405@outlook.com
Date:   Mon, 24 Apr 2023 18:24:44 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Yang Xiwen via B4 Relay (2023-04-21 08:56:38)
> From: Yang Xiwen <forbidden405@outlook.com>
>=20
> Currently, clk_mux_determine_rate_flags() use 0 as the initial value for
> selecting the best matching parent. However, this will choose a
> non-existant rate(0) if the requested rate is closer to 0 than the
> minimum rate the parents have.
>=20
> Fix that by initializing the initial value to ULONG_MAX and treat it as a
> magic number.

Can you add a unit test to clk_test.c as well?