Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Tom Rix <trix@redhat.com>
Cc:     brking@us.ibm.com, jejb@linux.ibm.com, martin.petersen@oracle.com,
        john.g.garry@oracle.com, dlemoal@kernel.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ipr: remove several unused variables
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1wn20k638.fsf@ca-mkp.ca.oracle.com>
References: <20230420125035.3888188-1-trix@redhat.com>
Date:   Mon, 24 Apr 2023 23:12:52 -0400
In-Reply-To: <20230420125035.3888188-1-trix@redhat.com> (Tom Rix's message of
        "Thu, 20 Apr 2023 08:50:35 -0400")
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWN1dHVKd2dzTWsyb3hScjhQakZwbGJsNWVua255VGFjejR5VUlNQi9VZ2x2?=
 =?utf-8?B?bWVMbFBPZGh5TkFGTlZhVnQ3bFF6b2ZiR1lqcHdhZGdidG1zSU9MdGNvaERS?=
 =?utf-8?B?TWpMbWczR3d5dkh5UE5ZVmdXc1RxTFh4K1c3Q1pDVk9zTFVrd05OL0xESGp2?=
 =?utf-8?B?TElmOUc2Nm50RWF0Tm1wbmh3UUF6YTNSN2JLc0VWQXRZa3hVZzc0QTVpeXZL?=
 =?utf-8?B?TmpaU2E2WmNCcVp1Ymg0TUgxMm13bWE3a2oyNVFtdjFMa0VPWUo2QjdYRlZ0?=
 =?utf-8?B?YlhSNG1tL3JJckl1eWdPWktzU3BTOCtEU1pRd1FGM3k0cmxGQ21hR083MjA0?=
 =?utf-8?B?Ly84UUZha1A0VDZaVUx4VkI2dGRsazNPMm51Ni9kWExYMlAwbktRZ09wdmc0?=
 =?utf-8?B?Yzd0TUJtVFZIR3NRQ0cvSVRiTEJhYWlXcWZpUTNxdDVFYUdOQVJhb3FkaTlI?=
 =?utf-8?B?dDNuNXR5QkhVVi92WDhwODFHRUNwNnJwRTc5RHhqcmx3RUFzOWxjbG5xaElm?=
 =?utf-8?B?K0hxSEFOQ3AwNlhQaWpwUDB3RXRuUEQrc3RrRlAxUmpkYWFIN21FeUQzMzcx?=
 =?utf-8?B?ZTZIV0RhczlkTFlsVjF0VTNyS29ZN2Q4S0Y5WUlsMjdGMXVkbmRpdzBLVmh3?=
 =?utf-8?B?bEtZYWc2cFk4czlXVkUzY2lONm4rWkVoSzQxVnJiSUJLZ08yK3hhK0tSUTA3?=
 =?utf-8?B?REh1QXh4UnhIRkN3eThkSTR1d20wenNwWVJ2aUVnUU5MYWxnQnJWZ3VOZVlv?=
 =?utf-8?B?dUszU2EyM3JOSzB2RytWK1lzWEkvRzlyVHpSbDFDMDJMNGVFclZTRXl6YjRS?=
 =?utf-8?B?aVJqbHZ4YmlZalJFSDk2Z2xCU3JSemcxSmRPcXYrcnBUMGxOTGxkeC9qam9a?=
 =?utf-8?B?K2FRdlNVK2VlUXA1OW0zYWRHdnM0MHVJdy9rSlp5RUI1Ym5mSDN6TXpPSUR0?=
 =?utf-8?B?ZnErcDlEMkIrL08zM0dFRUNKTG0yMXZrcWh0cTRXZTNESVU0ajkxS0o5S216?=
 =?utf-8?B?RzdWdWVXc2JjRTgzYXUzK05hbGxmVTFhaEZmYXBRMVNjMklGNk91dk4rNzIx?=
 =?utf-8?B?VWlITXRPd0RrZEFiM0h3VE1Rdkdxa3VlL3BqNjg3SlZwbGVMdXNILzNWR0Z4?=
 =?utf-8?B?WlNYZCttVlhubDRxR1ZPTTBUVmdnRjNnczZXTHlleGNMeUhFd2hTQzdyOEJq?=
 =?utf-8?B?MnNySjJuYXRCU2hIQjdNN1FKd1dkejdGUjRoclNSR3hJTlFBU0l1UndUdEpw?=
 =?utf-8?B?eUt4VjU3MERrSDljeHBtck54dWVEUHl6WUgwWHFjSGlnWWRZNWhGYUNWdW55?=
 =?utf-8?B?RVFLeGQxRk9wUC8rYkFNSzJsNkowcFR1Rk5OejBzckRSZ1A3U2J3ZTBzZHNt?=
 =?utf-8?B?RVFiZjRya1pEbHVHZ1N4YjRmcndEVkFtKy9OM0FxNThIcjFwOTFick1BcFZQ?=
 =?utf-8?B?M3B5OWl6NlkwTDBKQ2lNK3hXSldkT1llSGpFemsyZG9zTjdFRGhNdFNmeGpj?=
 =?utf-8?B?a3hPM0pFTmlOVEI4ckhPRjBKS0ppSGt4UkVGcFFRa1prU0VRWmpBRFc2ZW5w?=
 =?utf-8?B?dHNrTThQOUY2dFVUaVBrU0FuTlVmVlU1b2Rmc1l3a1JpaTBOZUlhL0xLblFX?=
 =?utf-8?B?c2V5azBtZDMvRnpuRncvMFQ2NWd6ME9SRkI1dE9pdjJkQzFmVG12MkdzUzZC?=
 =?utf-8?B?NndVZGxuaFI5SjdIU3V3VURzQ1FvQTN5UHAyTEZ5cm92d2Z5bkxNUmQ5Tytw?=
 =?utf-8?B?dUdPcmJVVVlhNzgzWk5XSGtwNDVTbWdaQS8vVzZtamtNeWpvS2lveFdpV2ls?=
 =?utf-8?B?eVNac1pjWWlkSEFaWjN2bFRtTXJGc08xZEUvcTJPSmg3eVJRU3VRWVBlQ3RW?=
 =?utf-8?B?Y053NmxiMjlZSkZFM0s4dHhvbFQxUEhJMkt5K3pCZmdmMjFXRzBPSFcvZTdl?=
 =?utf-8?B?ckcvNTM0TzVVelV6Z28wZ0tHTEFWRCtlK0pPQzZMQ1ljVUMwZ2pDelpRWVVW?=
 =?utf-8?B?eWlPNTlGM0kxU1B5NzBzZDdZU2ZjZVdFNWFEZXNYL3ZHSC9QWVpyVm5RUmN0?=
 =?utf-8?B?Q2NkdTZTUk0xdFNybVd0SDdpR094NXMzSFczM3BzVEFUMGNsWm5DaW5Vc1V5?=
 =?utf-8?B?VXoyNHAxempzNUFWZmorRVppM1V2eU5XV2JBQ3kzanN2V0Vyays1QUZWempa?=
 =?utf-8?B?ZUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fPz7Ikx22EcIZZjs4dnPc39ErNCuwzx5wE9a1ePZgyPxTVIOFyV80T9XoX81FW5CT5KhXED+7UxHz+ORr0sH3dfex0xumwvL5MZCyk078rQGpTuNcSWgBjUudNjhydyX79d0iUX8MTDKlGE7RHV/wxfpyIJXn18JXSwumR1Z6ezBvTGMmyTTLEaPV+3b4ja6rONgmlOK0ikDDJIEib1pRb93VGr28bhT23zC7CHvywpldXNNQkEAXBjsFc73is1NrXbnoOS/ma+rzbWRa+cc9dJuhsbKYMq75hpcpg+pFK6vyg+GrzVWd2i9UaKUXbVvUn4T3SOil+3C9omAwWvDXduuU2vAIDG48vdwnaqiLdmNBu8gwBGakAHFxoD6NNz+8ydA46k6R655uVsZrKJXZs15Gmm0jWUrh0UYkxPq5XU3OlR4dHB57JpaWXhLPjYy/2zbAHXMINugpRzpaYlaWPQe2kamrqXrJs9AcApeMOgTDnfUOd4xk5JM6AHx1dZWV2WZLDIgB7WgovRdunRfMA9zaEOTKoiTvxd7dcxgcUMAfNgCxgmSCOCxu88P9p96z77aH1ASyvnd/yPaDg+1kDVua3l4SkK6+HDOwLdGNkAjh/Bx/cR3cfhp/B3DzazJryc4slD5BFhTweuAoZPg+sbuNmaASoCY5MaIUclEBezsveKvsSpOqskUyzN4LcYAdtlJVw0vBQYHW3MPtSPnepifddE2JkgyNDjP7QKCuQ2fJ1sYz5ykC88KZpslswc1ZYsg6NZcfe7l/SZnV+vXySl523Npibc5jFDSgi9ehmWIbOMc83aKAQ1nNAlZJVwmTQ3y8oQGa6+zEb4FzKE/gRO6jIu0K7fD3wN4K5YfRVrqNNWi3xkNJ8miUNSO1MQj
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ccabc4b4-bc06-475f-6e46-08db453af61b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 03:12:54.4313
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZeKkSAlsbaGJj8q2oaN0wx7yfMaHz6g8FXbOp/Y2EodNFL4+DlhDEPoxIDrzVL8z29jqK3jibnX+EEvcsyNk9J2yL0i9RdU4UFAeaD8aWhk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4152
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-25_02,2023-04-21_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 malwarescore=0 mlxscore=0 adultscore=0 suspectscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304250028
X-Proofpoint-ORIG-GUID: K9XF2b1xAZURhNNeU0IVqE2GxdOAe1_t
X-Proofpoint-GUID: K9XF2b1xAZURhNNeU0IVqE2GxdOAe1_t
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Tom,

> gcc with W=3D1 reports
> drivers/scsi/ipr.c: In function =E2=80=98ipr_init_res_entry=E2=80=99:
> drivers/scsi/ipr.c:1104:22: error: variable =E2=80=98proto=E2=80=99
>   set but not used [-Werror=3Dunused-but-set-variable]
>  1104 |         unsigned int proto;
>       |                      ^~~~~
> drivers/scsi/ipr.c: In function =E2=80=98ipr_update_res_entry=E2=80=99:
> drivers/scsi/ipr.c:1261:22: error: variable =E2=80=98proto=E2=80=99
>   set but not used [-Werror=3Dunused-but-set-variable]
>  1261 |         unsigned int proto;
>       |                      ^~~~~
> drivers/scsi/ipr.c: In function =E2=80=98ipr_change_queue_depth=E2=80=99:
> drivers/scsi/ipr.c:4417:36: error: variable =E2=80=98res=E2=80=99
>   set but not used [-Werror=3Dunused-but-set-variable]
>  4417 |         struct ipr_resource_entry *res;
>       |                                    ^~~
>
> These variables are not used, so remove them.
> The lock around res is not needed so remove that.
> Which makes ioa_cfg and lock_flags unneeded so remove them.

Applied to 6.4/scsi-staging, thanks!

--=20
Martin K. Petersen	Oracle Linux Engineering