Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Alice Chao <alice.chao@mediatek.com>
Cc:     Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        Bart Van Assche <bvanassche@acm.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Can Guo <quic_cang@quicinc.com>,
        Asutosh Das <quic_asutoshd@quicinc.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Manivannan Sadhasivam <mani@kernel.org>,
        <peter.wang@mediatek.com>, <chun-hung.wu@mediatek.com>,
        <powen.kao@mediatek.com>, <naomi.chu@mediatek.com>,
        <cc.chou@mediatek.com>, <chaotian.jing@mediatek.com>,
        <jiajie.hao@mediatek.com>, <tun-yu.yu@mediatek.com>,
        <eddie.huang@mediatek.com>, <wsd_upstream@mediatek.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v3 1/1] scsi: ufs: core: Fix &hwq->cq_lock deadlock issue
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1r0s8k5sn.fsf@ca-mkp.ca.oracle.com>
References: <20230424080400.8955-1-alice.chao@mediatek.com>
Date:   Mon, 24 Apr 2023 23:19:30 -0400
In-Reply-To: <20230424080400.8955-1-alice.chao@mediatek.com> (Alice Chao's
        message of "Mon, 24 Apr 2023 16:03:56 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NOc9HimwnVRSIRNemPCmrDy3znLa+wQYS+FCUImjWiKKwB2F1nkRFmghildK?=
 =?us-ascii?Q?o4Ofd+pG8B2+Ae+jxwCXlrLVOMNyBQXh8aM40oQANY99RDXtJJgPCh5PKj5q?=
 =?us-ascii?Q?N6EK42PA28d8ZGlCKWBVYPsiCHASx14G21FDk1a957hvoXF6qA0LbK2W4es9?=
 =?us-ascii?Q?5F6oVS4yrdXbiU6otCOLrLd4oNCqvNf2FFc2eob5t81QMF9TVIx4DZJ3NJjq?=
 =?us-ascii?Q?GN7zxSFpVNtV1owK+wpb47vQ8WajxtfQjdv9RYZM2neN2XZuzc0UujT0owQO?=
 =?us-ascii?Q?gRPI8EGIfjDl9Z2AmTi0MC3r8AVT2EztLAh9fqBsCMfy09Qr8OUDHGiMfKJn?=
 =?us-ascii?Q?0P6IdBXFK03xSRFmvkQNyzQiLTKCo5erSmHu9lrWKsR1dqlwwY54Mj/5+c2t?=
 =?us-ascii?Q?lHBvi5WxSsxvCkcef5SpVoDm28o+btDFDcLXm80PNW0x/1+EtIguHXZzeYVQ?=
 =?us-ascii?Q?dP4QcOLitYOzW7siav3plA49PQdhf8TFb3ozAIil1DpmytCNEIYFaLpT2y92?=
 =?us-ascii?Q?qeerZcze58AoAlxVYG4KdLc7FooNP0hDEz9wRqokpb6ZZc4+aCljiiUQxWhH?=
 =?us-ascii?Q?Dg8y85LZr2fnqIfiQ0CUmDTcbHwrVlkY8HF4bYGz1m7jENQeCsumpHdiYGxI?=
 =?us-ascii?Q?ERCdRwvPYuI0Kdt6yuGsEdgwDN/gnq+7Bu+4jVGnfotEWwOYFjrfT4K1hWaU?=
 =?us-ascii?Q?98iH2Tg62x0bFGfN3twDtrR4j6Iud+9+L0k0c+7syV21haqMWq8bNKnlbpi2?=
 =?us-ascii?Q?R5aFr6xXvOgEkx5mkcDtg30B9qKhb3e5rIfKD8Lp+pd8s49b1AOarHlurlE8?=
 =?us-ascii?Q?KGW8m1x73O3ef3QZG9y+lIF113fEwHOiz9xXstYziwxU11+hoimDwwZl2Mqh?=
 =?us-ascii?Q?5iiK0K0xkFEdLyQrErlMIku8cg11Z5rPE3H0W22wBeZ1IwnhVf1NnMZTlyWE?=
 =?us-ascii?Q?nS43JAR1I4TJ6EZkGit/d2yvuUGB5GP6O/m+3Ok3Mqwmqw/J6EPJ0h29E/SC?=
 =?us-ascii?Q?drLm/JrmJz6OIYQyXx+KjYXBKEyeLIRCRbeMetXz3rkxDpzdR1+hVQGp87rP?=
 =?us-ascii?Q?viT04gcuJluNBcGPZLm0XzBX1NKVAN8N0nzF2Gx+61fZmWggxkBjV4C7mbsZ?=
 =?us-ascii?Q?okOC05OL8uj0KfH9k17egyFD6Cn3tTn9zCSgj6aPvyllmgw01P4lBlKhhcbb?=
 =?us-ascii?Q?3O0v8C8CLl18qUVrnJaipfemH704ToATyLrey9yhcu1Mf/bhenGu+UIWXqJA?=
 =?us-ascii?Q?3FJwPuMBvWErr6fH7AbWM+DK7pkLWlU5jDyUxZfIWni1qlAvErlwjtyApIzv?=
 =?us-ascii?Q?u12IIq892wI7QoyPbvVO1lw9YUmj8PpG1xwZbM0oTUHV9VXRpoQhjrj8Kgqd?=
 =?us-ascii?Q?psC9QI1tGy+932WMgcOInKlJ7ZfWXK+zPIbNOmOaIhiRfgZoMIZnbJkuh2Fd?=
 =?us-ascii?Q?DkhQwkuVYiNQMhsOJfnS17CnpKBT2le+OjYdaTNWGvETVFJjCVKMuZpj/jgc?=
 =?us-ascii?Q?4JWpQUUvOLMorPVJypvYKAhVbig1R/p1QQrw/ms8v0AVXPH+ARV+B79cHGz3?=
 =?us-ascii?Q?qthQum0eUanTGuLuHjDR82DaDRNc+GefuAnlMbWtLdyEm8V0ROZp393a9YsI?=
 =?us-ascii?Q?hw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?vJaWZIviIJrywKq4/J5wncVa65vi9ObduaXF2BrPj0OCSX6EbLgg0pTJ7N4N?=
 =?us-ascii?Q?DTwGhZkdTYzOEPjpfKsXnQ8Q+ishZDc9KD6prS6Sqm8e0pEQvVKlp3EEr3DM?=
 =?us-ascii?Q?lt3ttZ0y2TN+XjJB+vrbyjRI6/eLRMKocslFldejet1im7o+fD66xtf++DlJ?=
 =?us-ascii?Q?Wn9C7TZ/y2jPpWuwno+xsPxXqkYuvqWH2Qtr20pfoeaoWm7dw1F9bNZtGxsb?=
 =?us-ascii?Q?8b7bvq5IkWzSbDwG8fuWHczAxr2Ihoj985HKEzRaU9lFveD+uGTa0XJT4ef6?=
 =?us-ascii?Q?vcP2vIwImWjzVP95npVR8sIbnQZvnSxOPoseaLiSqheo95Fkx0kQBVO/lxbe?=
 =?us-ascii?Q?km0jsufq8H/2QC5qmtwUh47VE6f9VOdalEecVtiCeSBL8dDhuJtPRIHfus/v?=
 =?us-ascii?Q?wvRMl0PLLgdkXXgUzEXOY90d2cFj5HG5KKBpxtD8WUlSTV90mQu6pouV/WxB?=
 =?us-ascii?Q?X4bX9Kr/H848rR8Xq1vadzRErpKlfhD9rPmH/Vu5csOAO6Hq9dMleTowobwl?=
 =?us-ascii?Q?6P89780zeLLZ69ryV3adHF431btwMQ6IiPjFrOhUv3iYyDLJYdht2Nzwf7c4?=
 =?us-ascii?Q?idR7TXj0LGXXoldTaS2QPdEotyaZTEKgXI8qpxcUUf+d3iVEBUtzlZY11x63?=
 =?us-ascii?Q?SP8RGgBTOAcqti3doU9LItG7QBO1ORKL7yKDnId8FZbzbmZMhXWEj/yPUIsX?=
 =?us-ascii?Q?ZXVL/Jsq+RJiqXW6abkb4TpiuUpZ1JEbUykBAIDxTZ/UIacICCh8nw+OVaVO?=
 =?us-ascii?Q?QW0ec2bPPSndcShHwTpiKR/G+AtB9WP+yk5KV6lMGk37uv7goPAXRiYA0aHE?=
 =?us-ascii?Q?sxq1LfAgHXDvg6ULAK2gmElSL9gWtVeCrgIHbbrXYxgHTnSwRaZtM5ei/lrw?=
 =?us-ascii?Q?aRl5+puJqzBfcfiULkF0FT/iqAlUfUm9JhFvrbCRqU7kPNukpapXADIj40eX?=
 =?us-ascii?Q?c8axp7AEtHrpgApSc4hG+XQD/rpGfWPvXfpyeEqKiOUe/dwtHVGl/f93lef2?=
 =?us-ascii?Q?xbpQa19H+55zOG73Q26xnRd0hbxeWSJgsk+0kWBzyIqDJwz+z7z9QHl60BL/?=
 =?us-ascii?Q?YwRaoaRnejjBzil2nziANL9jEWFLpg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0b115a6-89ad-4d4b-76af-08db453be3d1
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 03:19:33.2548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b5kpG/fQT0WZRPs2EjmuV1EH4TGVE94HBLzP0q4p7y49Ymn5Qz7h2Phk1Sp4RAmchPrfvJhE4yjt34PV4Hr8XbSE9PT4UspKjLvL9GUTrDo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4152
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-25_02,2023-04-21_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 adultscore=0 mlxlogscore=820 spamscore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2304250029
X-Proofpoint-GUID: FUEP8o1L44yFuHFJD3uVzVs2ATg7eVPf
X-Proofpoint-ORIG-GUID: FUEP8o1L44yFuHFJD3uVzVs2ATg7eVPf
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Alice,

> When ufshcd_err_handler() is executed, CQ event interrupt can enter
> waiting for the same lock. It could happened in upstream code path
> ufshcd_handle_mcq_cq_events() and also in ufs_mtk_mcq_intr(). This
> warning message will be generated when &hwq->cq_lock is used in IRQ
> context with IRQ enabled. Use ufshcd_mcq_poll_cqe_lock() with
> spin_lock_irqsave instead of spin_lock to resolve the deadlock issue.

Applied to 6.4/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering