Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 11:26:07 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Zeng Guang <guang.zeng@intel.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        H Peter Anvin <hpa@zytor.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] KVM: x86: Virtualize CR4.LASS
Message-ID: <ZEdIT3xySArgKO3R@chao-email>
References: <20230420133724.11398-1-guang.zeng@intel.com>
 <20230420133724.11398-2-guang.zeng@intel.com>
 <ZEYwlMmzYnJjNNHq@chao-email>
 <848cb820-e634-4608-5d09-a9bd9ee6de18@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <848cb820-e634-4608-5d09-a9bd9ee6de18@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WEoEmIbIa15OeT1tAVqOvMtM/u9qHUIn9wqNS1NZElE3tnO4ij0CmakCkdh0?=
 =?us-ascii?Q?wa3h3r1/8fWv+1tdBRMh7yguIufo/2mtQjYMaKYumZfzNI4hblNw4B/BpPM7?=
 =?us-ascii?Q?5UAtja9NV97a/mHpKagDYnysp++JJscW2/MsRO7lkt+7NHI2B/dxuJHRtAg8?=
 =?us-ascii?Q?ezS7dZdw0NVMiqaJqNTsLf92KWRDkQb++qwK+v3WkmINcTiOsuqQ1bG35FJu?=
 =?us-ascii?Q?BHJ50xOInQLA7rAEz4xjtvBwoxsxJcHvVvlwbemNzDJyDuLyaRgIHSbpNMnz?=
 =?us-ascii?Q?HVOETU2nMs1Vl5O2h4hVwUrLxpiaQSpdSpJnOua0pBrUgRmcqHDcpSvPlB5L?=
 =?us-ascii?Q?NN99f/LYlDUoLhuyK21i0Zz4RfQUYGWzxINn7UsMCU627b8MABuPVPqgsn8Y?=
 =?us-ascii?Q?XtuThSD5s4YyZFGxrEM1+EzSzNZSn1JajQtEoa7EEBhRT/oUu5VXBa5k+SQp?=
 =?us-ascii?Q?770/m837vPDN6yEToQaFLs8TpxOxNidV3xtYaNJY9pelco1V7gF9wrawzn4u?=
 =?us-ascii?Q?DxIKw9epJgS3j7ewNru1kcGwNYS39gjXpBRqp2hBVOGXPANrkLlCUiWzlETm?=
 =?us-ascii?Q?q2O5cxZJQ5NMFmIX+ArP4QhlXQHLiE+Z3GY1JE3OOaYhgeM372ioDUWio97F?=
 =?us-ascii?Q?V90dErZJycmvrRPEAEmB+1olWHYIuT1dcl6Nb5XZVG+n8TkAT1tZEj8yHv3W?=
 =?us-ascii?Q?SvKmkYny57PCnv8ZQbocb3lTIT5f7R2IudIboKcFz18RtsQZEho59mveT36G?=
 =?us-ascii?Q?8Ti0lpO9smRaux/brn3y/V1At4ISQuw+fLB7+PB9GW0i0EhctfaZ6qzdKT3H?=
 =?us-ascii?Q?xubAloF+G/qKetbz+nE7IGFxkZRBpieUJgUOdDcE3GBCJ/fzoZKehWCxCQVH?=
 =?us-ascii?Q?sPfFvxcyzBMWToKShF0u4ZepxNXaMDqx6Wym/UnA3E48ygg2ma4NhF2U5Dc3?=
 =?us-ascii?Q?G5mUCsmF0x58/i40hPOtEJ09u1umYsK+OaTs8VTBdukUGipUzzcQX2DkKImi?=
 =?us-ascii?Q?G7KRBUSTPacLuhqkfWtT5BgL5r8K9uHBw9YnW47Z3vFm6pMQuSrhuYBrYC+V?=
 =?us-ascii?Q?Gm/dKsip0PHrJGx9woRWD7ApozEA6Cli+WW8oSgpnvn0byaS0be/vRg7TtZ8?=
 =?us-ascii?Q?EJTiOjaokYWmFQpLqH0+iskkfFdTCaQ+1UFyTQHCyd5W/gXq5gQAjYHTQttj?=
 =?us-ascii?Q?a0biNMlkrkQFG7nrnVFBj1YHP4no7A8FSzplOxnO0qdhaJQnNVu2yZhtUYsa?=
 =?us-ascii?Q?d7f02EbMGze37M0MYMCQ+XeDUzfT7tJdMaMS8i5ZA1FiVEWAgcnvB1r28xDH?=
 =?us-ascii?Q?E9BnUXBU03AhzV8U2ooc1KUMk7/bD6cv18FAFJvnfdpnUBrQxsTVdwfshajp?=
 =?us-ascii?Q?lce0Ri/jUNoqQoNuOng8VyIc0hkr7H8CatpEwlU3CUQXYMG/bisbRzRCECM2?=
 =?us-ascii?Q?hc7kwkMizc6hK8wEPmgAIyWQjFGnJ8ehTALjCdi9ZMw3kHJe1YeuaYDqBsIK?=
 =?us-ascii?Q?8BnCWvDK9xESKZd+zDaukF8jAXE3Vt4JW0okSxZMt6iHs+nSn+TQKPjwl5C/?=
 =?us-ascii?Q?YP3er8b66WUjILojjgCy0jKMyianP4zsHtAalAh0?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9434e684-f9c8-4c77-ab4d-08db453cd566
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 03:26:18.6161
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JmRO2uoCYZNk9+6TGPpcwhrZzCukzroLBWKDu5QfhInR/Uf3lm694kD6E8rYa/0CwKjv7e+tlsWOjJr+hx6OLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6978
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 25, 2023 at 10:35:25AM +0800, Zeng Guang wrote:
>
>On 4/24/2023 3:32 PM, Gao, Chao wrote:
>> On Thu, Apr 20, 2023 at 09:37:19PM +0800, Zeng Guang wrote:
>> > Virtualize CR4.LASS[bit 27] under KVM control instead of being guest-owned
>> > as CR4.LASS generally set once for each vCPU at boot time and won't be
>> > toggled at runtime. Besides, only if VM has LASS capability enumerated with
>> > CPUID.(EAX=07H.ECX=1):EAX.LASS[bit 6], KVM allows guest software to be able
>> > to set CR4.LASS.
>> > By design CR4.LASS can be manipulated by nested guest as
>> > well.
>> This is inaccurate. The change in nested_vmx_cr_fixed1_bits_update() is
>> to allow L1 guests to set CR4.LASS in VMX operation.
>
>Essentially it allows nested guest to set CR4.LASS. L1 guest uses cr4_fixed1
>to check
>cr4 value requested to set by nested guest valid or not. Nested guest will
>get #GP
>fault if it's not allowed.

The change to CR4_FIXED1 has more impacts. Without CR4_FIXED1 change,
guest shouldn't enable LASS in VMX operation; it means:

1. before VMXON, LASS should be disabled
2. in VMX operation, LASS cannot be enabled

What you said (i.e., L1 guest allows L2 to enable LASS) belongs in #2.
But #1 isn't covered. That's why I said "inaccurate".

>
>> I would say:
>> 
>> Set the CR4.LASS bit in the emulated IA32_VMX_CR4_FIXED1 MSR for guests
>> to allow guests to enable LASS in nested VMX operation.
>