Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <95260776-a734-e95b-40cc-3959eaf38223@intel.com>
Date:   Tue, 25 Apr 2023 14:47:08 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 6/6] KVM: x86: Set KVM LASS based on hardware capability
Content-Language: en-US
To:     Binbin Wu <binbin.wu@linux.intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        H Peter Anvin <hpa@zytor.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc:     "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Gao, Chao" <chao.gao@intel.com>
References: <20230420133724.11398-1-guang.zeng@intel.com>
 <20230420133724.11398-7-guang.zeng@intel.com>
 <bfb65678-7d47-6ff2-fbfc-0b07a0018cec@linux.intel.com>
From:   Zeng Guang <guang.zeng@intel.com>
In-Reply-To: <bfb65678-7d47-6ff2-fbfc-0b07a0018cec@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/25/2023 10:57 AM, Binbin Wu wrote:
>
> On 4/20/2023 9:37 PM, Zeng Guang wrote:
>> Host kernel may clear LASS capability in boot_cpu_data.x86_capability
> Is there some option to do it?

Kernel supporting LASS will turn off the LASS capability with specific 
option, e.g.
"vsyscall=emulate".

>> besides explicitly using clearcpuid parameter. That will cause guest
>> not being able to manage LASS independently. So set KVM LASS directly
>> based on hardware capability to eliminate the dependency.
>>
>> Add new helper functions to facilitate getting result of CPUID sub-leaf.
>>
>> Signed-off-by: Zeng Guang <guang.zeng@intel.com>
>> ---
>>    arch/x86/include/asm/cpuid.h | 36 ++++++++++++++++++++++++++++++++++++
>>    arch/x86/kvm/cpuid.c         |  4 ++++
>>    2 files changed, 40 insertions(+)
>>
>> diff --git a/arch/x86/include/asm/cpuid.h b/arch/x86/include/asm/cpuid.h
>> index 9bee3e7bf973..a25dd00b7c0a 100644
>> --- a/arch/x86/include/asm/cpuid.h
>> +++ b/arch/x86/include/asm/cpuid.h
>> @@ -127,6 +127,42 @@ static inline unsigned int cpuid_edx(unsigned int op)
>>    	return edx;
>>    }
>>    
>> +static inline unsigned int cpuid_count_eax(unsigned int op, int count)
>> +{
>> +	unsigned int eax, ebx, ecx, edx;
>> +
>> +	cpuid_count(op, count, &eax, &ebx, &ecx, &edx);
>> +
>> +	return eax;
>> +}
>> +
>> +static inline unsigned int cpuid_count_ebx(unsigned int op, int count)
>> +{
>> +	unsigned int eax, ebx, ecx, edx;
>> +
>> +	cpuid_count(op, count, &eax, &ebx, &ecx, &edx);
>> +
>> +	return ebx;
>> +}
>> +
>> +static inline unsigned int cpuid_count_ecx(unsigned int op, int count)
>> +{
>> +	unsigned int eax, ebx, ecx, edx;
>> +
>> +	cpuid_count(op, count, &eax, &ebx, &ecx, &edx);
>> +
>> +	return ecx;
>> +}
>> +
>> +static inline unsigned int cpuid_count_edx(unsigned int op, int count)
>> +{
>> +	unsigned int eax, ebx, ecx, edx;
>> +
>> +	cpuid_count(op, count, &eax, &ebx, &ecx, &edx);
>> +
>> +	return edx;
>> +}
>> +
>>    static __always_inline bool cpuid_function_is_indexed(u32 function)
>>    {
>>    	switch (function) {
>> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
>> index 5facb8037140..e99b99ebe1fe 100644
>> --- a/arch/x86/kvm/cpuid.c
>> +++ b/arch/x86/kvm/cpuid.c
>> @@ -667,6 +667,10 @@ void kvm_set_cpu_caps(void)
>>    		F(AMX_FP16) | F(AVX_IFMA)
>>    	);
>>    
>> +	/* Set LASS based on hardware capability */
>> +	if (cpuid_count_eax(7, 1) & F(LASS))
>> +		kvm_cpu_cap_set(X86_FEATURE_LASS);
>> +
>>    	kvm_cpu_cap_init_kvm_defined(CPUID_7_1_EDX,
>>    		F(AVX_VNNI_INT8) | F(AVX_NE_CONVERT) | F(PREFETCHITI)
>>    	);