Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 15:28:48 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Zeng Guang <guang.zeng@intel.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        H Peter Anvin <hpa@zytor.com>, <kvm@vger.kernel.org>,
        <x86@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] KVM: x86: Set KVM LASS based on hardware capability
Message-ID: <ZEeBMKcQxXHV2ggb@chao-email>
References: <20230420133724.11398-1-guang.zeng@intel.com>
 <20230420133724.11398-7-guang.zeng@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230420133724.11398-7-guang.zeng@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yH9XJ4x5+CU9xUrD4uKytqQqf7v/b8sRoD1UrTQre84Ql8FZ8nDQMz1CtABs?=
 =?us-ascii?Q?IbUmywFjQpbtJMsqknu+PQsDn1XGDp6U8/zBF9TUr8QuAoulWSO6CY2g+tJi?=
 =?us-ascii?Q?c/O3H+3YAYOKhpHzBFXtj6WGsHqD/qASRrKcxCDlwWLcmFiDnb1HSWO1EmlJ?=
 =?us-ascii?Q?3v+c6D6wGgtzyvlNZIuEVc/Of4qTfOsBZk3oULM+cOBA6fwHjAzynWmGxh1J?=
 =?us-ascii?Q?eWNcZJ32geRbJUQkCsWVP8jECmpTVxxNY7nVmBvyRiH027wZKePSV2Xz8myF?=
 =?us-ascii?Q?aMtzNEUYcDLWcxk4QimYF+/VdTva6e22JzGanj9J2dN8CoKE9XO+Imb58t+w?=
 =?us-ascii?Q?OFuOkgMNYoeheXTbh23K2R+PmMyrBig800jEJqYrYgxbkR0gMGvEbJwyeuHa?=
 =?us-ascii?Q?J+3msDkA20iF9rnxgJ5teVJrUOAQU7yRRiMbiTf5BHnBxNNStDKZNPCvl23B?=
 =?us-ascii?Q?D29qCajepQhPgI/Y+JTZMC7ioP0p/+oQT1fLdfM+tbGn2OCrs2517A8NVezS?=
 =?us-ascii?Q?GTIEHCXLNg7AzfvZTLlwtRks+rmVJOuRrlHjrkfmAmgelobgE3oGngxOqihP?=
 =?us-ascii?Q?peq2bzHoS8WWzXNzQdKFKpdIrGyrega1ZaHJM7fbHm0yC34r/KAbsNlcJc1F?=
 =?us-ascii?Q?utOtcPq/XKApI7A0cTZDHW1yFHpAbAtV5HbYZfotyE5482X01F6KraDN8Jyg?=
 =?us-ascii?Q?3nUAt/V0CY4Zfhfw8iuVjujUfzvYv6L3UyjWyaJAL1cQ+ebPM6DOajQvJPxM?=
 =?us-ascii?Q?XkDLACa0upJjPW2BTSL5F4Re+cOR/f7ONkI0Wbt/BUHGF2BN5sMI4QaNVuTH?=
 =?us-ascii?Q?pgfRhFpG+L0MA9vlYeFIWEH88Yft+a/E37Gx4H+UgWvkz69XVq8hX9wRw1ug?=
 =?us-ascii?Q?UTMTlcxCnO5aBl5NO2HnN59a3FnsOxZsnldNyneYMWDtSAQedmxfjx3z7rwa?=
 =?us-ascii?Q?H5myNK9bxN3sH+uoPs8FGNYeLWjHKaO0FvG9EwdN0rHbKWf4X6jTJzeZ6hN+?=
 =?us-ascii?Q?y44E72qMQgsRkNMk6U/SiUvsX3IfL+oRjbJds3Cqvi2bmebfQptx2VR5AWSP?=
 =?us-ascii?Q?rig03JBThPZDP23QgjcECsaN+eDeTHQ72PHhL/sOSV9lGEpRR2017Ac9DKR0?=
 =?us-ascii?Q?Zgc9Tle7LBaAqyLfJfzg4a+ATQSudsBfOAiFsECTh+RoOxHUswFlSJdr5zfp?=
 =?us-ascii?Q?mpqKBI0PAjMQJ0Z1apNiiY2qUB/gAnBf/fkb8EId5i57ehQvngXdl1mmOLa5?=
 =?us-ascii?Q?3sk+Wt3N1qgZxBbcPYNAgra5E454NfyTfRjtweSXam/0/fdSRVC33WNhGNFl?=
 =?us-ascii?Q?v60QIjy1mnSxMhK63SND+rWqzudqeVq4q9cYLvv/Zy2Q/WJ39AMavift86TA?=
 =?us-ascii?Q?9zvVa1D6uIRrYAWH4rmZMPKgqpOTrAIclWbPLn2+pOSDtZKoToYH71ZR9x4O?=
 =?us-ascii?Q?bPPx2XS06MDhMoZJ7BBIZ/kpSmP0rWbTDdlFs8YJl7N7jEtzanDbWdSeOXX5?=
 =?us-ascii?Q?OsUcvYowlrIgLt2H+scvQZ3RAlO1cnCbYBQkQuuEPDr+3o/v+TOSq9+aku/T?=
 =?us-ascii?Q?nzhs9JKAl7wnbxBw/F3uJGETdH+bYcoh3MjpiKGY?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 471e5be1-53de-4abe-d326-08db455ebd26
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 07:29:00.7673
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n1Y2N2Ued3WBQHHaDrXbkVIba9FlU/4QUxewSYVSCTAAo4XwUAXaLJBCoDdNBuLHjPfdUErwPC+3FAJIq3j9Gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7101
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 20, 2023 at 09:37:24PM +0800, Zeng Guang wrote:
>Host kernel may clear LASS capability in boot_cpu_data.x86_capability
>besides explicitly using clearcpuid parameter. That will cause guest
>not being able to manage LASS independently. So set KVM LASS directly
>based on hardware capability to eliminate the dependency.

...

>+	/* Set LASS based on hardware capability */
>+	if (cpuid_count_eax(7, 1) & F(LASS))
>+		kvm_cpu_cap_set(X86_FEATURE_LASS);
>+

What if LASS is cleared in boot_cpu_data because not all CPUs support LASS?

In arch/x86/kernel/cpu/common.c, identify_cpu() clears features which are
not supported by all CPUs:

	/*
	 * On SMP, boot_cpu_data holds the common feature set between
	 * all CPUs; so make sure that we indicate which features are
	 * common between the CPUs.  The first time this routine gets
	 * executed, c == &boot_cpu_data.
	 */
	if (c != &boot_cpu_data) {
		/* AND the already accumulated flags with these */
		for (i = 0; i < NCAPINTS; i++)
			boot_cpu_data.x86_capability[i] &= c->x86_capability[i];

LA57 seems to have the same issue. We may need to add some checks for LA57
in KVM's cpu hotplug callback.

> 	kvm_cpu_cap_init_kvm_defined(CPUID_7_1_EDX,
> 		F(AVX_VNNI_INT8) | F(AVX_NE_CONVERT) | F(PREFETCHITI)
> 	);
>-- 
>2.27.0
>