Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230418124953.3170028-1-fshao@chromium.org> <20230418124953.3170028-3-fshao@chromium.org>
 <ZEX5tc2LSZoVswc2@nixie71> <CAD=FV=XnrSskS=0UKRGGPBxSnPYQtUkJeoBm44bDnwKVBHJLyA@mail.gmail.com>
In-Reply-To: <CAD=FV=XnrSskS=0UKRGGPBxSnPYQtUkJeoBm44bDnwKVBHJLyA@mail.gmail.com>
From:   Fei Shao <fshao@chromium.org>
Date:   Tue, 25 Apr 2023 16:36:50 +0800
Message-ID: <CAC=S1njkYWfvqs5x4nYk0YxoFEcivunKP1T0pG3pO_tapfHivA@mail.gmail.com>
Subject: Re: [PATCH 2/2] HID: i2c-hid: goodix: Add support for
 powered-in-suspend property
To:     Doug Anderson <dianders@chromium.org>
Cc:     Jeff LaBundy <jeff@labundy.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        linux-mediatek <linux-mediatek@lists.infradead.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Jiri Kosina <jikos@kernel.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Stephen Kitt <steve@sk2.org>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Tue, Apr 25, 2023 at 2:16=E2=80=AFAM Doug Anderson <dianders@chromium.or=
g> wrote:
>
> Hi,
>
> On Sun, Apr 23, 2023 at 8:38=E2=80=AFPM Jeff LaBundy <jeff@labundy.com> w=
rote:
> >
> > > @@ -37,13 +38,34 @@ static int goodix_i2c_hid_power_up(struct i2chid_=
ops *ops)
> > >               container_of(ops, struct i2c_hid_of_goodix, ops);
> > >       int ret;
> > >
> > > -     ret =3D regulator_enable(ihid_goodix->vdd);
> > > -     if (ret)
> > > -             return ret;
> > > -
> > > -     ret =3D regulator_enable(ihid_goodix->vddio);
> > > -     if (ret)
> > > -             return ret;
> > > +     /*
> > > +      * This is to ensure that the reset GPIO will be asserted and t=
he
> > > +      * regulators will be enabled for all cases.
> > > +      */
> > > +     if (ihid_goodix->powered_in_suspend) {
> > > +             /*
> > > +              * This is not mandatory, but we assert reset here (ins=
tead of
> > > +              * in power-down) to ensure that the device will have a=
 clean
> > > +              * state later on just like the normal scenarios would =
have.
> > > +              *
> > > +              * Also, since the regulators were not disabled in powe=
r-down,
> > > +              * we don't need to enable them here.
> > > +              */
> > > +             gpiod_set_value_cansleep(ihid_goodix->reset_gpio, 1);
> > > +     } else {
> > > +             /*
> > > +              * In this case, the reset is already asserted (either =
in
> > > +              * probe or power-down).
> > > +              * All we need is to enable the regulators.
> > > +              */
> > > +             ret =3D regulator_enable(ihid_goodix->vdd);
> > > +             if (ret)
> > > +                     return ret;
> > > +
> > > +             ret =3D regulator_enable(ihid_goodix->vddio);
> > > +             if (ret)
> > > +                     return ret;
> > > +     }
> >
> > Please let me know in case I have misunderstood, but I don't see a need
> > to change the regulator_enable/disable() logic if this property is set.
> > If the regulators are truly always-on, the regulator core already knows
> > what to do and we should not duplicate that logic here.

Your understanding is totally right, let me restore that in the next
revision. Thanks!

Regards,
Fei

> >
> > Based on the alleged silicon erratum discussed in patch [1/2], it seems
> > we only want to control the behavior of the reset GPIO. Therefore, only
> > the calls to gpiod_set_value_cansleep() should be affected and the name
> > of the property updated to reflect what it's actually doing.
>
> This would be OK w/ me.