Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <559cf3a3-f740-89d3-9e63-d0016d767a8a@hust.edu.cn>
Date:   Tue, 25 Apr 2023 17:10:14 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: [PATCH RESEND] usb: dwc3: remove dead code in dwc3_otg_get_irq
To:     Sergey Shtylyov <s.shtylyov@omp.ru>, lihuya <lihuya@hust.edu.cn>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     hust-os-kernel-patches@googlegroups.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230424105930.49944-1-lihuya@hust.edu.cn>
 <887b6226-ea4f-e75c-bfde-0785ccf30c77@omp.ru>
From:   Dongliang Mu <dzm91@hust.edu.cn>
In-Reply-To: <887b6226-ea4f-e75c-bfde-0785ccf30c77@omp.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/4/25 16:57, Sergey Shtylyov wrote:
> Hello!
>
> On 4/24/23 1:59 PM, lihuya wrote:
>
>> platform_get_irq() only return non-zero irq number on success, or
>> negative error number on failure.
>>
>> There is no need to check the return value of platform_get_irq()
>> to determine the return value of dwc3_otg_get_irq(), removing
>> them to solve this problem.
>     I was going to submit such patch myself at some point... which
> has never happened. :-/
>
>> Signed-off-by: lihuya <lihuya@hust.edu.cn>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

Hi Sergey,

Please take a look at the following thread [1]. Yuhang sent a v2 patch 
since he did not use his real name in the Signed-off-by.

Greg already had some comments on this patch.

[1] https://lore.kernel.org/lkml/20230425015532.13622-1-lihuya@hust.edu.cn/

>
> [...]
>
> MBR, Sergey
>