Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <55ed1d19-cce9-b9b0-30d6-21b5ee3e5fe9@arm.com>
Date:   Tue, 25 Apr 2023 10:14:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] coresight: perf: Release Coresight path when alloc trace
 id failed
Content-Language: en-US
To:     Ruidong Tian <tianruidong@linux.alibaba.com>,
        coresight@lists.linaro.org
Cc:     mike.leach@linaro.org, leo.yan@linaro.org,
        alexander.shishkin@linux.intel.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230425032416.125542-1-tianruidong@linux.alibaba.com>
From:   Suzuki K Poulose <suzuki.poulose@arm.com>
In-Reply-To: <20230425032416.125542-1-tianruidong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/04/2023 04:24, Ruidong Tian wrote:
> Error handler for etm_setup_aux can not release coresight path because
> cpu mask was cleared when coresight_trace_id_get_cpu_id failed.
> 
> Call coresight_release_path function explicitly when alloc trace id filed.
> 
> Signed-off-by: Ruidong Tian <tianruidong@linux.alibaba.com>

Good catch, I will queue this.

Thanks
Suzuki

> ---
>   drivers/hwtracing/coresight/coresight-etm-perf.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 711f451b6946..89e8ed214ea4 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -402,6 +402,7 @@ static void *etm_setup_aux(struct perf_event *event, void **pages,
>   		trace_id = coresight_trace_id_get_cpu_id(cpu);
>   		if (!IS_VALID_CS_TRACE_ID(trace_id)) {
>   			cpumask_clear_cpu(cpu, mask);
> +			coresight_release_path(path);
>   			continue;
>   		}
>