Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6ddd373b-6bcb-85a7-2423-ceea5d3f1246@redhat.com>
Date:   Tue, 25 Apr 2023 12:30:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v10 02/14] HP BIOSCFG driver - biosattr-interface
Content-Language: en-US, nl
To:     Pavel Machek <pavel@ucw.cz>, Jorge Lopez <jorgealtxwork@gmail.com>
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        thomas@t-8ch.de
References: <20230419151321.6167-1-jorge.lopez2@hp.com>
 <20230419151321.6167-3-jorge.lopez2@hp.com> <ZEJ1f7vOL1zCyNyR@duo.ucw.cz>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <ZEJ1f7vOL1zCyNyR@duo.ucw.cz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 4/21/23 13:37, Pavel Machek wrote:
> Hi!
> 
>> Linux Security components are under development and not published yet.
>> The only linux component is the driver (hp bioscfg) at this time.
>> Other published security components are under Windows.
>>
>> Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com>
> 
>> +/*
>> + * ascii_to_utf16_unicode -  Convert ascii string to UTF-16 unicode
>> + *
>> + * BIOS supports UTF-16 characters that are 2 bytes long.  No variable
>> + * multi-byte language supported.
>> + *
>> + * @p:   Unicode buffer address
>> + * @str: string to convert to unicode
>> + *
>> + * Returns a void pointer to the buffer containing unicode string
>> + */
>> +void *ascii_to_utf16_unicode(u16 *p, const u8 *str)
>> +{
> 
> Does this need to go to library somewhere?

This has already been discussed in earlier submissions
of the driver, the utf16 format is HP specific (prefixed
with a 16 bit le lenght, and the 0 length string needs
special encoding) so despite the name this is not generic.

It should probably be prefixed with hp_ because of this
though, to avoid potential symbol conflicts when builtin.

(and the same applies to other generic functions).

Regards,

Hans