Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 13:00:25 +0200
From:   Pankaj Raghav <p.raghav@samsung.com>
To:     Matthew Wilcox <willy@infradead.org>
CC:     Luis Chamberlain <mcgrof@kernel.org>, <hughd@google.com>,
        <akpm@linux-foundation.org>, <brauner@kernel.org>,
        <djwong@kernel.org>, <da.gomez@samsung.com>,
        <a.manzanares@samsung.com>, <dave@stgolabs.net>,
        <yosryahmed@google.com>, <keescook@chromium.org>, <hare@suse.de>,
        <kbusch@kernel.org>, <patches@lists.linux.dev>,
        <linux-block@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <p.raghav@samsung.com>
Subject: Re: [RFC 2/8] shmem: convert to use folio_test_hwpoison()
Message-ID: <20230425110025.7tq5vdr2jfom2zdh@localhost>
MIME-Version: 1.0
In-Reply-To: <ZEMRbcHSQqyek8Ov@casper.infradead.org>
Content-Type: multipart/mixed;
        boundary="----t5a.LUSxvZ8UNChTG7xN-7.3lkNPyOm_Ty_DrQaWPiPzU4rz=_ea8fb_"
CMS-TYPE: 201P
References: <20230421214400.2836131-1-mcgrof@kernel.org>
        <20230421214400.2836131-3-mcgrof@kernel.org>
        <ZEMRbcHSQqyek8Ov@casper.infradead.org>
        <CGME20230425110913eucas1p22cf9d4c7401881999adb12134b985273@eucas1p2.samsung.com>
Precedence: bulk

------t5a.LUSxvZ8UNChTG7xN-7.3lkNPyOm_Ty_DrQaWPiPzU4rz=_ea8fb_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Fri, Apr 21, 2023 at 11:42:53PM +0100, Matthew Wilcox wrote:
> On Fri, Apr 21, 2023 at 02:43:54PM -0700, Luis Chamberlain wrote:
> > The PageHWPoison() call can be converted over to the respective folio call
> > folio_test_hwpoison(). This introduces no functional changes.
> 
> Um, no.  Nobody should use folio_test_hwpoison(), it's a nonsense.
> 
> Individual pages are hwpoisoned.  You're only testing the head page
> if you use folio_test_hwpoison().  There's folio_has_hwpoisoned() to
> test if _any_ page in the folio is poisoned.  But blindly converting
> PageHWPoison to folio_test_hwpoison() is wrong.

I see a pattern in shmem.c where first the head is tested and for large
folios, any of pages in the folio is tested for poison flag. Should we
factor it out as a helper in shmem.c and use it here?

static ssize_t shmem_file_splice_read(struct file *in, loff_t *ppos,
...
	if (folio_test_hwpoison(folio) ||
	    (folio_test_large(folio) &&
	     folio_test_has_hwpoisoned(folio))) {
	..
> 
> If anyone knows how to poison folio_test_hwpoison() to make it not
> work, I'd appreciate it.

IMO, I think it will be clear if folio_test_hwpoison checks if any of the
page in the folio is poisoned and we should have a explicit helper such
as folio_test_head_hwpoison if the callers want to only test if the head
page is poisoned (although I am not sure if that is useful).

------t5a.LUSxvZ8UNChTG7xN-7.3lkNPyOm_Ty_DrQaWPiPzU4rz=_ea8fb_
Content-Type: text/plain; charset="utf-8"


------t5a.LUSxvZ8UNChTG7xN-7.3lkNPyOm_Ty_DrQaWPiPzU4rz=_ea8fb_--