Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp6829705rwr; Tue, 25 Apr 2023 04:35:57 -0700 (PDT) X-Google-Smtp-Source: AKy350YFKr3XeqNAM9XkIN8aUNyFjCK+hmAVK9CaOV0Yu21O1TW0+xUp+916kuJT2/n4xXKyG1gj X-Received: by 2002:a05:6a20:1605:b0:f5:e4b0:4221 with SMTP id l5-20020a056a20160500b000f5e4b04221mr4917116pzj.56.1682422556942; Tue, 25 Apr 2023 04:35:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682422556; cv=none; d=google.com; s=arc-20160816; b=LAI4UHTVLkoVEq5946wVY/m8z7m04IVp4oBI82iQApUpyEsaLmyahQHaLVK7Cwzn/C owLx44ptKK79lGBapjRrUgHSnMT7SAdlEjp1zx2GWcf8ZEJIHXEpgMAI7jPzz8OHQDzz BoTpt0xrGQGtSfNORP7qZCPbHzrSDWe/85DUuSFPyDGdUXTNvnawCA+JC0L/xPfcap+6 dSlL3qG6riFUp/71zQI+z3ejfbk4pGa9FlGF3Cze2iDucuVhm5t0DlZxXuAwfrOfEsJK 2PIhQFNohFEFeLrFG9fMJ3bIqnr3zutFJtwaqTcoXKEvOQbLGizSTJBJEa8dMNON4u2k 2vYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=LvKIXdLcIMIgI/88kCJxwFu36P8URAgW0aQ394g76CI=; b=frfVuP9bHFYfQDHDowCYhcNIgmQtJltqoqhYNNQqZ9cv0gRhYW/4aVECA4to4k7K6c 8sZqzmczA+6ZLdkpYwEBjRYmkk1B8iw7ffHrN91rNm8oA+ybpf/0zyEH19d1l5Ebo+bv uSJ0kUOErHQiwqPfnJ1lr0oD5kZLt9U6FAVV4zfYldwpV8HeZXJlHKzkaqtRb+gLziq9 /T6LcjjHAi3wsU1N8DUVphoFTBfYReD022V5+c7WUm3HgckLV6Zmxzsf6DND9bSaMrqO U7N2AnCes1Cbt5zJnVoQwycytKhmmMG5iQxM+Avykfqjj3DRV0LP31MlBZ/+ILkcr5vb bm6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=i0+4o4So; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r10-20020a632b0a000000b005286d7712d1si1724353pgr.672.2023.04.25.04.35.44; Tue, 25 Apr 2023 04:35:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=i0+4o4So; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233966AbjDYLbE (ORCPT + 99 others); Tue, 25 Apr 2023 07:31:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233973AbjDYLbB (ORCPT ); Tue, 25 Apr 2023 07:31:01 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E742F422A for ; Tue, 25 Apr 2023 04:30:58 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33P5g3ZW017262; Tue, 25 Apr 2023 06:30:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=LvKIXdLcIMIgI/88kCJxwFu36P8URAgW0aQ394g76CI=; b=i0+4o4SoY27z64v6PQlFg0801bo2YXMLD9c7ggzbZ1vYUxROjPvpFFPdiG2qCEIGem6m YHuaDusMHBh84mOxRjohqjPjOPf6mdKGNMZbGpH0G+78cLdh7LjrwFfaMavVr1Do5Jmd hHZETtplAP80BBeEl0RFjh/lYuWTMlMgwVBLETRdxDff3N1iA74TkrYSOij0kJNXd59w AFc7Op4fPRXfNyLe867oCoz8u3gCvjwbwv7yRR9DohgtwlOTyEnuNSIEsO7oXk7LbzpX +REYQaDnUWTTrPikw0NYaE7m6xhT/szNhEGVYwgJ4CWDpLIJxp5fn4pT0r0htcVCEOph xg== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3q4c0pmfjy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Apr 2023 06:30:49 -0500 Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 25 Apr 2023 06:30:48 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Tue, 25 Apr 2023 06:30:48 -0500 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id EC61311DC; Tue, 25 Apr 2023 11:30:47 +0000 (UTC) Date: Tue, 25 Apr 2023 11:30:47 +0000 From: Charles Keepax To: Guiting Shen CC: , , , Johan Hovold Subject: Re: [PATCH v2 RESEND] mfd: remove redundant dev_set_drvdata() from i2c drivers Message-ID: <20230425113047.GC68926@ediswmail.ad.cirrus.com> References: <20230425024526.6443-1-aarongt.shen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230425024526.6443-1-aarongt.shen@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: b4VkKYc36jLj_rV93nu1JMC0LAhGZK8S X-Proofpoint-ORIG-GUID: b4VkKYc36jLj_rV93nu1JMC0LAhGZK8S X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 25, 2023 at 10:45:26AM +0800, Guiting Shen wrote: > the i2c_set_clientdata() is the inline function which is complemented by > the dev_set_drvdata() internally. Do not need to use i2c_set_clientdata() > and dev_set_drvdata() at the same time. > > Signed-off-by: Guiting Shen > Reviewed-by: Johan Hovold > --- Reviewed-by: Charles Keepax Thanks, Charles