Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 15:05:05 +0300
From:   Dmitry Rokosov <ddrokosov@sberdevices.ru>
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>
CC:     <neil.armstrong@linaro.org>, <jbrunet@baylibre.com>,
        <mturquette@baylibre.com>, <sboyd@kernel.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <khilman@baylibre.com>, <jian.hu@amlogic.com>,
        <kernel@sberdevices.ru>, <rockosov@gmail.com>,
        <linux-amlogic@lists.infradead.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v13 6/6] clk: meson: a1: add Amlogic A1 Peripherals clock
 controller driver
Message-ID: <20230425120505.xrgrjrxcxennrzct@CAB-WSD-L081021>
References: <20230405195927.13487-1-ddrokosov@sberdevices.ru>
 <20230405195927.13487-7-ddrokosov@sberdevices.ru>
 <CAFBinCBGWOB2XLb6su=R3W684rKdK3pOgPFsCGx+Oyo_pgdeBg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAFBinCBGWOB2XLb6su=R3W684rKdK3pOgPFsCGx+Oyo_pgdeBg@mail.gmail.com>
User-Agent: NeoMutt/20220415
Precedence: bulk

On Sun, Apr 23, 2023 at 11:30:38PM +0200, Martin Blumenstingl wrote:
> On Wed, Apr 5, 2023 at 9:59 PM Dmitry Rokosov <ddrokosov@sberdevices.ru> wrote:
> [...]
> > +static const struct of_device_id a1_periphs_clkc_match_table[] = {
> > +       { .compatible = "amlogic,a1-clkc", },
> > +       {},
> nit-pick: please remove the comma after the sentinel
> 

Thank you for bringing up that point! There's no problem with removing
it in the next version of the product. I'll prepare it.

> > +MODULE_DEVICE_TABLE(of, a1_periphs_clkc_match_table);
> > +
> > +static struct platform_driver a1_periphs_clkc_driver = {
> > +       .probe = meson_a1_periphs_probe,
> > +       .driver = {
> > +               .name = "a1-clkc",
> > +               .of_match_table = of_match_ptr(a1_periphs_clkc_match_table),
> I wonder if we should drop of_match_ptr() here as no other meson clock
> driver uses it.
> Also there's commits like 00cb754ac622 ("clk: imx8mq: drop
> of_match_ptr from of_device_id table") which explicitly remove it from
> other drivers.

Exactly, all Meson clock drivers depend on the ARM64 config, which in
turn selects CONFIG_OF by default. So of_match_ptr can be dropped.

> 
> Apart form these two this patch looks great to me.
> 

-- 
Thank you,
Dmitry