Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f5bf590a-5d3f-03f2-531c-057cf8760000@amd.com>
Date:   Tue, 25 Apr 2023 14:44:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] drm/amdgpu: Mark contexts guilty for any reset type
Content-Language: en-US
To:     =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel.daenzer@mailbox.org>,
        =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= <maraeo@gmail.com>
Cc:     Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
        =?UTF-8?Q?Andr=c3=a9_Almeida?= <andrealmeid@igalia.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        "Tuikov, Luben" <Luben.Tuikov@amd.com>,
        amd-gfx mailing list <amd-gfx@lists.freedesktop.org>,
        kernel-dev@igalia.com,
        "Deucher, Alexander" <alexander.deucher@amd.com>
References: <20230424014324.218531-1-andrealmeid@igalia.com>
 <d7264c5a-29b4-0fb3-153b-673a8a73d635@amd.com>
 <CAAxE2A6Soq28ACV-m1OzG8CA-_VWp+N2wapsABzm2Nda=Qe+yA@mail.gmail.com>
 <784561bb-0937-befc-3774-892d6f6a4318@mailbox.org>
 <CAAxE2A6iuuVA7zjHM8YcTGMpEWuYV=hGRR1YW6W-qXHwAg9w7w@mail.gmail.com>
 <19406ec5-79d6-e9e6-fbdd-eb2f4a872fc4@amd.com>
 <5262c73e-e77c-91f7-e49e-a9c3571e2cc9@mailbox.org>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <5262c73e-e77c-91f7-e49e-a9c3571e2cc9@mailbox.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlBMbk1PNFZVRFZwU3N5ZkNyTFk0eHB0WWVBMWtoT3BCZGVGdWtWUFp6eU85?=
 =?utf-8?B?anhERWhrTjBTWFdZOGlPeTY1eWVCcWg5QmxGQnhUTSthK0kzejVzbG1ZWjBs?=
 =?utf-8?B?WDUxd1RvYmdXY3pmb3U4UVhIdVBtWWI1TnNrc0JQdXJuYVc0SlJ5eWw0U0tn?=
 =?utf-8?B?OFZKWGlranpXUGRrNEhpdG56eHhBZmU3SEl1TUtlQUxPaGhiQUdMdnoybHJL?=
 =?utf-8?B?azV5RTJySzk5OG9mMDN5NWc3NzI5b2dhaXVtdUl0YWxHMWRpSHRWdUJ3R1JR?=
 =?utf-8?B?VkU4d3pIM3MwSjVoUE4rSU1XUzZxS2s2K2ZnU2ZyeHM5TzBidFpKaVBXNVV3?=
 =?utf-8?B?ZENJZDdLQ2lhR2tXT1dsRHdvNlpjUnJKYTlVRUNsQld1ZDY4TXRhTlBtdUtP?=
 =?utf-8?B?ZGhrMW9DOUFUa05ySHpreGZqS0RscXJQOVFPdE5XZlEyYW1kczRuSDdkekt6?=
 =?utf-8?B?d2cyREpmWmptMUtncm5vNEpsOE5oNEpIWnljNEhzcndUaERYZWJDQTJrOWIr?=
 =?utf-8?B?V3craWRYQ1FYWmpoMWpTQU96Q1JiemdTSXRvNzNzMEc1SlpabFRpNnVPUHBO?=
 =?utf-8?B?NFp3REYvSXVGOGVVVllLNXRxMHRtTTBocCtvM1Foc2NTVzJTSDJUTDNTRzFQ?=
 =?utf-8?B?ZU03cTNBd1pzVWt6LzBoVVp0Wk1SdzZlNk5SamNzK1g5OVQ2dlp3NDl1UXBZ?=
 =?utf-8?B?cHRybVUwZUs2NHYyU2xkWDZ3dTRQOFJkSXdBV29vak5PSzM5dStsbk10SnZj?=
 =?utf-8?B?U0I0T0t3bG1abXMyUFdSNUR5N0xLdVNFVXF0SUpMc2IzTmZCODQzY1d1dzFM?=
 =?utf-8?B?UksvRk9Jd0NKYkZCd0FFL0pMSVNaZVp5TXU5TUpNMkdOTEpSTmdQQlA4QTVF?=
 =?utf-8?B?YWszTGhCaGtVVThlYW5vb1Ywd1FhOGJCM1FseGJUaWpBMEc2dzE1RFZTTElr?=
 =?utf-8?B?OXgxL0xuajRnYzZubFBncEJvMUdjcnIrK25MVXFiZFUxZVdlTllPL0NFbHM1?=
 =?utf-8?B?R0g5VCtaVDVVM0hiNElabVRlRUFUMzNhTE90aE14bkxwNmMyL0F5NndaclVG?=
 =?utf-8?B?ZW5SNTNYVjNHU3N5SjNKemlhcEgyTExXVlVLQ2V0MnR2bklJakxKbkVvbFpy?=
 =?utf-8?B?SUZmNlpxQ0F2Nkh2SFpseFlUZWx5eUIwMGduY3lma0xLUklqTllySjhHMGFp?=
 =?utf-8?B?U3NnYjU3UE5ZQUljemtlMkM3NHlZNXBmOFBLUjVsMk50U1BMcWJRUlJvNDR5?=
 =?utf-8?B?c2hadXRnajQwZFptN05XaXhCWmowK21hMDNveXA3eTJtV0FxYnZqWU5EVUZK?=
 =?utf-8?B?OFVKcElmTFJ4QTVJQ25uUyszYTgyVkRITSs0Z2ZPOW15NitZR0pOcTlIMGlm?=
 =?utf-8?B?bmlMUHJZcHU5OVJwZkc2SDNQZ3NsYjEwOE1HdGRvR2hCVkx2UWJYOURvYnN1?=
 =?utf-8?B?aEVabkhTaXM5Vmdvc0p1M3hqWVdDMmUveGU5YmFDODNNYWZDRnlPM09xVEZT?=
 =?utf-8?B?OC9mRjFScE1oL3JqYUNvTzJ1TndQZ0YzZENnWU1xL1dkNkdCQ1FCN3ZxOWc0?=
 =?utf-8?B?SXpDajZyWVRUYnVJbCt2WXVhakpDOFNCclNITTF5dCtNY0JzUjZSSU1SWGVt?=
 =?utf-8?B?MU4zVmM0a1RRUEcycGNVU0xLeFBUaUtwWDBSMStqd3NLbTV3L3F4OGo4V0hN?=
 =?utf-8?B?eFE3WmNFRmp5eDhyUzFaQldkdDRFY3E1N09yWHRwMWZZcUtUOWF3SVpQWlIr?=
 =?utf-8?B?OUt5UnpnMlZrdkRKdjl0WFFYY1lWQTNsNFAyNFFLMHNQdkFzVUlFdXh6bWkr?=
 =?utf-8?B?eERlRVo0UndnclZOZjlZWDZ3QVQ4RGJSWjdjazE2dHpjNmVHbkIydWxaSHk1?=
 =?utf-8?B?LzZRdVV6ak1mcWVxQ0ZwS1hGWmNMckR0Ry9mSEFOdjIvcW9od1NnMThLWWNF?=
 =?utf-8?B?Q1h3ZmNDSnE1MlU5VURUcG1GZUcvWFBsaFAwT2dNMU1ibjJsZmlnblB4enpi?=
 =?utf-8?B?NFZGdHpNWkwxaHdoK3B3eGlxYm9oY1lPZVZKKzJEVGtCQk9xcGdUckUwTEp5?=
 =?utf-8?B?Vld1TWk3STJzMlpWdTFzWHUrUCs5c1c3Rlk1YnNGWk1lajY2ei9GMllBT1da?=
 =?utf-8?B?QllXc2tLaVdPNjg5V3gvRzY2aldsWnVud0RwZ3ZnaWM1Y3d4QjFyNTRSN3BO?=
 =?utf-8?Q?l9sLx1zUGg5x8bAQT7vYb7AOvycINh5uOB1ar4ijfcvn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4a7f389-3d24-4c57-2ea9-08db458acf4f
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 12:44:29.1453
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0akp+ZlPau9QxnWWPSCFus9RzNpzz2H0dg4C2zB/swFUpY8rljpmXYDYVKouveuy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7131
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 25.04.23 um 14:14 schrieb Michel Dänzer:
> On 4/25/23 14:08, Christian König wrote:
>> Well signaling that something happened is not the question. We do this for both soft as well as hard resets.
>>
>> The question is if errors result in blocking further submissions with the same context or not.
>>
>> In case of a hard reset and potential loss of state we have to kill the context, otherwise a follow up submission would just lockup the hardware once more.
>>
>> In case of a soft reset I think we can keep the context alive, this way even applications without robustness handling can keep work.
>>
>> You potentially still get some corruption, but at least not your compositor killed.
> Right, and if there is corruption, the user can restart the session.
>
>
> Maybe a possible compromise could be making soft resets fatal if user space enabled robustness for the context, and non-fatal if not.

Well that should already be mostly the case. If an application has 
enabled robustness it should notice that something went wrong and act 
appropriately.

The only thing we need to handle is for applications without robustness 
in case of a hard reset or otherwise it will trigger an reset over and 
over again.

Christian.

>
>
>> Am 25.04.23 um 13:07 schrieb Marek Olšák:
>>> That supposedly depends on the compositor. There may be compositors for very specific cases (e.g. Steam Deck) that handle resets very well, and those would like to be properly notified of all resets because that's how they get the best outcome, e.g. no corruption. A soft reset that is unhandled by userspace may result in persistent corruption.
>