Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 10:03:46 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     ankita@nvidia.com, aniketa@nvidia.com, cjia@nvidia.com,
        kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com,
        acurrid@nvidia.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] vfio/nvgpu: Add vfio pci variant module for grace
 hopper device
Message-ID: <ZEfPsm+SVRC/P5T2@ziepe.ca>
References: <20230419222836.24714-1-ankita@nvidia.com>
 <20230420171720.418a3c0d.alex.williamson@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230420171720.418a3c0d.alex.williamson@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?88LeXQXF9WgNFWNFL7pVaVo9Du2lgzvlUqjAPfOojTn2TP3oIwfCpJjVe//5?=
 =?us-ascii?Q?Z+pvZR5injY8hMkFa/Jo/ALBwapoLf2016JV9d5fzck6i6Fes/euPjjhQXIG?=
 =?us-ascii?Q?m8Rm6qe2fI/uVarCJKmx3lZF9dkSEzB4hOu0Fq7O8QhBLrD0RNV68ln6mmIp?=
 =?us-ascii?Q?e0ZI4E+xx6+hRJ1ZALBnOppdgON64IHYv2Es0z++IQyLSZwecurEruioggks?=
 =?us-ascii?Q?cFzO4w0AQ1i5OCc0lh70NubjJOERNT+I8+uFJBIT7hhyLdaVHjWmnvAzR2Ft?=
 =?us-ascii?Q?WKsiZtLdqmSlDangzXQzRw/flP45M9mleuflM++vW5G4VnQRbdgKfWE73eFv?=
 =?us-ascii?Q?uqCTsMLUSs2b42AonNOXok3gkZuHvPFIJZzFu7QLL9kbJp6mZLou0KgO1T7Q?=
 =?us-ascii?Q?c08qpemr4ANXr4m+/f7Whcj2JkFhm31XNGKtalHhL6YoyJ3I28vZ2zzKMoVB?=
 =?us-ascii?Q?jJVADsQhOCrDT+9UTor0zrEsPc6ca6LXWL9FjFSBBb8jwHHQlYR4k9yIFcd6?=
 =?us-ascii?Q?q0AZuJTt8sZoDpFVeYgny5THlFMc9MuGLCZEDfuF4S7RZ0Xo9ofHoNo3iTAi?=
 =?us-ascii?Q?QV/nxmEaDR4L7DRcdf98o6ePuGz/eRlXI8omRqrltW9yeI03F4f+ReOebScg?=
 =?us-ascii?Q?jBS14D5auMJIqFKaGpap8TUayosEEL5y0qF6OaTJ/JG9Sb+H7CVRrQCDSb3P?=
 =?us-ascii?Q?RlNdQAyV8rCXCwAGAExoV7h1fRJLOKd/XkmFJoXcyPUvCw1bgUEAhFBVrHOe?=
 =?us-ascii?Q?5EdrmYizuUAH/1bkr3beggbiUzlN6Ux4gdOslXWrikmwlwNNT+Rm7f8ZgsMF?=
 =?us-ascii?Q?3EXAA5T2g5rxHmuBQ8GIfmbYspToJM7spnb4AEvVdGshCUhE4+mmyD6utFaf?=
 =?us-ascii?Q?ZZcw7l7iKlkUYOuduWuYh+7CeBsbffyKyGA9XNyh5bWEQLqZ+T4WaS2Y9iGk?=
 =?us-ascii?Q?S+OB9rogKSgRa9pa+oLkPkYdJ8+voHrUTtjRw9sgHA6P0RHduoYkCctqOJb9?=
 =?us-ascii?Q?BHv6gAVZWwuZXeP3CwI5MQrcuYugEDpJ8LLt1R1wgcNqGeI1SoCd6wn/WWMd?=
 =?us-ascii?Q?bXV1asSLJx/NV6WK8ocmu4MJbGS9mqexXhI03Fp0p6hPTddOlGfIa3OsgmYE?=
 =?us-ascii?Q?qYFsCK85U2AjLoZtX2uT5MUCcXQjveqcXr+zsT81wbKW0+YG9GcDS8LIY9iT?=
 =?us-ascii?Q?+ymQDp6JN+x7MPQO8+r5mfyt6CgM+ouvACmvDaYpW1QA6JZ5KIxTAukLtcA+?=
 =?us-ascii?Q?BUUlOcqPe5bhyFll15Mepby+OQTRO1OyvFWm/LJcUO50Xu8aGBWGuoBUN0Z8?=
 =?us-ascii?Q?zOE3wMJmnct3XIo7eUrVdfDnfMGp9gB8g8/5w/jNrF33CafdLhJY3SJVCIP6?=
 =?us-ascii?Q?1xMntJpiBOggpnKmnN1xRSF+7lNyPxOgWvuBZ0BB06MbfUI57RS4AZO3OKJ2?=
 =?us-ascii?Q?32bzV0pCxCFvcq8r9GPIQuewUmywnVE7hLVb3+dVXoNmQqIfib2X6ixNszuM?=
 =?us-ascii?Q?3ttwA1uku7Fazies+xqvk2RULbrBju0+qqtK/mu16coHwsBX16jkhqKu19L2?=
 =?us-ascii?Q?X4FlTSBhrClRGzXgYO0+qQi+BWnDG+Y6Z8h5DuDC?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6948c441-1f1c-4fb3-b095-08db458d825d
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 13:03:48.4572
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ggd8dhXwt6CKhJycEr6IQLDyv01HLI0cH1xMrFp7qjVkDZq2gHAXI53y1vXEMoFy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5399
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 20, 2023 at 05:17:20PM -0600, Alex Williamson wrote:

> > +	/*
> > +	 * Perform a PFN map to the memory. The device BAR1 is backed by the
> > +	 * GPU memory now. Check that the mapping does not overflow out of
> > +	 * the GPU memory size.
> > +	 */
> > +	ret = remap_pfn_range(vma, vma->vm_start, start_pfn + pgoff,
> > +			      min(req_len, nvdev->mem_prop.mem_length - pgoff),
> > +			      vma->vm_page_prot);
> 
> What's the behavior of this "BAR" relative to things like
> PCI_COMMAND_MEMORY or reset?  If the user generates a secondary bus
> reset on the parent bridge in one thread, while accessing the device in
> another thread, isn't that susceptible to platform error handling just
> like any other PCI device?  

This space works more like RAM and it is made cachable as well which
changes how errors are managed compared to PCI.

It doesn't generate any unhandled failures, so we don't need the zap
protection here.

Jason