Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 19:04:57 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To:     Nishanth Menon <nm@ti.com>
Cc:     Manivannan Sadhasivam <mani@kernel.org>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, Lee Jones <lee@kernel.org>,
        Pavel Machek <pavel@ucw.cz>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH] dt-bindings: leds: Drop redundant cpus enum match
Message-ID: <20230425133457.GA5640@thinkpad>
References: <20230424151437.256073-1-nm@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230424151437.256073-1-nm@ti.com>
Precedence: bulk

On Mon, Apr 24, 2023 at 10:14:37AM -0500, Nishanth Menon wrote:
> Commit e91a4d5deb96 ("dt-bindings: leds: Document commonly used
> LED triggers") introduced a enum match for cpu, while a pattern
> '^cpu[0-9]*$' already exists.
> 
> This causes linux,default-trigger = "cpu" to have more than one match
> and generates the following dtbs_check warning:
> 
> arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dtb: leds: led-2:linux,default-trigger: More than one condition true in oneOf schema:
> 	{'$ref': '/schemas/types.yaml#/definitions/string',
> 	 'oneOf': [{'items': [{'enum': ['backlight',
> 	                                'default-on',
> 	                                'heartbeat',
> 	                                'disk-activity',
> 	                                'disk-read',
> 	                                'disk-write',
> 	                                'timer',
> 	                                'pattern',
> 	                                'audio-micmute',
> 	                                'audio-mute',
> 	                                'bluetooth-power',
> 	                                'cpu',
> 	                                'flash',
> 	                                'kbd-capslock',
> 	                                'mtd',
> 	                                'nand-disk',
> 	                                'none',
> 	                                'torch',
> 	                                'usb-gadget',
> 	                                'usb-host',
> 	                                'usbport']}],
> 	            'maxItems': 1,
> 	            'minItems': 1,
> 	            'type': 'array'},
> 	           {'items': [{'pattern': '^cpu[0-9]*$'}],
> 	            'maxItems': 1,
> 	            'minItems': 1,
> 	            'type': 'array'},
> 	           {'items': [{'pattern': '^hci[0-9]+-power$'}],
> 	            'maxItems': 1,
> 	            'minItems': 1,
> 	            'type': 'array'},
> 	           {'items': [{'pattern': '^mmc[0-9]+$'}],
> 	            'maxItems': 1,
> 	            'minItems': 1,
> 	            'type': 'array'},
> 	           {'items': [{'pattern': '^phy[0-9]+tx$'}],
> 	            'maxItems': 1,
> 	            'minItems': 1,
> 	            'type': 'array'}]}
> 
> Drop the explicit match against cpu since the pattern match already
> covers the same.
> 
> Fixes: e91a4d5deb96 ("dt-bindings: leds: Document commonly used LED triggers")
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Nishanth Menon <nm@ti.com>

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> ---
>  Documentation/devicetree/bindings/leds/common.yaml | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index 11aedf1650a1..58b492d00246 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -105,8 +105,6 @@ properties:
>            - audio-mute
>              # LED indicates bluetooth power state
>            - bluetooth-power
> -            # LED indicates activity of all CPUs
> -          - cpu
>              # LED indicates camera flash state
>            - flash
>              # LED indicated keyboard capslock
> -- 
> 2.40.0
> 

-- 
மணிவண்ணன் சதாசிவம்