Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Liam R. Howlett" <Liam.Howlett@oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        maple-tree@lists.infradead.org,
        "Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: [PATCH 13/34] maple_tree: Use MAS_WR_BUG_ON() in mas_store_prealloc()
Date:   Tue, 25 Apr 2023 10:09:34 -0400
Message-Id: <20230425140955.3834476-14-Liam.Howlett@oracle.com>
In-Reply-To: <20230425140955.3834476-1-Liam.Howlett@oracle.com>
References: <20230425140955.3834476-1-Liam.Howlett@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2lFq5YYX9PWnf3HLG5sl7oB9D++m91p8088gjNnSvFDMgcJLVkKXbXciyqoS?=
 =?us-ascii?Q?BeR4OYhydm8V6MCWAvDHyPxKsZ/JWdjOakUw75fC8o8ng441WfFtohsgZj9x?=
 =?us-ascii?Q?Vl+gXye8eofuqoAGVuWbjVjjHU8GMGNnbZPdOa06QFjJGQMgfH1xy4AgRfww?=
 =?us-ascii?Q?K1Uj2MYwSKN6lzY+lPE3OMfwkx3S/3O8lXs1OEuCpNBM1j5Fx50Gh2gOZ14I?=
 =?us-ascii?Q?UrFWgjzaBFYooukonUVtxGqp/Y9CEvC2xEI20eORNMnEoXoJ9StCMbX5OvM7?=
 =?us-ascii?Q?pNHeUA/Za0x57wHkNHAws7SrXPnGC0DUAA1I1TgjlWI/J8w740eIYtKT3UMq?=
 =?us-ascii?Q?fXhMcSVIi+A25WPxKOzjoM2nvr0mtzac1NqH/avd5HDkM/Q+9mBNPw+PAjGO?=
 =?us-ascii?Q?TApMxpBePG3+ycwBoP48QoeWmv8MhnKsl8EZAQzUZHIU+HAtOFe4LbdDhKC0?=
 =?us-ascii?Q?cXOLmRMMjULl9mzopb9dFrKbWqzqBmCRy6OuWuJ38Rd0mCu7C3pFQbGZ7WLA?=
 =?us-ascii?Q?ripT0n5rGeZb0vJrIVTg+AA8iny4DQ/yEmM6ZxbeD3k8FF7eNvNQdqQwinHN?=
 =?us-ascii?Q?K/enez6PQmEpGfiybSBqcuduee8jAwY67b8fDemrqHXAxY3ONDWjylO+di5A?=
 =?us-ascii?Q?u/ACUbqHzWDPEJi+l280xfY6A6UqDWUH3Iaed+b8oIJemy590t4IvXFAmhRZ?=
 =?us-ascii?Q?vXZDMje92WEKqN8SEZK+DWvUWDvsePnMqeFEnNzxtVEAGFCuJBrlek6K2+M5?=
 =?us-ascii?Q?2AJDhjrLA9WHLS9HkJpMA4n3Txopmqlr2GSU50Hj5iJt/KNgTqy6lyNbzE7O?=
 =?us-ascii?Q?11WBaOTv6bRHDSKrZxp0Lsu3YrApWRbkYnYH5789KoUpxj5EFe0f6jLMHILk?=
 =?us-ascii?Q?/LrH4LkZCJ4nCx6F+EurnTGHliGQaoq0KCvXS059tI+T/80TM5g1yzT4bbaf?=
 =?us-ascii?Q?er7cXfQiKmqfb9Zxum41IY6E9IQEL9hFWfOA1FXEgDNZsnMu+UZkZILaa+CZ?=
 =?us-ascii?Q?GpXHN+6pJ5Z5TZ2xv3qV7DncljhFWLMnB90z5b1H68BsrEbJir6OX+yTGUWy?=
 =?us-ascii?Q?SL1Ewnyo/fBwPDVuk6lxg0sTvTPLd7Fw1Hjqt203UA75hg190IYOWusdnh3+?=
 =?us-ascii?Q?tjNv36D8ioNJNr1jRDXecJ0dRVb1AaEWwMNHGcTGWzD1lWv8SyMphyadvfkw?=
 =?us-ascii?Q?Jz5CAcQd0gEfAd3wzkdNgI7ioTU6j5U38jUqChLrIlAy6xmqAPHBxpLqxdpS?=
 =?us-ascii?Q?OwsXoBKAZyAsoixL8wnozvLpsqRkfCshL+IxxCiURCGWvvAlEil9lWQmMOQ+?=
 =?us-ascii?Q?JWCYrkrd9kV4Esd8/6gGFLBflJufG/41dEsAB+dfw2l6FbJi87x1itPyk5H2?=
 =?us-ascii?Q?kE1f9ZWWq2NYKFb2nT8TZqC9BZcQ/CP9MVKZp7vvU1EoEcjwIQ7SYB/kNpAN?=
 =?us-ascii?Q?fVvjRRU35TKlaaup3jxUf/Sd3ZlHm3iVOsWpcoNXC3S2TzKF39Yr1Tbop4jh?=
 =?us-ascii?Q?I/6YJY7hlUAnt3Yyj0ucoUOLBfhKRfQcC8P1kjD1zDO/n1CQr7O7LaWHf+2h?=
 =?us-ascii?Q?jv3nYfTjXiiSuoxuOE0lvL7JIvWXGx+10PTuNXaHviapNaK9HCM9+ZvMKapr?=
 =?us-ascii?Q?oA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Av65hvq9+OPBzaxNEtc1E2Q1dKowb0Hy7P7NiuDuQI6MVVudyh8Ww40jhLF+ev0xKjJdDXZe78GgHzjOcRJZMMc4EQmLKhMJKv47BLYyWRopkmJWuSHiTdGGudUjszUQwNgKo9YtGCTtX9H3QhuF5jTL+uqsWazLZPq37X6fQYI/d4GfQ4cWElqkA4RqTGRejVgsrbMY3qPFcsmSYmLY8xvwnjB2U68qt03Lkt7cFMHdF8GQGBDql3fiaYniWl6MEIk7jt3xW5aHjM6fmlmzaEqqfqmuqcuvhmb7JxASdXMHBZX2dtXTW1QRnjtVCTD0tiyP1rWFb2XEN00jsuHZXuuiHzmZNj2BYrF9Tz8GwHk4ZwgXktTwTZMYGUlRnJhedtHCSeDqLooEmYeX6XEuaw+EAhGxwKFgOBzeCFS7cUccsjK9e6y7Qsl7OpZnINM03sgLH8xXvtDLJesjh4dFV9VDpjWkItRDLlwDDNwYZnnDCJDFkf6ElobNGyLo41MD2yp0n8rccRo5dciAanOXPunQmrifxk48OEQvgEMCSlc126Eow5F9KGq4X15hh7hcvLi8eQkSryxduWXz1btKUYOS15x6et1e7k+pKZOmqTX7NsoL2QNBeG6UCwi9HYpCMMBkRioK3w1hwzEpeALUXAjj4hnodK+qwJ7PTLk/j5nf+cOP+4gXAPk0bq/U7KX9kOGNV4N22KXDORNAx+TFipzjc7ZWLt6Cxg+ERmKhuxV/+78bJI3h4s8neU9AYHLj1D8OmDXuws5rLF3KaGC3oFTVT6TmNnkZMirAhfwZp49nApEQTPWI3KtTDCgl5ebBmQ9GZRZOfzz0BfH/XCr5R1X6p4YRimrt48OmWizOLMM0v+6UMWEAwixbe8CnONdyanK2iq5xWzJmHLouZ/r/Mg==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af8f8780-4ed8-4c0b-fc11-08db4596df2f
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 14:10:49.5911
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ujusue6qwXfe72NXNjKIlRucHkFi5jA7UXaPmdMdnTGksPUB1NL42su4Fi91GQ1ZslyYuIX1th22ljjA+sMhtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR10MB7650
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-25_06,2023-04-25_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2304250128
X-Proofpoint-GUID: YCXe04Qa-LOInenH3wgc7AjEM7OMjHEf
X-Proofpoint-ORIG-GUID: YCXe04Qa-LOInenH3wgc7AjEM7OMjHEf
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

mas_store_prealloc() should never fail, but if it does due to internal
tree issues then get as much debug information as possible prior to
crashing the kernel.

Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 lib/maple_tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index b8b8e5d9ed7e5..28853ed23fe8a 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -5762,7 +5762,7 @@ void mas_store_prealloc(struct ma_state *mas, void *entry)
 	mas_wr_store_setup(&wr_mas);
 	trace_ma_write(__func__, mas, 0, entry);
 	mas_wr_store_entry(&wr_mas);
-	BUG_ON(mas_is_err(mas));
+	MAS_WR_BUG_ON(&wr_mas, mas_is_err(mas));
 	mas_destroy(mas);
 }
 EXPORT_SYMBOL_GPL(mas_store_prealloc);
-- 
2.39.2