Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 16:17:45 +0200
Message-ID: <875y9kujue.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Reaper Li <reaperlioc@glenfly.com>
Cc:     <tiwai@suse.com>, <perex@perex.cz>, <linux-kernel@vger.kernel.org>,
        <alsa-devel@alsa-project.org>, jasontao <jasontao@glenfly.com>
Subject: Re: [PATCH v2] ALSA: hda: Glenfly: add HD Audio PCI IDs and HDMI Codec Vendor IDs.
In-Reply-To: <20230425101524.8020-1-reaperlioc@glenfly.com>
References: <20230425101524.8020-1-reaperlioc@glenfly.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 25 Apr 2023 12:15:24 +0200,
Reaper Li wrote:
> 
> From: jasontao <jasontao@glenfly.com>
> 
> Add a set of HD Audio PCI IDS, and the HDMI codec vendor IDs for
> Glenfly Gpus.
> 
> - In default_bdl_pos_adj, set bdl to 128 as Glenfly Gpus have hardware
> limitation, need to increase hdac interrupt interval.
> - In azx_first_init, enable polling mode for Glenfly Gpu. When the codec
> complete the command, it sends interrupt and writes response entries to
> memory, howerver, the write requests sometimes are not actually
> synchronized to memory when driver handle hdac interrupt on Glenfly Gpus.
> If the RIRB status is not updated in the interrupt handler,
> azx_rirb_get_response keeps trying to recevie a response from rirb until
> 1s timeout. Enabling polling mode for Glenfly Gpu can fix the issue.
> - In patch_gf_hdmi, set Glenlfy Gpu Codec's no_sticky_stream as it need
> driver to do actual clean-ups for the linked codec when switch from one
> codec to another.
> 
> Signed-off-by: jasontao <jasontao@glenfly.com>
> Signed-off-by: Reaper Li <reaperlioc@glenfly.com>
> ---
> v2: add some comments for code and details in the commit log.

This is almost fine, but could just correct minor warnings
scripts/checkpatch.pl complains?


thanks,

Takashi