Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d18ec8d3-afc8-3a67-54d3-de30108cf733@intel.com>
Date:   Tue, 25 Apr 2023 07:28:43 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v2 17/24] selftests/resctrl: Replace count_bits with
 count_consecutive_bits()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>
References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com>
 <20230418114506.46788-18-ilpo.jarvinen@linux.intel.com>
 <455c986a-0d51-0302-d5c3-c6c0f1cc6bad@intel.com>
 <7bb3f116-2f4d-b81a-3f49-dae7175e82c1@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <7bb3f116-2f4d-b81a-3f49-dae7175e82c1@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3ZYbFdYRGJudmkzZDArT3BCWVpwbHBxdDJldzJ1aUJQOE5mWmhzMXdvV3hS?=
 =?utf-8?B?dVYzK2Erd2U1NDlUTXRkQmhZdkxpWWRMVzVpRFVnazRSQldOQzlGZUpKeW9F?=
 =?utf-8?B?ZXBIV1FvVERmYkhsN0lnWEF0ZFF6QlJtQXVFb3dwRmFxT20waE1KKzhlQU1Q?=
 =?utf-8?B?c3NQdXBwS1dKL1pER3pVbUUrM2Q1SGlVWFI4WFQvSGxkd05EOVBNekUwbmRy?=
 =?utf-8?B?Z09zbG9hKzJOdGVFZ0I2clhCdFdGTXBKSmtWZWxHbkZhT1NCVHlxYWFXWFNu?=
 =?utf-8?B?MzFaMWpva0NYdnNEUkc1NWsyTFYxMW9lenBOblZUUUdETkFRT3BHcS9rWDBC?=
 =?utf-8?B?RXdQN0NxV1ZPWmlNODhvck42VUpVM0pKM0syOHA4MFY5eDNwYlFjSGk0SDh5?=
 =?utf-8?B?M3lIZ2dueW51SlJIS05QZUZLUXM4dU5QOGJ1MmNZM3BhOEpsVDg0bkF4OS9a?=
 =?utf-8?B?enB6aitzK2Rrd0gyOFNUSW9EMDE5MGkvby8weldNNlVpcGZKSFo5eW9SSzEz?=
 =?utf-8?B?ZHVHakVGb1pUdkxzYmdteHJCU0drMDBOZVhRUm5La2pPUTIrRDh4T21QYXJT?=
 =?utf-8?B?NHI4NHpReU5MTGFmUU9pL08ydjJGbWZSdVRFOElNbXBYbTBJQVR5QmhjR2lP?=
 =?utf-8?B?bTArdnhBNUhXaEdQNTV1M1V5SDZ6OHlBa3ZyQkRKOVpBZktoNkE2NlFVTFJJ?=
 =?utf-8?B?dVlXYlVSUWdmSlBXYjlPMk91STNlVjR1cFJKdWYxbUlJVFF1eFZGd0s4OHg4?=
 =?utf-8?B?aWY4Y0p2SUVJZnM4QTY3ZTVWN0pLNWtNWHhZWW9oMURWQmlXVWpzMGtqSjFk?=
 =?utf-8?B?Si9pZEMzNXBmSjZlTW54d3dwNkQydGl1c2VRVDh3VFNrVEpVVG5BSCs3ejJV?=
 =?utf-8?B?U2RMbGxJVE1FSHQ2eWUvSTNUSUhqNU9NZWJyc1VscHZxZjlydUc2NDE2YzUy?=
 =?utf-8?B?ajlncWpHOCtxY09zYUloaU85MGtoQTdNemhHVksxQ2hhVUFYaHJxN0RhNFRo?=
 =?utf-8?B?SDJTMW1ETXcwOGttVU82L1pSVHF0ZU13RFFWdzE3TXBrdmtaZzBsVVlCd3BU?=
 =?utf-8?B?SGlrbjVQa25HdTBDS3dicW9VcEVXbm9LV1ZGRlczNzJSME1WK0ZuK3JDYiti?=
 =?utf-8?B?VmlQajVRMkRmMDlHK1JNbHIwUWJ6UWNxS0llQmJ3MUdTaDBzYUZHbTdxR0ZO?=
 =?utf-8?B?RW40aTloVitkUE01ajBNYU5vNGtpVnRISFNTWjJnWDZoVWUwTzBNMm4rdjVl?=
 =?utf-8?B?OEk2dng0VzVoTFAxVHFCd3ZwdW5qSHNPdWdGVVFoSkZpZUF2SE1vLzhjSW5t?=
 =?utf-8?B?bm9vK0J2ZCtla2QvUVdjT3FhcFFjSFpoRHczNHQrd3YzT1ZzWXQ2U3NIcjZl?=
 =?utf-8?B?Q2VKSUlnbVpSMXdWNGNyeTlJUlZtR2dYVXlWQUxPK0t2cDdHdFcxc2ovSldK?=
 =?utf-8?B?S0NHQTVRTEV2QWhrbURWWjk3MVNjcUpVZ3lES0xxMWhubzR1c2E5MkduRGJE?=
 =?utf-8?B?c0wzUVExamhhYzJyUGZ4ekNsUlhCSFM5ZEx5bCtxZ3lURGo2ZythY0xPQ1po?=
 =?utf-8?B?Z2Fkbjcrb3NaR3FYZkJaNG0vTjdQRTUzNFE5aVdBeFhGQmUwcEN2dU1wRFFL?=
 =?utf-8?B?T1BvRUxKK1ZZNjA5T1hPZ1ZuVmIwQkJXZGIyb0lwbDVrSU53WFVTNG1STm9Q?=
 =?utf-8?B?NkFFL1dCY2NEa3drcXR2YlhwUkdHbWNQdW1EaUo0Z2hWS2h3QXBoR2lyYUpU?=
 =?utf-8?B?QzRZeng2cE41NmRiVllWNGdSWlgzSTYvWThPdVJ1TFRKdXlBUXd0di9IK1A2?=
 =?utf-8?B?TVcvckVjYzEvRkZrV21BQTdud001a3MrQTFHK0lYaFdzTnY3UlhKRTM4cHpW?=
 =?utf-8?B?dUdzQnRhVGFDcVN6TmNrTitwL1AwUXJoQS9UTHo1Smg1WURFUmU3enN1MTlx?=
 =?utf-8?B?TGNGRWR4bndTWUkvZ0xQWUV5ZDZnbXdNWHppRk9JaWtGbDMyQWxtMjdSbnZr?=
 =?utf-8?B?TmUzU1R6bC9EL3hWZC9RMFF2UFNEMnljbTJBVnRiQWtuOUhhSWQzRFo1M3px?=
 =?utf-8?B?V2ZPRzNVREdvbW0wNEEwR2daNFBqT0hqMVBMUTQzUURTOHpIQ01FUjJQTFFN?=
 =?utf-8?B?NmtWWkJBRWMwclg2cGRpQW1TRFl1dnBTUUpBZ3MxRmp5ZkF1K2VRWEk4NXJT?=
 =?utf-8?B?cVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd577847-de10-479f-3684-08db459960ed
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 14:28:46.3571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JFa0BV4Nqgb2h/KGTjT74QRShuydZVbVHmI5Gjg3LAKNgLWMCm/h2aVd71lnYhVPZT4WhLkL/pZbTWGlzxLYfEnwUwptAU+XQSdsC0zeEM8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5174
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 4/25/2023 4:41 AM, Ilpo Järvinen wrote:
> On Fri, 21 Apr 2023, Reinette Chatre wrote:
>> On 4/18/2023 4:44 AM, Ilpo Järvinen wrote:
>>> CAT and CMT tests depends on masks being continuous.
>>
>> The term used in the spec is "contiguous", using it here
>> may help to convey the goal.
>>
>>>
>>> Replace count_bits with more appropriate variant that counts
>>> consecutive bits.
>>
>> Could you please elaborate why this is more appropriate and
>> why this is necessary? What is wrong with current solution?
>>
>> Please note that cbm_mask in resctrl will always be contiguous.
> 
> Hi,
> 
> It's good that you asked this question.
> 
> This comes from a change (not by me originally) that also excluded the 
> shareable bits from the mask the CAT test uses. I assumed (w/o better 
> knowledge) that those shareable bits could create a hole into the mask.

You are correct. Shareable bits can create a hole in the mask.

> 
> It could be wrong assumption and the shareable bits are always at one end 
> of the CBM mask.
> 
> Do you happen to know how the shareable bits are positioned within the 
> mask?

This depends on the hardware. Software learns about it via a bitmask (as
opposed to "number of bits") so the hardware has flexibility to communicate
any combination of shared ways.

These comments are not related to this patch though. I understand that
this patch has been created in support of the changes that follow. My questions
are related to this patch that communicates that it is "more appropriate"
for what the code currently does without consideration of what is to come.
I would like to understand how this is more appropriate. Also note
that cbm_mask will always be contiguous - in this case the hardware
communicates a number of bits, not a bitmask, so this will always be
contiguous. This patch claims that the current solution is not
appropriate to parse cbm_mask, could you please elaborate why?

Reinette