Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <a1e940aa-7ede-572a-80ca-d950273e5ba6@roeck-us.net>
Date:   Tue, 25 Apr 2023 07:34:25 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Content-Language: en-US
To:     Neha Malcom Francis <n-francis@ti.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        jdelvare@suse.com, linux-hwmon@vger.kernel.org
Cc:     nm@ti.com, vigneshr@ti.com, u-kumar1@ti.com, kristo@kernel.org
References: <20230424105011.70674-1-n-francis@ti.com>
 <aabe7488-29b8-895b-38b8-67e5a7d1dd35@roeck-us.net>
 <705557cd-0a60-3cda-d78b-d78e2faef856@ti.com>
From:   Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH RESEND v3 0/3] Add support for ESM
In-Reply-To: <705557cd-0a60-3cda-d78b-d78e2faef856@ti.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/25/23 01:49, Neha Malcom Francis wrote:
> Hi Guenter
> 
> On 24/04/23 20:27, Guenter Roeck wrote:
>> On 4/24/23 03:50, Neha Malcom Francis wrote:
>>> Resending as no major changes, commit subject change only.
>>>
>>
>> Maybe you consider changing the subject of the bindings from "misc"
>> to "hwmon" as not being a major change, but it made me aware that you
>> are trying to sneak bindings which in my opinion don't belong there
>> into the hwmon bindings directory. This is not a hardware monitoring
>> device, it doesn't have anything to do with hardware monitoring, and the
>> bindings do not belong into bindings/hwmon/.
>>
> 
> I understand, it's a thin line across which I pushed ESM into hwmon; my reasoning was ESM also actively looks for signals that it aggregates, and is overall monitoring the device health. But if there was an option, in order of fitting: fault/ > misc/ > hwmon/
> 

That is really a stretch. It doesn't monitor anything. It is a signal
routing mechanism.

With that logic every transistor would be a hardware monitoring device.

Guenter