Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <877cu0827a.fsf@oldenburg.str.redhat.com>
In-Reply-To: <877cu0827a.fsf@oldenburg.str.redhat.com>
From:   Ian Rogers <irogers@google.com>
Date:   Tue, 25 Apr 2023 08:18:23 -0700
Message-ID: <CAP-5=fWGUcCrq0rHc0YRGWsgyXZDEAo03MaXXbR46Q7KZ3=-qQ@mail.gmail.com>
Subject: Re: [PATCH] perf: Avoid implicit function declarations in lexer/parse interface
To:     Florian Weimer <fweimer@redhat.com>
Cc:     linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Justin M. Forbes" <jforbes@fedoraproject.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Apr 25, 2023 at 7:29=E2=80=AFAM Florian Weimer <fweimer@redhat.com>=
 wrote:
>
> In future compilers, -Wno-implicit-function-declaration may not bring
> back support for implicit function declarations, a feature that was
> removed from the C language in C99.  Instead, declare the yylex
> functions using the appropriate argument types.  The solution chosen
> here is not ideal because the prototypes are not verified against
> the function implementations, but the way bison and flex generate
> code make it difficult to share the prototype.
>
> This change should prevent build failures with future compilers which
> no longer support implicit function declarations by default.
>
> Signed-off-by: Florian Weimer <fweimer@redhat.com>

This seems non-standard. Isn't the issue that we're not including the
appropriate <...>-flex.h ? The use of yylex for the function name
obfuscates this a bit. For example:

pmu-flex.h:
...
#ifdef yylex
#define perf_pmu_lex_ALREADY_DEFINED
#else
#define yylex perf_pmu_lex
#endif
...
/* Default declaration of generated scanner - a define so the user can
* easily add parameters.
*/
#ifndef YY_DECL
#define YY_DECL_IS_OURS 1

extern int yylex \
              (YYSTYPE * yylval_param , yyscan_t yyscanner);

#define YY_DECL int yylex \
              (YYSTYPE * yylval_param , yyscan_t yyscanner)
#endif /* !YY_DECL */
...

Thanks,
Ian

> ---
>  tools/perf/util/Build          | 2 +-
>  tools/perf/util/expr.y         | 1 +
>  tools/perf/util/parse-events.y | 1 +
>  tools/perf/util/pmu.y          | 2 ++
>  4 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
> index 918b501f9bd8..4a3ec6b0bbf6 100644
> --- a/tools/perf/util/Build
> +++ b/tools/perf/util/Build
> @@ -283,7 +283,7 @@ CFLAGS_expr-flex.o          +=3D $(flex_flags)
>  bison_flags :=3D -DYYENABLE_NLS=3D0
>  BISON_GE_35 :=3D $(shell expr $(shell $(BISON) --version | grep bison | =
sed -e 's/.\+ \([0-9]\+\).\([0-9]\+\)/\1\2/g') \>\=3D 35)
>  ifeq ($(BISON_GE_35),1)
> -  bison_flags +=3D -Wno-unused-parameter -Wno-nested-externs -Wno-implic=
it-function-declaration -Wno-switch-enum -Wno-unused-but-set-variable -Wno-=
unknown-warning-option
> +  bison_flags +=3D -Wno-unused-parameter -Wno-nested-externs -Wno-switch=
-enum -Wno-unused-but-set-variable -Wno-unknown-warning-option
>  else
>    bison_flags +=3D -w
>  endif
> diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
> index 635e562350c5..e5731da2e3d9 100644
> --- a/tools/perf/util/expr.y
> +++ b/tools/perf/util/expr.y
> @@ -53,6 +53,7 @@
>  %destructor { ids__free($$.ids); } <ids>
>
>  %{
> +int expr_lex(YYSTYPE *, void *);
>  static void expr_error(double *final_val __maybe_unused,
>                        struct expr_parse_ctx *ctx __maybe_unused,
>                        bool compute_ids __maybe_unused,
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-event=
s.y
> index be8c51770051..9dbab19885f3 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -18,6 +18,7 @@
>  #include "parse-events.h"
>  #include "parse-events-bison.h"
>
> +int parse_events_lex(YYSTYPE *, YYLTYPE *, void *);
>  void parse_events_error(YYLTYPE *loc, void *parse_state, void *scanner, =
char const *msg);
>
>  #define ABORT_ON(val) \
> diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y
> index e675d79a0274..8405f9e6535c 100644
> --- a/tools/perf/util/pmu.y
> +++ b/tools/perf/util/pmu.y
> @@ -16,6 +16,8 @@ do { \
>                  YYABORT; \
>  } while (0)
>
> +int perf_pmu_lex(void);
> +
>  %}
>
>  %token PP_CONFIG
>
> base-commit: 173ea743bf7a9eef04460e03b00ba267cc52aee2
>