Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7147034rwr; Tue, 25 Apr 2023 08:42:01 -0700 (PDT) X-Google-Smtp-Source: AKy350az/gzqz7hcos4bDPDetoQAl7P28Z242EfCl4KxUApnlKOYDUHOoz2tlJT8Zrd1Go7WLx2N X-Received: by 2002:a17:903:32cc:b0:1a1:c7b2:e7c7 with SMTP id i12-20020a17090332cc00b001a1c7b2e7c7mr24194687plr.49.1682437321272; Tue, 25 Apr 2023 08:42:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682437321; cv=none; d=google.com; s=arc-20160816; b=Lto8Fk2JHTmhBHbRmkzw1w246HSnl4ChNeGzpVBZW6EPTkJ9NFiG3wv1dGsiMF1UtI oYZcxLxc9zO6pxiypOg6k13iLwU0YxueuBK0olYvChI4Mc1/TmoyeKEa0+q9nVwNdk3J DRp3xEvao/6NsDh+2VKXrKDkDkzk4MMusxWlGHOu45w5X0yHWV2YSn7A28hYrZj4ei1R 62xKJGfsCeh3wtFUcMkoxNuK30ZUJW4gzuyFmwmSj1ddrk2rQvJTp592hLoKyEcsGO6w usKXH2d/55mw+7I8MACghuS2gqn1prVH25GjgZU7JEail6xGJkhIpRHfD30B1B9gs3am xy3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=EptNifvCTtH4xQjD1ULDPRgLKZN0staJV3aCia6vMJU=; b=wlpBLZciuGy4atJpXnKnhiuxEpaYQF/SIqjZjsRgneN4qElnv1ML97kO1pDVA6sCJ+ 56c518IADrQJHaaYiT5F5yXoguQBIF81VwI7w/pv97v2kXf1yiuICLnJWrIjoOsEWepF 83xuBKZzQGAIKLXbwwOio5uwaUAAehtga1dCQq3P8AC1yMZxhv1eQFWcpiMaBmKMBApE eTxekWKORCoWlqeIqEg0o4HsbkH4Xmm3/ezLGyS6h3vHbUDSLnszf1Tx81c1KEHF4HlX +1LJu0N5GPNXqFI4+5wOf/V4/TEIiBU25MzUd+amRkqCzeA5DjrO5VGLg6rDyDeu+sfD ZVjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZHVzhAmI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o15-20020a17090ab88f00b002468b82d179si14152172pjr.8.2023.04.25.08.41.47; Tue, 25 Apr 2023 08:42:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZHVzhAmI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234540AbjDYPiq (ORCPT + 99 others); Tue, 25 Apr 2023 11:38:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233959AbjDYPip (ORCPT ); Tue, 25 Apr 2023 11:38:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF076CC39; Tue, 25 Apr 2023 08:38:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5A563625B2; Tue, 25 Apr 2023 15:38:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69D0BC433EF; Tue, 25 Apr 2023 15:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682437123; bh=vT2ctdarV+29c2RVxncwRb2R02GQQfX40TXp5B+gZds=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZHVzhAmIh3NxezUn1x3PZtgG2gVM/Y3wbHRPaR/XluM4QN4x+pGsLn5kqymU//TgF s0WblkuUm26H1uuQkWFrZb4RcaD7bClDE262jJJJQhjck5xw6WNcy3STIUuWSSyw1C UkCnBm9jMO8TBknRqdfbo1fQcl6zMJJDdF1Zy3EfTCN9mMyLBYZ5o+pui0ZRBkKcoL mOIxqxjxZYNfH7uU3Wa2JhGMouVuMuAoNILv8AnLEUVHfcNLFrIKnMgVCkXQRdWDZH N0a0GSfj/7pQJHbBP7trzl51s2F5ts1nj5gbUDzy0awAYQBddQOk6GxETdrgOnurJC Kg5XK+YpA8GJg== Date: Tue, 25 Apr 2023 08:38:42 -0700 From: Jakub Kicinski To: cchoux Cc: sam@mendozajonas.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cosmo.chou@quantatw.com Subject: Re: [PATCH] net/ncsi: clear Tx enable mode when handling a Config required AEN Message-ID: <20230425083842.65873403@kernel.org> In-Reply-To: <20230425133014.1203602-1-chou.cosmo@gmail.com> References: <20230425133014.1203602-1-chou.cosmo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Apr 2023 21:30:14 +0800 cchoux wrote: > Clear the channel Tx enable flag before reconfiguring the channel > when handling a Configuration Required AEN. To avoid misjudging that > the channel Tx has been enabled, which results in the Enable Channel > Network Tx command not being sent during channel reconfiguration. > > Signed-off-by: cchoux Please add a Fixes tag pointing to the commit which introduced the problem. Please use your legal name like you would for signing a legal document (all UTF-8 characters are allowed). -- pw-bot: cr