Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Tue, 25 Apr 2023 18:09:01 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Roman Beranek <me@crly.cz>
Cc:     Chen-Yu Tsai <wens@csie.org>, David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Frank Oltmanns <frank@oltmanns.dev>,
        Icenowy Zheng <icenowy@aosp.io>, Ondrej Jirman <megi@xff.cz>,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/7] clk: sunxi-ng: a64: propagate rate change from
 pll-mipi
Message-ID: <eyhlequ4hldyvtjqi5ouvbozmjeqqve4jcvgdtvktf3tqmwqjf@bqvjcu2kxajf>
References: <20230418074008.69752-1-me@crly.cz>
 <20230418074008.69752-2-me@crly.cz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="drnscjmrlojh2hnd"
Content-Disposition: inline
In-Reply-To: <20230418074008.69752-2-me@crly.cz>
Precedence: bulk


--drnscjmrlojh2hnd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Apr 18, 2023 at 09:40:02AM +0200, Roman Beranek wrote:
> Propagating rate change from tcon0 all the way to pll-video0 allows for
> greater precision in matching requested display timing.
>=20
> Signed-off-by: Roman Beranek <me@crly.cz>
> ---
>  drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-ng=
/ccu-sun50i-a64.c
> index 41519185600a..dd6212286dcd 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
> @@ -179,7 +179,8 @@ static struct ccu_nkm pll_mipi_clk =3D {
>  	.common		=3D {
>  		.reg		=3D 0x040,
>  		.hw.init	=3D CLK_HW_INIT("pll-mipi", "pll-video0",
> -					      &ccu_nkm_ops, CLK_SET_RATE_UNGATE),
> +					      &ccu_nkm_ops, CLK_SET_RATE_UNGATE
> +							  | CLK_SET_RATE_PARENT),

The OR should be on the previous line

Maxime

--drnscjmrlojh2hnd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZEf7HQAKCRDj7w1vZxhR
xUnvAP4yDrqezoLe1dBxve+9KckvqmP5apjHhhVINJc5nbFIlgD+Pf04BAirUXFu
I2LHFHnGnYXeBu6+yR/jrJs6uxw9tAM=
=slla
-----END PGP SIGNATURE-----

--drnscjmrlojh2hnd--