Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 12:16:33 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH 5/9] maple_tree: Remove an if statement that cannot be
 true
Message-ID: <20230425161633.6kg3h242lo4xwnhl@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org
References: <20230425110511.11680-1-zhangpeng.00@bytedance.com>
 <20230425110511.11680-6-zhangpeng.00@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230425110511.11680-6-zhangpeng.00@bytedance.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3w3IR0yhc5XeK8Fia4UxR58uywUkKUy+fkJwP0wkxt6uK3kqGMtm+GJ7wp5G?=
 =?us-ascii?Q?ABnuLvhJKCJ9LnvDeMWq+P7WF+4znOBDCIMSf/jX5dxxmbo2y8MatG94Wl0S?=
 =?us-ascii?Q?LaemO5i/Aeznxy4DusvaBWm4irpzQNANmbH1yVXnryBFyMI4apkiNoFwOdoD?=
 =?us-ascii?Q?EOyiBzfwaxRBLdgFvjfaH2OxIpH3zf3ak1C47s5k1pN2rtTMDS8NX1Xeqyqv?=
 =?us-ascii?Q?CVL6PmhSIJiQ8dRQOSYk2kqheZg9ASqTDe4FF13cvDkajbq1hYT4PZuzQ/kY?=
 =?us-ascii?Q?FIxO4u7DBcL/eCbR1yOncm6PAHMR1uBsBqiaMODL5FFOtwKhkG39MNN6z549?=
 =?us-ascii?Q?XJe6OzmW8s50dvFwh5TKKgtasS+WHtEkKLE9QelravImwt+IOIySCxe9LIel?=
 =?us-ascii?Q?cQvOJ+xl0YMUZE8AYggIDTyFHkOlpl+QDPbsD7XXJ1LKZDmD4t1ugbteeHy1?=
 =?us-ascii?Q?r92/J6Tj6T0x3vdPg8E0ZrwUrBJ/qWobHU4p7sA9113i1Gc99bxkfhxMSfxE?=
 =?us-ascii?Q?0YBG1f5ifBGbibJ0gTsFcs1f9jQmzihnRmU8ucK8qfyMXDIo03dbuOXPhFFe?=
 =?us-ascii?Q?wNle4V5Wdf0nIw6SSJTGEqCghxcAjXc/WwWZcjPgCNif1kt4LC/rBxb3vub5?=
 =?us-ascii?Q?pVReW9VsAz11TrBU4/daOMy+kupjAVkc5RgOIPvhhq0vy5oKzZdZrtM3NyOj?=
 =?us-ascii?Q?Ox0Yx5W6IDsctosuukO9adVeHAu6G/XEeZPHUOrOgnMjadOZ9u8Dq4JUROfa?=
 =?us-ascii?Q?/Z/EqzZYu6Ay8YTON7H7O1bxBOjmdz83a2i/10DpwSxHYe4jcjjGBXSnYpCL?=
 =?us-ascii?Q?dAVSxXUx5H9RPQ9bJLUHOWzzeWVJakDDT96TViHQeG+sG7VonxVsoXJX6tnG?=
 =?us-ascii?Q?WSzS5w12w9eQttQoCHk6yI8BWduNL2y9aD7L5KIJLfB9k6Ub7C5D4oZW1tk0?=
 =?us-ascii?Q?sfG911dGO2ioO7omPgUBg7r1BWJssKWJLEXsRtDVYMbabYqvhZrOwwXTeh4u?=
 =?us-ascii?Q?e8FaCOqCVspDWw/0j9K/mO4iu9vPbp5eElstnIfVTPhu0OgjPlWv615sWLBn?=
 =?us-ascii?Q?HpaR/JyaYUArxt7OY+ZZGh8fr0a71mJgdSA7dApFWEwE32Xa1awlk8/Q5p8Y?=
 =?us-ascii?Q?z9h4Mxxj2aj56mKVyJMAjZu0KQmtHzWnQUWvPOyG5C1lRSyJMY5yjkwKt+ZV?=
 =?us-ascii?Q?WBZ/Nvk8OOVBZ7qHXJEjVuLBNmzeFmnN4Uc4O2Le6kP9YuYEYYZ6uoiWd3TK?=
 =?us-ascii?Q?IlxCtilvtVVfqQblda3bgsossM6I7JfQEqmDlGpYhmB4VIIRtprYpN3HP+8P?=
 =?us-ascii?Q?MefxxujPYS1chrlMUrqS3pndQZzNgwfmw4eSw3aloY5n9xrgofPJmQJ3N/q7?=
 =?us-ascii?Q?u4Uy1B+TD+lW6CTwnfosRf20rAtdEiCFIGfOdoqsNcWImmGDEd9uU+96U9Tx?=
 =?us-ascii?Q?Us+QrtDUgyORpMgUyOnKvNbErxRZUPszxay8AGVNKNgTLCsJNXFZ58mWH/nh?=
 =?us-ascii?Q?ASBNUuIh9OYHBVH6ZLf14t7oAaSf/nvrJJJEFbOgTM2i4AjFD6ee8B7iOYQq?=
 =?us-ascii?Q?AlWnIhuJt31dWEoX+K5RFHhX76wmsq6uI3KUi4NeSm6gm+3JY6+mivahIfMZ?=
 =?us-ascii?Q?TA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?YMRBG1xYKd1nDwBBaMnZL2OMD9qbkXU0bEMRPRGHuGjmP8YhxKIVcxoeE17z?=
 =?us-ascii?Q?N4T5BCpZCWVTU7zBfGFLUXSAWHjFEQNY3fR+Rbcl2Wrez0qfiGbpv7krZEyd?=
 =?us-ascii?Q?Zm9uJIcxm/yzUF1HPuasuAUFAYF8rxjqBmCYLr/ahHH6Z4JcPC1DzdVNdj/J?=
 =?us-ascii?Q?ij+KFluAhoazbeJzhKsMUfU3AdrlaGVHM2jGc+cAPKHQ/IGKehRk8WguypeZ?=
 =?us-ascii?Q?S2QAgjla3dYKM5NjWtIOuXHH3S/LwfPoPE9E+iP/dt/w5kTpklaUOJBSCITg?=
 =?us-ascii?Q?8uHEneE/VAZ5urTJdjVvLRPhXm4UsunCiaQKrKm7Jipn3owWDOWQAwDGhLBe?=
 =?us-ascii?Q?TbZLXWvlKfSVpXdXysq52Dn5Ds4TPH4rMO0qdOcwwZsVkbJZgap+7eXtjHUp?=
 =?us-ascii?Q?6PyiA7Ik0t/yUxpYBE6gbmVKJinQsHRHeMkpxDW7SQZTxyYFdcIPvzS3HVrH?=
 =?us-ascii?Q?vFS4DwrxbiJZEgVnG/2ag/yX6r3f1tIXb40FMSNBUUk2BoWXzQwKGbF2qrKr?=
 =?us-ascii?Q?+7oOu5xQ0n4H4wVAf5j77OjMn012n6yK49sNoP5Cf+5vpy8lk+VbyYd3UR5U?=
 =?us-ascii?Q?UApIkmFW1GvwSB74MiqI9/fcp7aZCq7i95frG7bZDwX5Z9F4btpAPHZiN7Hm?=
 =?us-ascii?Q?Hbqak1xF/fnqVOCKMQprbNxKZ2bkiN73QXfBi0IBQklCKpKkTD/AxFDWTR57?=
 =?us-ascii?Q?59WoZb4noBPBST/DPEyKZzz8gr05+TWMbunlI+rlKTQPraQxEX24qzI1sVJu?=
 =?us-ascii?Q?gKO19+UmajLembYd2G1hZq+8/xr6mQ+BRSng+e6wL97jkEYDMDlY2Ie2e54k?=
 =?us-ascii?Q?y9VRzFN+Nn61sqcaNBsPee+2KYysE6qQMOOFLdXClJmmTkcF49a9x3g4zuNk?=
 =?us-ascii?Q?AYLOTNUyheZDrN9ZbTOKYYdlCjmur+cFXHyzBZhwYS2WB/G6sfstlI7qc1xV?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17104d3c-b7b1-45b6-ddaf-08db45a8715e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 16:16:36.2913
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wbe63s6oZhcpEDF55cs8NoSosr1Nh0E+QnM70Ei9UfT+v8UD4hVP+iixicjpurEgV7ipLzMmSXftKydCNDvSTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR10MB7541
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-25_07,2023-04-25_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=918
 adultscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304250146
X-Proofpoint-GUID: rxrLnmATcaEliHPjxipIi6LNwmY34vcr
X-Proofpoint-ORIG-GUID: rxrLnmATcaEliHPjxipIi6LNwmY34vcr
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Peng Zhang <zhangpeng.00@bytedance.com> [230425 07:05]:
> Because the commit 06e8fd999334b ("maple_tree: fix mas_empty_area() search")
> is merged, this if statement cannot be true, so delete it.

Please try to focus on what you did and not why you did the change.  You
did the change "Because of the commit..", but that's in the git history if
someone cares to find out.

> 
> Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
> ---
>  lib/maple_tree.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 294d4c8668323..7f4b2ce84ce61 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -5084,9 +5084,6 @@ static inline bool mas_anode_descend(struct ma_state *mas, unsigned long size)
>  			return true;
>  		}
>  	}
> -
> -	if (mte_is_root(mas->node))
> -		found = true;
>  done:
>  	mas->offset = offset;
>  	return found;
> -- 
> 2.20.1
>