Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 18:16:36 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     kilobyte@angband.pl
Cc:     "Winkler, Tomas" <tomas.winkler@intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "Usyskin, Alexander" <alexander.usyskin@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mei: deduplicate X86 && PCI dependencies, make them
 apply to all subentries
Message-ID: <2023042519-spookily-vocalist-51d2@gregkh>
References: <20230425152720.GA4155584@angband.pl>
 <20230425154314.21728-1-kilobyte@angband.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230425154314.21728-1-kilobyte@angband.pl>
Precedence: bulk

On Tue, Apr 25, 2023 at 05:43:14PM +0200, kilobyte@angband.pl wrote:
> From: Adam Borowski <kilobyte@angband.pl>
> 
> The Kconfig "depends on X86 && PCI" line was repeated for 4 out of 6 config
> symbols here -- which was both unnecessarily repetitive, and caused a
> dormant problem for the two remaining symbols lacking the dependency.
> 
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---
>  v2: instead of adding new depends, wrap all of mei in "if..endif"
> 
>  drivers/misc/mei/Kconfig | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig
> index d21486d69df2..f2ab2696fa78 100644
> --- a/drivers/misc/mei/Kconfig
> +++ b/drivers/misc/mei/Kconfig
> @@ -1,8 +1,8 @@
>  # SPDX-License-Identifier: GPL-2.0
>  # Copyright (c) 2003-2019, Intel Corporation. All rights reserved.
> +if X86 && PCI

Please no, that's not a normal Kconfig thing to do at all, sorry.

greg k-h