Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 12:45:07 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH 7/9] maple_tree: Delete redundant code in mas_next_node()
Message-ID: <20230425164507.dulntzwtkm5mp4ia@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org
References: <20230425110511.11680-1-zhangpeng.00@bytedance.com>
 <20230425110511.11680-8-zhangpeng.00@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230425110511.11680-8-zhangpeng.00@bytedance.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FRP0qr2C7Q5HrHCb0YSjXspiVi3t3NuntG6QbdZ1OME1/gtaePyT6XSfoHq5?=
 =?us-ascii?Q?tRwghkG6n2SUDWNVePmItObeVZPfdKSTaBr9KFONuB8F6N5OOXqSxHAmlmEn?=
 =?us-ascii?Q?DQQfNdK4bZe6McDAxMwtoKSLMI+2A7DdtcYdmOVamSTZZtaPnmCBsiXUJRrd?=
 =?us-ascii?Q?h6BwoF+rr2lfwB77ehxOFYRILwgotnDqQ4+XN508EfSPg/uXp2vRdpvdjD34?=
 =?us-ascii?Q?9BRIbJEw8kcFOWfwuK3Jvq1jc4Paw8/zvv0zQkXepukKxe/cKPSPxai/A+8/?=
 =?us-ascii?Q?lQGASGd5MqtJxy/3DHMlLf4MfoOmm+Pe/1LH98UuCCKIxHcTZ3EOiBwzLm/m?=
 =?us-ascii?Q?ryCcFCCdPE8vgNyVliHpE0z9Tre7UfnH3/MAVnLxzQIQYyCHI4SKK3kY1P78?=
 =?us-ascii?Q?6qYPNaHoZ9eKETJO25qpoKm/ndOpKrQUY3EI9VLmvq/6YRcfM4P5212Vnxtk?=
 =?us-ascii?Q?X/tq7ORtgOFBQnUtMaSn58lVkyla80tOD6QqfSuqW6CI7GNzpj9pZaPzBgxw?=
 =?us-ascii?Q?u+nCj4PNHtpBH2ClAkK0OAxORh41BVimo/XdvVRzZgUI3/qHXSLj0Fdln+Jh?=
 =?us-ascii?Q?MCyq4W+7PV6k+db/DjqFbe7C6lCWWoR/byWKnjemYMNLg5LI1awzx0omtdg6?=
 =?us-ascii?Q?mwu11PvxlrmiU9FyUkNnpE2u3wY8mm5CFFGk/U3RjjeiMLn3IJhkhZHiXaxK?=
 =?us-ascii?Q?IruBj0F2iDD9njuiU+WSR9JfnPEVzlVKlepY9GJ2zPRNjhUufwDFUtX+E2ur?=
 =?us-ascii?Q?SYSHW8pHOjM/KsmlCeFS1HU4WGK4Me5X0hsc7DxwfKkHRyb9aXFLSdZO5PLK?=
 =?us-ascii?Q?Siz0uXRMZW3Z73ww2/eBU8561hOV7DlTX/SfofK1R997h+IstCCPMBcnCAOE?=
 =?us-ascii?Q?FmACU7ZK3w0KEy7rdST9WXRFSR0lvEDqW8wVqUMyi4vtIYxywxqThILeQmq5?=
 =?us-ascii?Q?DWmbvMiNDZaF/vn3b84rci0g0v6VuGjIdSNWxbX9sGKX3g9JWQVdiZNX0+jo?=
 =?us-ascii?Q?B703VtFLELlDMovAY2azXYao4xf7yIbA3XpQpZEevx5+kDEXDEL1yiVAs5Zy?=
 =?us-ascii?Q?321wWKQ+LrOoCdiKWO0xWfdyDwtM/9hjRhLkFcUYUFL9GxV5gPrXbz+CFL66?=
 =?us-ascii?Q?v8CJ95OO2Fzjzx+5O9m6r6ZAbTCcbDaTLCCHEyKjNWPvXuUqVdCHjwC5ygLM?=
 =?us-ascii?Q?RrWBlbd+CuXu93InjDtgFLluXPVirXWsvuDV1kl17gdqpgxFL+TBMOChv2H+?=
 =?us-ascii?Q?0D3AT6YMnIMORootbWUuC6I9QwLQjDOcrPlgMycO2fP7exh9oa0qg3N/nZbI?=
 =?us-ascii?Q?YvOO5RHBzvvHb28lRbA5VasUmpNVs8JPSAQjpJ1bpt8YWhbv4f5JfREdEQ87?=
 =?us-ascii?Q?pw3MFx5cXRPPgP7SZwywzmz8tkA7C9aPZ7wq+ZoUKZJ/6jWAxhwnveEXiLtF?=
 =?us-ascii?Q?nL5oH6h4a40J/O2SoX2MZHmMniLIY529K1AiKQ70W8srw1KyS8vuca5cKkuF?=
 =?us-ascii?Q?YkYufWEv05dYUe+GEABLDZZXnRFhxq0ylaCaGzpwXw0D9Rglpou2jnAb7kUp?=
 =?us-ascii?Q?looevq7PI0lHPbZ4mZygMzdOjXPFhixyXrOJ2xcMlthYKchNLF8NabfsoKrZ?=
 =?us-ascii?Q?xA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?DL1eTuUZGcbnxWvaSOzmO/Ky4Yzx9paHHMmcANAC7fMy+HjvSnCydrKwGC0I?=
 =?us-ascii?Q?hMX5sX9Ha4Bz/6CFzFDGyVVYmelvD9lSz4QSE/k8iTZ84yZ/wI1yEqv7fjZT?=
 =?us-ascii?Q?l8Tz8bcj0NwHJZ16M6YEoU9HbvdRK0E7xs34EfFqFH3swpa8wfS4gi/lsv40?=
 =?us-ascii?Q?+p45jZfaPK4sekvvcWDnVpcMFmcAH6XwHeEh8Cfujp+tUZ/93ouqpUuFjYGr?=
 =?us-ascii?Q?zZca/keYWYcbypDiS4dLgnBWswSA2VZOmPN0lGUrAAAEQUXpBFavs5FuzuqJ?=
 =?us-ascii?Q?2v5Nb3MBUZdM7IcUxTWETny3NCBGwI6/umpuQOnOeH284m0tPBN+cYXeb9s7?=
 =?us-ascii?Q?Z/bZcttrftXqbvcgjJy4PZKhRjfTCKAIHtYh2p1UkiNAv+aDu6IjiAForIRo?=
 =?us-ascii?Q?H3QRlRPRKkV5C9Tjpns750k0jCW7KytZ+iO31I6oqhBkBpE1oqbRio5wvtEr?=
 =?us-ascii?Q?Z0/hgku/2QbRdWm8/m/pEi1YLMMLjrVf5I1XZlhXIrpNKcj2MIYs4WYpJhIJ?=
 =?us-ascii?Q?TFJQaGnWgLmTJtr1d7pt/3LVuEtgbj6CmM4/Hllj4r9z6oA5icr06CfFPDKd?=
 =?us-ascii?Q?KDBaBxgd4Agu8iA+J3Gt0JcaOjYKDo4b+bornaWAfcBVXWFwIZsYOpq/5I65?=
 =?us-ascii?Q?kapPJaD40xY0aVlyWtW6ecR9MZPh3IUB+d0tWmT8O0Ou376a20RkZ07IybKi?=
 =?us-ascii?Q?ZvsQVgFKgjogsTusLloGdvG86rNuPQGggdEKxNGiLFHlolD/wHR4HlHhlRZZ?=
 =?us-ascii?Q?8UFxHlZJLs5ms6LQM4AP1RMI8/WjwpGGoIH7+lwrzJZ1zAgcbb+VP+/hlgy/?=
 =?us-ascii?Q?0fiirWkUeploX+zMizmYyCpW9KvRMG8slopkcYhBgjn7akJhYqNtB7nynqs+?=
 =?us-ascii?Q?4ZM85zEtjFCWQw5UkOCbl4HdBt4uJSeG9D2CU2FdFC+S06gakCI0oQi7c+gS?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9597da0-dbb6-4423-f88b-08db45ac6ecf
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 16:45:09.9948
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NeFH/gRwVV7ClSRGm6m8b4vbQ2yo56HgyUBHMcLcmd5iMZAVfEm27Q5eShbHhZhoNjW/KpQiN+kmk6Jld0S1dQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5363
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-25_08,2023-04-25_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2304250151
X-Proofpoint-GUID: WCjIdNiqHPydPrBYotUrzMRwV6Trna9n
X-Proofpoint-ORIG-GUID: WCjIdNiqHPydPrBYotUrzMRwV6Trna9n
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Peng Zhang <zhangpeng.00@bytedance.com> [230425 07:05]:

The title of the patch seems wrong.

This isn't redundant code and you aren't deleting it.. you are moving a
block of code outside a loop.  You did modify the check though, is that
the redundant code?

> When offset == node_end is satisfied, go to the parent node, mas->max
> will not change. So there is no need to update min on the move.

Please try not to state the code in your commit message.

I have moved this block of code in patch 27/34 [1]

> 
> Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
> ---
>  lib/maple_tree.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 83441ef2e1f57..8bfa837b7b752 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -4616,7 +4616,8 @@ static inline int mas_next_node(struct ma_state *mas, struct maple_node *node,
>  	enum maple_type mt;
>  	void __rcu **slots;
>  
> -	if (mas->max >= max)
> +	min = mas->max + 1;
> +	if (min > max)
>  		goto no_entry;

What happens on overflow?

>  
>  	level = 0;
> @@ -4624,10 +4625,6 @@ static inline int mas_next_node(struct ma_state *mas, struct maple_node *node,
>  		if (ma_is_root(node))
>  			goto no_entry;
>  
> -		min = mas->max + 1;
> -		if (min > max)
> -			goto no_entry;
> -
>  		if (unlikely(mas_ascend(mas)))
>  			return 1;
>  
> -- 
> 2.20.1
> 

[1] https://lore.kernel.org/linux-mm/20230425140955.3834476-28-Liam.Howlett@oracle.com/