Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 13:04:27 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Hao Zeng <zenghao@kylinos.cn>
Cc:     chenhuacai@kernel.org, zhangqing@loongson.cn,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] recordmcount: Fix memory leaks in the uwrite
 function
Message-ID: <20230425130427.39b58745@gandalf.local.home>
In-Reply-To: <20230425024603.4005251-1-zenghao@kylinos.cn>
References: <20230425024603.4005251-1-zenghao@kylinos.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 25 Apr 2023 10:46:03 +0800
Hao Zeng <zenghao@kylinos.cn> wrote:

> @@ -117,7 +118,13 @@ static ssize_t uwrite(void const *const buf, size_t const count)
>  		off_t aoffset = (file_ptr + count) - file_end;
>  
>  		if (aoffset > file_append_size) {
> -			file_append = realloc(file_append, aoffset);
> +			p = realloc(file_append, aoffset);
> +			if (!p) {
> +				free(file_append);
> +				file_append = NULL;
> +			} else {
> +				file_append = p;
> +			}

You can simplify the above with:

			if (!p)
				free(file_append);

			file_append = p;

-- Steve

>  			file_append_size = aoffset;
>  		}
>  		if (!file_append) {