Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH tracing 0/3] tracing: support > 8 byte filter predicates
To:     "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc:     rostedt@goodmis.org, corbet@lwn.net, shuah@kernel.org,
        linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org
References: <1682414197-13173-1-git-send-email-alan.maguire@oracle.com>
 <20230425233233.2ad5168c630b4c1349ab3398@kernel.org>
From:   Alan Maguire <alan.maguire@oracle.com>
Message-ID: <9c4cebb7-514c-f7fd-1f95-50837460eb66@oracle.com>
Date:   Tue, 25 Apr 2023 18:15:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.3
In-Reply-To: <20230425233233.2ad5168c630b4c1349ab3398@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWVrMW81WUhRYkRQT2EvYzRuRnFkVnlleU0yeWo1cWpnSDE2L05hbjllelFG?=
 =?utf-8?B?ZHJFU3VOc1o1cHEwOHVVZncyU1pnd3FFTnFLQWJCNEY2VkpEbU13SFRvcjFX?=
 =?utf-8?B?ZkJPTFZXVjF0OTg2ZTlYNWxTU1FzMkJXUVlJQXBkSXYrTE1HWG5hVDN3eUNr?=
 =?utf-8?B?Qi9LRS90ZStJQitGZ2NEQTNYVUxFRXZtSTVkcWU2RzJrOW5JOEYvMjUrZ2Zi?=
 =?utf-8?B?SUxHdVlrOUtCS2Z3SGxkaFVVQVZqelFoeFcwRDg1ZGEwUUowaHJ3d25GT1Zn?=
 =?utf-8?B?cjRTZWwyVFJTdnJWRVZ1OWxwTzJ6K3VrUkxWNHhVSi9QeVkzS294MUplM2JD?=
 =?utf-8?B?cVRzN3FudFZLSGRnVHAzWkp4UzNhMHpRKy9wSmJiRnk3dEgzNVU1d0JaZ2RZ?=
 =?utf-8?B?dVExVjh4cEFNc25vdGpMeE4yOEV1VDRPdmlrRHlCUDFCVHV4UEEySytZMklh?=
 =?utf-8?B?akQ3RkpETEY4NGR2bWhhQ3VsM0k2bXhQaWFuVWJLdVhzcWg2ODMxa2RWWWVD?=
 =?utf-8?B?UEwyd3pMM2wxanMxUE0wcmUreHJKVUtDTEJjRUtXQzB6VWFZMEVVVEw0S1I4?=
 =?utf-8?B?WHRCVXhHdDhWbyszUFBxK1NaUWl3Z0IvMDNUaFBrTmoyaFR2KyttZHd6ZEkz?=
 =?utf-8?B?eUVGRFVyMjZSSDZIRzNKWUxWdzRnWCswRDB4cmpvZUlSSGdqdTJkK2hVbzA0?=
 =?utf-8?B?anozTWI1b1J2V2N6MzhwLzV4ektESTAwZDZyeWtjd3k3cUNrWXc4bjJtR1Z5?=
 =?utf-8?B?ajIzeWhaUG5jdzNhMjBFKzRsS1U4dnh1Z05RQkFraGU5VXBteStUR0Jwd3ZP?=
 =?utf-8?B?SEZKQU9yenpvYVBWUFdsQ3FPT1MyOE5ZNnZ3dnl3bmMwQUlYV0dGWkxjTkJS?=
 =?utf-8?B?SkFPTTBaeXFqdVhYd3AvcklWeXZleVlKZkhOVjVHRUEzY3pvWjVhYnpmaWZ5?=
 =?utf-8?B?VkR1KzVpWnNlS05RWXNqajY0MVJHbUs1NzNpUmt2L2ZUM0pZeE5jZWF5eEMx?=
 =?utf-8?B?UkZNbE9TYlhkNHkwNEdxTW5Ha2ovWXpBRWVNczNHbXdKamhFcnNGU2VBK3Rn?=
 =?utf-8?B?QVdqNXF3UEd5TFdtcGRRV1NNTnI4NkI3VUJta1Q0REVYZjZIUEhNZElxNXdv?=
 =?utf-8?B?Vk1kREJRWXNTd0QvNlhXUUpSQUhtV3JJaXhHRWJxT2dzS2NpalNYM2lLcnh0?=
 =?utf-8?B?NUdyRFdHQVR4UFhTR29rLzc3VmdFTDJna2FKY1pBSG5hdVBSZEM3VnRRRmZV?=
 =?utf-8?B?Qm5oTktyRVdGWmtvNDNWa1RXQksvaXBTSldZYmhIM1J2RSszZmx0OFdWem5J?=
 =?utf-8?B?ZEd1N2Z1Y2VVYWl0TTNmT1oybE8xQXZIa041aEdQZkJMczhaN1dTanAvSnR4?=
 =?utf-8?B?Uk93amVSMWxyMTh1bWl2VVN3QnQrYWtGRUZ0Q3RMdHZwVHpHaVlVOG90VFc5?=
 =?utf-8?B?N28yU1M0MktadFZ3ajZrS2ZyeHhmWG5GdExSSXpEeVJ3bXpxbFVqcHB6Y01B?=
 =?utf-8?B?MjV6Vll1YVVNS04wbEhHUXBKYmNEc1gvTFc5SGpDTTRyTTM4eHlFUDQ5UXQ1?=
 =?utf-8?B?OHltYTViQ2NPa0xNWkkxTTA1OEZhczhPUG8xRlhDU2dxNncvS01Mbllma3RC?=
 =?utf-8?B?a2pFWDI3V0RzTHNJd0hnQTlhQTJnQlRKM1AvMkJ3UXViKzVyMVFnaFk2M3pk?=
 =?utf-8?B?Q0pLZEwzazk0amlNd28vM0tsSmQ0UW1LMEFHazNNWmFtYW9Nd1dmV0NWWHh1?=
 =?utf-8?B?MnFhSnNkRURjUXRzM3c2ekhRT3AvbU1URGE5ZlIzSTdvNWt3a0pkdlFYcmtZ?=
 =?utf-8?B?YlJwTkpJZS9qL2RFQVlJcTF6MWgyMDZTMmhYbDhsU3NQTHZrM1dUZlBPUTVZ?=
 =?utf-8?B?V0tkQTFNUit4WnVHQ0pPY2xqMnduYjZBNTFYYkJFb3ZqNWhzZzhadGlHd1dk?=
 =?utf-8?B?Z0FkTnhzY3FVMzI3VDJEejdQbkNYaFZmMWtaUTRyRGV5d2JFWGduOENIZ2p0?=
 =?utf-8?B?WEVDMXdJM0ttOFhLalFjYU9ZL0FIWDJKSENqd2FuMlI5N3hKWW1zTXNPWk16?=
 =?utf-8?B?QjJQV1V5clFaby81czZOYTBXcGdvemtsNDRaMGE2QXErMDdsZHBRYU9UbUlx?=
 =?utf-8?B?UGZEM3dTWk5lWTMrWU9jTjE0bGdGR3I4b2JtT0dkaEpncXZwaFdqQThCTXVW?=
 =?utf-8?Q?PVj52fLYUSneY1CjJN46jqs=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: AEVVEiIjstq0ZhgfdRSnd8jK4+jpBBZKeTTUjn2z9bYzrz+MX19wBXUIWtF3BLYe9IwVjo8Fi0/hzeFXzXgYNIY27C3NAUVzZLzjDwE3hNQG4UT3pvy0FU8QAfNHGnAyNUrSkZob2iaBoZ0uvKiA5cn6XS6UH0eWvDiK9Or6l0DZ1wsOjjKJtawzIbYypox6p3KVEGgKecllPJWMevA5OrrCEp1FRN5i+FphT70OT8qTgE5VnubfdoBB3QvtpNJXVkb2r6d/Dar6LkYhdSSgafldqR4840EhPhl0hSxjwNj+fwkmxqJHMO9sQ/frH9igfUrZ1xh9VnaHDHPx5zSt5j4TYDVL2KxKteVevNTd9zkOTDApTP19Qq4dC45AdIvKD7CoINc4wB+upnZqtQcar1opbQTtNYKbX++r5AUUPrpJhnjeHGo31UVUncCRt1KCuggMCy4gJ76awg8eIwVIkR7ABbbWgS9jcxoCnMAGxCJyHWoeapRDvnnnNTigusMUpjIfmQsy/NRW+TM4Jl9eu+bMeZUi54rEZr33qRuoLXva31OWLX0PX0cY1IcUJLAV9NK9OUrJwSa9WMCPT6EDi1PQWk3kX37zTxXZRgvw0WyvK6MUSdkqSGdzRk+L2FB1rWKKxjzRVE7gmN+p3S5fHo5G7Hxi8Cp+jkQosA69I4QDONYynXVzkf1YYe66Q22yTj4zNw6SwMiVvyyRULrCeL4NJfmNczdJxrqq/4H7/nYuCr7UnaQSBO/geiIlU7oPCLPgtq1sBdSOK0od2fZNVF3Dx8QbEuHh5ABAcBwD8yUOBMPx/ijZ2jegLBJ3wnb3mpRBw7okClWAFyMioNlpXg==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cb1f02d-d791-4042-450d-08db45b09f6f
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5267.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 17:15:09.6360
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G+Ir5tItFJfwFERyCgWUNC1WpB3sO+X1TlfaQRWcxiwwIL+9/b676TAHHlCEGbjU0IDUeinhdKO9oIWsuhQZKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6046
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-25_08,2023-04-25_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2304250155
X-Proofpoint-GUID: s40Hkwnz9cuwAhrEL_dveNu4ag6oW1vE
X-Proofpoint-ORIG-GUID: s40Hkwnz9cuwAhrEL_dveNu4ag6oW1vE
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25/04/2023 15:32, Masami Hiramatsu (Google) wrote:
> On Tue, 25 Apr 2023 10:16:34 +0100
> Alan Maguire <alan.maguire@oracle.com> wrote:
> 
>> For cases like IPv6 addresses, having a means to supply tracing
>> predicates for fields with more than 8 bytes would be convenient.
>> This series provides a simple way to support this by allowing
>> simple ==, != memory comparison with the predicate supplied when
>> the size of the field exceeds 8 bytes.  For example, to trace
>> ::1, the predicate
>>
>> 	"dst == 0x00000000000000000000000000000001"
>>
>> ..could be used.
> 
> Nice!
> And I also would like to use something like "dst == ipv6(::1)" because
> it seems easy to make a mistake on the number of zeros.
> 
> Can we add such type casting feature to the filter?
>

that's a great idea; what would be the most consistent ftrace syntax
for this do you think? I noticed that hist triggers append a modifier
to the field name so would something like

"dst.ipv6 == ::1"

make sense maybe? Thanks!

Alan

 
> Thank you,
> 
>>
>> Patch 1 provides the support for > 8 byte fields via a memcmp()-style
>> predicate. Patch 2 adds tests for filter predicates, and patch 3
>> documents the fact that for > 8 bytes. only == and != are supported.
>>
>> Changes since RFC [1]:
>>
>> - originally a fix was intermixed with the new functionality as
>>   patch 1 in series [1]; the fix landed separately
>> - small tweaks to how filter predicates are defined via fn_num as
>>   opposed to via fn directly
>>
>> [1] https://lore.kernel.org/lkml/1659910883-18223-1-git-send-email-alan.maguire@oracle.com/
>>
>> Alan Maguire (3):
>>   tracing: support > 8 byte array filter predicates
>>   selftests/ftrace: add test coverage for filter predicates
>>   tracing: document > 8 byte numeric filtering support
>>
>>  Documentation/trace/events.rst                |  9 +++
>>  kernel/trace/trace_events_filter.c            | 55 +++++++++++++++-
>>  .../selftests/ftrace/test.d/event/filter.tc   | 62 +++++++++++++++++++
>>  3 files changed, 125 insertions(+), 1 deletion(-)
>>  create mode 100644 tools/testing/selftests/ftrace/test.d/event/filter.tc
>>
>> -- 
>> 2.31.1
>>
> 
>