Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230412171441.18958-1-zyytlz.wz@163.com> <2bd0143cf0e638c88f57409f854c0529a1b12b6b.camel@linux.intel.com>
In-Reply-To: <2bd0143cf0e638c88f57409f854c0529a1b12b6b.camel@linux.intel.com>
From:   Zheng Hacker <hackerzheng666@gmail.com>
Date:   Wed, 26 Apr 2023 01:18:12 +0800
Message-ID: <CAJedcCzptvdgk8vMO5F==NS79gTZdWaL1id8GcbUn2UsbQr8Xg@mail.gmail.com>
Subject: Re: [PATCH] HID: intel-ish-hid: pci-ish: Fix use after free bug in
 ish_remove due to race condition
To:     srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
Cc:     Zheng Wang <zyytlz.wz@163.com>, jikos@kernel.org,
        benjamin.tissoires@redhat.com, rafael@kernel.org,
        hdegoede@redhat.com, gregkh@linuxfoundation.org,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        1395428693sheep@gmail.com, alex000young@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

srinivas pandruvada <srinivas.pandruvada@linux.intel.com> =E4=BA=8E2023=E5=
=B9=B44=E6=9C=8825=E6=97=A5=E5=91=A8=E4=BA=8C 23:55=E5=86=99=E9=81=93=EF=BC=
=9A
>
> On Thu, 2023-04-13 at 01:14 +0800, Zheng Wang wrote:
> > In ish_probe, it calls ish_dev_init to init the device. In this
> > function,
> > ishtp_device_init is called and &dev->bh_hbm_work is bound with
> > bh_hbm_work_fn. recv_hbm may be called to start the timer work.
> >
> > If we remove the module which will call ish_remove to make cleanup,
> > there may be an unfinished work. The possible sequence is as follows:
> >
> > Fix it by canceling the work before cleanup in
> > ishtp_bus_remove_all_clients
> >
> > CPU0                  CPUc1
> >
> >                     |bh_hbm_work_fn
> > ish_remove      |
> > ishtp_bus_remove_all_clients  |
> > kfree(ishtp_dev->fw_clients); |
> >                     |
> >                     |&dev->fw_clients[...]
> >                     |   //use
> >
> > Fixes: 3703f53b99e4 ("HID: intel_ish-hid: ISH Transport layer")
> > Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
> It is a extremely rare case, so it is OK to not mark for stable.

Got it, thanks!

Best regards,
Zheng

>
> > ---
> >  drivers/hid/intel-ish-hid/ishtp/bus.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c
> > b/drivers/hid/intel-ish-hid/ishtp/bus.c
> > index 81385ab37fa9..ada7cd08dbeb 100644
> > --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> > +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> > @@ -744,6 +744,7 @@ void ishtp_bus_remove_all_clients(struct
> > ishtp_device *ishtp_dev,
> >                  */
> >         }
> >         spin_unlock_irqrestore(&ishtp_dev->cl_list_lock, flags);
> > +       cancel_work_sync(&ishtp_dev->bh_hbm_work);
> >
> >         /* Release DMA buffers for client messages */
> >         ishtp_cl_free_dma_buf(ishtp_dev);
>